[INFO] fetching crate luna_nbt 0.0.3... [INFO] checking luna_nbt-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate luna_nbt 0.0.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate luna_nbt 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate luna_nbt 0.0.3 [INFO] finished tweaking crates.io crate luna_nbt 0.0.3 [INFO] tweaked toml for crates.io crate luna_nbt 0.0.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b9d6ee6cedded2653e1ad002d4c562edf0ddb6b7f25032b20fa323d75971b25 [INFO] running `Command { std: "docker" "start" "-a" "6b9d6ee6cedded2653e1ad002d4c562edf0ddb6b7f25032b20fa323d75971b25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b9d6ee6cedded2653e1ad002d4c562edf0ddb6b7f25032b20fa323d75971b25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b9d6ee6cedded2653e1ad002d4c562edf0ddb6b7f25032b20fa323d75971b25", kill_on_drop: false }` [INFO] [stdout] 6b9d6ee6cedded2653e1ad002d4c562edf0ddb6b7f25032b20fa323d75971b25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2879cc625222e2807b8cd57c7313c89009d849d15b7b32a080242bdd4572bc5a [INFO] running `Command { std: "docker" "start" "-a" "2879cc625222e2807b8cd57c7313c89009d849d15b7b32a080242bdd4572bc5a", kill_on_drop: false }` [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking luna_nbt v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 121 | unsigned_type!(self, visitor, Byte, TAG_Byte, visit_u8, u8, "u8") [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 125 | unsigned_type!(self, visitor, Short, TAG_Short, visit_u16, u16, "u16") [INFO] [stdout] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 129 | unsigned_type!(self, visitor, Int, TAG_Int, visit_u32, u32, "u32") [INFO] [stdout] | ------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 134 | unsigned_type!(self, visitor, Long, TAG_Long, visit_u64, u64, "u64") [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 121 | unsigned_type!(self, visitor, Byte, TAG_Byte, visit_u8, u8, "u8") [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 125 | unsigned_type!(self, visitor, Short, TAG_Short, visit_u16, u16, "u16") [INFO] [stdout] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 129 | unsigned_type!(self, visitor, Int, TAG_Int, visit_u32, u32, "u32") [INFO] [stdout] | ------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/de.rs:54:82 [INFO] [stdout] | [INFO] [stdout] 54 | return Err(NBTError::UnserializableType { type_name: $name.to_string() }); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 134 | unsigned_type!(self, visitor, Long, TAG_Long, visit_u64, u64, "u64") [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `unsigned_type` [INFO] [stdout] = note: this warning originates in the macro `unsigned_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/blob.rs:71:67 [INFO] [stdout] | [INFO] [stdout] 71 | T::from_borrowed_tag(self.elements.get(&name.to_string())?.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tags::Tag` does not implement `Clone`, so calling `clone` on `&tags::Tag` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 71 - T::from_borrowed_tag(self.elements.get(&name.to_string())?.clone()) [INFO] [stdout] 71 + T::from_borrowed_tag(self.elements.get(&name.to_string())?) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tags::Tag`, implement `Clone` for it [INFO] [stdout] --> src/tags.rs:109:1 [INFO] [stdout] | [INFO] [stdout] 109+ #[derive(Clone)] [INFO] [stdout] 110| pub enum Tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:33:88 [INFO] [stdout] | [INFO] [stdout] 33 | ...n into_tag(self) -> Tag { Tag::Compound(self.into_iter().map(|(k, v)| (k, v.into_tag())).collect()) } } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/blob.rs:71:67 [INFO] [stdout] | [INFO] [stdout] 71 | T::from_borrowed_tag(self.elements.get(&name.to_string())?.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tags::Tag` does not implement `Clone`, so calling `clone` on `&tags::Tag` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 71 - T::from_borrowed_tag(self.elements.get(&name.to_string())?.clone()) [INFO] [stdout] 71 + T::from_borrowed_tag(self.elements.get(&name.to_string())?) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tags::Tag`, implement `Clone` for it [INFO] [stdout] --> src/tags.rs:109:1 [INFO] [stdout] | [INFO] [stdout] 109+ #[derive(Clone)] [INFO] [stdout] 110| pub enum Tag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:33:88 [INFO] [stdout] | [INFO] [stdout] 33 | ...n into_tag(self) -> Tag { Tag::Compound(self.into_iter().map(|(k, v)| (k, v.into_tag())).collect()) } } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luna_nbt` (lib) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `luna_nbt` (lib test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2879cc625222e2807b8cd57c7313c89009d849d15b7b32a080242bdd4572bc5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2879cc625222e2807b8cd57c7313c89009d849d15b7b32a080242bdd4572bc5a", kill_on_drop: false }` [INFO] [stdout] 2879cc625222e2807b8cd57c7313c89009d849d15b7b32a080242bdd4572bc5a