[INFO] fetching crate ltp 0.1.9... [INFO] checking ltp-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ltp 0.1.9 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ltp 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ltp 0.1.9 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ltp 0.1.9 [INFO] tweaked toml for crates.io crate ltp 0.1.9 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate ltp 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0192ed7c39848e89f5a136d49c43a71fe38abb0010bf650c6a7536321c91ab5 [INFO] running `Command { std: "docker" "start" "-a" "f0192ed7c39848e89f5a136d49c43a71fe38abb0010bf650c6a7536321c91ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0192ed7c39848e89f5a136d49c43a71fe38abb0010bf650c6a7536321c91ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0192ed7c39848e89f5a136d49c43a71fe38abb0010bf650c6a7536321c91ab5", kill_on_drop: false }` [INFO] [stdout] f0192ed7c39848e89f5a136d49c43a71fe38abb0010bf650c6a7536321c91ab5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94738eb2dc4445a3e5040b57546975a8480232f1bbe08482dd5801f7e7acb806 [INFO] running `Command { std: "docker" "start" "-a" "94738eb2dc4445a3e5040b57546975a8480232f1bbe08482dd5801f7e7acb806", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking compare v0.1.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking binary-heap-plus v0.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cedarwood v0.4.6 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking ltp v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perceptron/feature.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn features(self) -> Vec<(String, usize)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/perceptron/feature.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | self.deref().get_with_key(key) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/perceptron/feature.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | self.deref().feature_num() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perceptron/model.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 222 | sentence: ::Item, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let (fragment, features) = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(self.definition.predict(&sentence, &fragment, &preds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/perceptron/parameter.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | self.deref().len() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/perceptron/parameter.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | self.deref().is_empty() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perceptron/trainer.rs:116:15 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new_with_define(define: Define) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ltp` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "94738eb2dc4445a3e5040b57546975a8480232f1bbe08482dd5801f7e7acb806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94738eb2dc4445a3e5040b57546975a8480232f1bbe08482dd5801f7e7acb806", kill_on_drop: false }` [INFO] [stdout] 94738eb2dc4445a3e5040b57546975a8480232f1bbe08482dd5801f7e7acb806