[INFO] fetching crate lstngrp 0.0.2... [INFO] checking lstngrp-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lstngrp 0.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate lstngrp 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lstngrp 0.0.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate lstngrp 0.0.2 [INFO] tweaked toml for crates.io crate lstngrp 0.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate lstngrp 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd6c308c6c168dec5bac62cfa371f8e4b2a05a682e841b4b72399307ead4e4f7 [INFO] running `Command { std: "docker" "start" "-a" "cd6c308c6c168dec5bac62cfa371f8e4b2a05a682e841b4b72399307ead4e4f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd6c308c6c168dec5bac62cfa371f8e4b2a05a682e841b4b72399307ead4e4f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd6c308c6c168dec5bac62cfa371f8e4b2a05a682e841b4b72399307ead4e4f7", kill_on_drop: false }` [INFO] [stdout] cd6c308c6c168dec5bac62cfa371f8e4b2a05a682e841b4b72399307ead4e4f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 995799eb715235d029f8828f5e615d02de2a05c5db0afd9d2fa692277d24d1f1 [INFO] running `Command { std: "docker" "start" "-a" "995799eb715235d029f8828f5e615d02de2a05c5db0afd9d2fa692277d24d1f1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking killswitch v0.4.2 [INFO] [stderr] Checking idbag v0.1.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking protwrap v0.3.0 [INFO] [stderr] Checking lstngrp v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | lmap: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | lhandler: Arc::new(handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | cmap: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | shutdown: Arc::new(AtomicBool::new(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:355:65 [INFO] [stdout] | [INFO] [stdout] 355 | .filter_map(|(cid, cdata)| (cdata.lid == lid).then_some(cid.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:426:14 [INFO] [stdout] | [INFO] [stdout] 426 | lid: lid.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:16 [INFO] [stdout] | [INFO] [stdout] 428 | conns: Vec::new() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:116:61 [INFO] [stdout] | [INFO] [stdout] 116 | async fn connected(&mut self, sa: SockAddr, strm: Stream) { [INFO] [stdout] | _______________________________________________------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | | // If the ListenerGroup is in the process of being shut down, then just [INFO] [stdout] 118 | | // ignore any new connections. [INFO] [stdout] 119 | | if self.shutdown.load(Ordering::Relaxed) { [INFO] [stdout] ... | [INFO] [stdout] 148 | | //self.ctaskmap.lock().insert(cid.clone(), jh); [INFO] [stdout] 149 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | lmap: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | lhandler: Arc::new(handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | cmap: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 202 | / handler: impl GroupHandler [INFO] [stdout] 203 | | + Send [INFO] [stdout] 204 | | + Sync [INFO] [stdout] 205 | | + 'static [INFO] [stdout] | |_______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let idbag = Arc::new(IdBag::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | shutdown: Arc::new(AtomicBool::new(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:355:65 [INFO] [stdout] | [INFO] [stdout] 355 | .filter_map(|(cid, cdata)| (cdata.lid == lid).then_some(cid.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:426:14 [INFO] [stdout] | [INFO] [stdout] 426 | lid: lid.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:16 [INFO] [stdout] | [INFO] [stdout] 428 | conns: Vec::new() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:116:61 [INFO] [stdout] | [INFO] [stdout] 116 | async fn connected(&mut self, sa: SockAddr, strm: Stream) { [INFO] [stdout] | _______________________________________________------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | | // If the ListenerGroup is in the process of being shut down, then just [INFO] [stdout] 118 | | // ignore any new connections. [INFO] [stdout] 119 | | if self.shutdown.load(Ordering::Relaxed) { [INFO] [stdout] ... | [INFO] [stdout] 148 | | //self.ctaskmap.lock().insert(cid.clone(), jh); [INFO] [stdout] 149 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lstngrp` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lstngrp` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "995799eb715235d029f8828f5e615d02de2a05c5db0afd9d2fa692277d24d1f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "995799eb715235d029f8828f5e615d02de2a05c5db0afd9d2fa692277d24d1f1", kill_on_drop: false }` [INFO] [stdout] 995799eb715235d029f8828f5e615d02de2a05c5db0afd9d2fa692277d24d1f1