[INFO] fetching crate lsp-async-stub 0.6.4... [INFO] checking lsp-async-stub-0.6.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lsp-async-stub 0.6.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate lsp-async-stub 0.6.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lsp-async-stub 0.6.4 [INFO] finished tweaking crates.io crate lsp-async-stub 0.6.4 [INFO] tweaked toml for crates.io crate lsp-async-stub 0.6.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lsp-types v0.93.2 (latest: v0.97.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c61841c263e6601f4d3a6875ba1570491030ddcd94653ae01cb8cb7eddcf6423 [INFO] running `Command { std: "docker" "start" "-a" "c61841c263e6601f4d3a6875ba1570491030ddcd94653ae01cb8cb7eddcf6423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c61841c263e6601f4d3a6875ba1570491030ddcd94653ae01cb8cb7eddcf6423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c61841c263e6601f4d3a6875ba1570491030ddcd94653ae01cb8cb7eddcf6423", kill_on_drop: false }` [INFO] [stdout] c61841c263e6601f4d3a6875ba1570491030ddcd94653ae01cb8cb7eddcf6423 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] da75e336753234ac3ea9daf3a356e916d9d844461c788f06d562c4e267662001 [INFO] running `Command { std: "docker" "start" "-a" "da75e336753234ac3ea9daf3a356e916d9d844461c788f06d562c4e267662001", kill_on_drop: false }` [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rowan v0.15.16 [INFO] [stderr] Checking lsp-types v0.93.2 [INFO] [stderr] Checking lsp-async-stub v0.6.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `method` is never used [INFO] [stdout] --> src/handler.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait Handler { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 11 | fn method(&self) -> &'static str; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:607:20 [INFO] [stdout] | [INFO] [stdout] 605 | pub fn build(self) -> Server { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | Server { [INFO] [stdout] 607 | inner: Arc::new(AsyncMutex::new(self.inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:90:41 [INFO] [stdout] | [INFO] [stdout] 90 | params: self.params.map(|p| serde_json::to_value(p).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn success(data: R) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | result: Some(data), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:162:41 [INFO] [stdout] | [INFO] [stdout] 162 | result: self.result.map(|p| serde_json::to_value(p).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 173 | result: self.result.map(|v| serde_json::from_value(v).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 81 | context: Context, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 85 | | let req_id = message.id.clone(); [INFO] [stdout] 86 | | let req = match message.into_params::() { [INFO] [stdout] 87 | | Ok(r) => r, [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:172:7 [INFO] [stdout] | [INFO] [stdout] 169 | context: Context, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 173 | | let req = match message.into_params::() { [INFO] [stdout] 174 | | Ok(r) => r, [INFO] [stdout] 175 | | Err(_) => return, [INFO] [stdout] ... | [INFO] [stdout] 178 | | (self.f)(context, req.params.into()).await; [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `method` is never used [INFO] [stdout] --> src/handler.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait Handler { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 11 | fn method(&self) -> &'static str; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:607:20 [INFO] [stdout] | [INFO] [stdout] 605 | pub fn build(self) -> Server { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | Server { [INFO] [stdout] 607 | inner: Arc::new(AsyncMutex::new(self.inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:90:41 [INFO] [stdout] | [INFO] [stdout] 90 | params: self.params.map(|p| serde_json::to_value(p).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn success(data: R) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | result: Some(data), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:162:41 [INFO] [stdout] | [INFO] [stdout] 162 | result: self.result.map(|p| serde_json::to_value(p).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 173 | result: self.result.map(|v| serde_json::from_value(v).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 81 | context: Context, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 85 | | let req_id = message.id.clone(); [INFO] [stdout] 86 | | let req = match message.into_params::() { [INFO] [stdout] 87 | | Ok(r) => r, [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:172:7 [INFO] [stdout] | [INFO] [stdout] 169 | context: Context, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | ) { [INFO] [stdout] | _______^ [INFO] [stdout] 173 | | let req = match message.into_params::() { [INFO] [stdout] 174 | | Ok(r) => r, [INFO] [stdout] 175 | | Err(_) => return, [INFO] [stdout] ... | [INFO] [stdout] 178 | | (self.f)(context, req.params.into()).await; [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsp-async-stub` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsp-async-stub` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "da75e336753234ac3ea9daf3a356e916d9d844461c788f06d562c4e267662001", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da75e336753234ac3ea9daf3a356e916d9d844461c788f06d562c4e267662001", kill_on_drop: false }` [INFO] [stdout] da75e336753234ac3ea9daf3a356e916d9d844461c788f06d562c4e267662001