[INFO] fetching crate lsmtk 0.6.0... [INFO] checking lsmtk-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lsmtk 0.6.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lsmtk 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lsmtk 0.6.0 [INFO] finished tweaking crates.io crate lsmtk 0.6.0 [INFO] tweaked toml for crates.io crate lsmtk 0.6.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lsmtk 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3cc820a1a5b20212d1c843bbfc7654c5a751d2e6c2fb282943acbdc47d6a19d [INFO] running `Command { std: "docker" "start" "-a" "f3cc820a1a5b20212d1c843bbfc7654c5a751d2e6c2fb282943acbdc47d6a19d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3cc820a1a5b20212d1c843bbfc7654c5a751d2e6c2fb282943acbdc47d6a19d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3cc820a1a5b20212d1c843bbfc7654c5a751d2e6c2fb282943acbdc47d6a19d", kill_on_drop: false }` [INFO] [stdout] f3cc820a1a5b20212d1c843bbfc7654c5a751d2e6c2fb282943acbdc47d6a19d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae9be9c86412816e843c7ea054f7441259736a9fb13ca03581b740c15f49322d [INFO] running `Command { std: "docker" "start" "-a" "ae9be9c86412816e843c7ea054f7441259736a9fb13ca03581b740c15f49322d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling buffertk v0.8.0 [INFO] [stderr] Checking zerror v0.5.0 [INFO] [stderr] Checking biometrics v0.8.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking utilz v0.5.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking sync42 v0.8.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking setsum v0.6.0 [INFO] [stderr] Compiling derive_util v0.4.0 [INFO] [stderr] Compiling prototk_derive v0.8.0 [INFO] [stderr] Compiling arrrg_derive v0.4.0 [INFO] [stderr] Compiling zerror_derive v0.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking arrrg v0.4.0 [INFO] [stderr] Checking guacamole v0.8.0 [INFO] [stderr] Checking prototk v0.8.0 [INFO] [stderr] Checking armnod v0.7.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking one_two_eight v0.5.0 [INFO] [stderr] Checking tatl v0.7.0 [INFO] [stderr] Checking zerror_core v0.7.0 [INFO] [stderr] Checking indicio v0.5.0 [INFO] [stderr] Checking sst v0.9.0 [INFO] [stderr] Checking mani v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking skipfree v0.4.0 [INFO] [stderr] Checking lsmtk v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 236 | fn from(what: std::io::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Error::SystemError { [INFO] [stdout] 238 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:247:19 [INFO] [stdout] | [INFO] [stdout] 245 | fn from(what: mani::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | Error::ManifestError { [INFO] [stdout] 247 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/mod.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut mani = Manifest::open(options.mani.clone(), MANI_ROOT(&root))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let tree = LsmTree::from_manifest(options.clone(), mani)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let imm = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let imm_trigger = 0; [INFO] [stdout] 111 | let mem = Arc::new(MemTable::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mem_path = LOG_FILE(&root, seq_no); [INFO] [stdout] 113 | let mem_log = Self::start_new_log(&mem_path, options.log.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let state = Mutex::new(KeyValueStoreState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | root, [INFO] [stdout] 132 | | tree, [INFO] [stdout] 133 | | options, [INFO] [stdout] ... | [INFO] [stdout] 138 | | cnd_memtable_rolled_over, [INFO] [stdout] 139 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/mod.rs:295:12 [INFO] [stdout] | [INFO] [stdout] 294 | let log = ConcurrentLogBuilder::new(options, log_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Ok(Arc::new(log)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/memtable.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 69 | let iter = self.skiplist.iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let wrapper = SkipListIteratorWrapper { iter }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let cursor = PruningCursor::new(wrapper, timestamp)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let cursor = BoundsCursor::new(cursor, start_bound, end_bound)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(MemTableCursor { cursor }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reference_counter.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn dec(&self, t: T) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut counts = self.counts.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | match counts.entry(t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:571:13 [INFO] [stdout] | [INFO] [stdout] 563 | fn release_compaction(&self, compaction: Compaction) -> Result<(), Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 564 | let mut ongoing_list = self.ongoing.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | Err(Error::LogicError { [INFO] [stdout] | _____________^ [INFO] [stdout] 572 | | core: ErrorCore::default(), [INFO] [stdout] 573 | | context: "Provided a compaction that is not ongoing".to_string(), [INFO] [stdout] 574 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:589:13 [INFO] [stdout] | [INFO] [stdout] 579 | compaction: Compaction, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | let mut ongoing_list = self.ongoing.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | Err(Error::LogicError { [INFO] [stdout] | _____________^ [INFO] [stdout] 590 | | core: ErrorCore::default(), [INFO] [stdout] 591 | | context: "Provided a compaction that is not ongoing".to_string(), [INFO] [stdout] 592 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:1436:12 [INFO] [stdout] | [INFO] [stdout] 1418 | let mut cursors: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1436 | Ok((acc, MergingCursor::new(cursors)?, compaction_dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/recover.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 144 | let mut levels = vec![Level::default(); NUM_LEVELS]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let ongoing = Arc::new(Mutex::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(Version { [INFO] [stdout] | ________^ [INFO] [stdout] 162 | | options, [INFO] [stdout] 163 | | levels, [INFO] [stdout] 164 | | ongoing, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mani: Manifest = Manifest::open(options.mani.clone(), VERIFY_ROOT(&root))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | root, [INFO] [stdout] 57 | | mani, [INFO] [stdout] 58 | | options, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:228:31 [INFO] [stdout] | [INFO] [stdout] 228 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:384:12 [INFO] [stdout] | [INFO] [stdout] 376 | let file = match sst::file_manager::open_without_manager(&trash_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | Err(_) => match sst::file_manager::open_without_manager(sst_path) { [INFO] [stdout] 379 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let sst = Sst::from_file_handle(file)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Ok(sst.cursor()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsmtk` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 236 | fn from(what: std::io::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Error::SystemError { [INFO] [stdout] 238 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:247:19 [INFO] [stdout] | [INFO] [stdout] 245 | fn from(what: mani::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | Error::ManifestError { [INFO] [stdout] 247 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/mod.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut mani = Manifest::open(options.mani.clone(), MANI_ROOT(&root))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let tree = LsmTree::from_manifest(options.clone(), mani)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let imm = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let imm_trigger = 0; [INFO] [stdout] 111 | let mem = Arc::new(MemTable::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mem_path = LOG_FILE(&root, seq_no); [INFO] [stdout] 113 | let mem_log = Self::start_new_log(&mem_path, options.log.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let state = Mutex::new(KeyValueStoreState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | root, [INFO] [stdout] 132 | | tree, [INFO] [stdout] 133 | | options, [INFO] [stdout] ... | [INFO] [stdout] 138 | | cnd_memtable_rolled_over, [INFO] [stdout] 139 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/mod.rs:295:12 [INFO] [stdout] | [INFO] [stdout] 294 | let log = ConcurrentLogBuilder::new(options, log_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Ok(Arc::new(log)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvs/memtable.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 69 | let iter = self.skiplist.iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let wrapper = SkipListIteratorWrapper { iter }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let cursor = PruningCursor::new(wrapper, timestamp)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let cursor = BoundsCursor::new(cursor, start_bound, end_bound)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(MemTableCursor { cursor }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reference_counter.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn dec(&self, t: T) -> bool { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut counts = self.counts.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | match counts.entry(t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:571:13 [INFO] [stdout] | [INFO] [stdout] 563 | fn release_compaction(&self, compaction: Compaction) -> Result<(), Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 564 | let mut ongoing_list = self.ongoing.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | Err(Error::LogicError { [INFO] [stdout] | _____________^ [INFO] [stdout] 572 | | core: ErrorCore::default(), [INFO] [stdout] 573 | | context: "Provided a compaction that is not ongoing".to_string(), [INFO] [stdout] 574 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:589:13 [INFO] [stdout] | [INFO] [stdout] 579 | compaction: Compaction, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | let mut ongoing_list = self.ongoing.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | Err(Error::LogicError { [INFO] [stdout] | _____________^ [INFO] [stdout] 590 | | core: ErrorCore::default(), [INFO] [stdout] 591 | | context: "Provided a compaction that is not ongoing".to_string(), [INFO] [stdout] 592 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mod.rs:1436:12 [INFO] [stdout] | [INFO] [stdout] 1418 | let mut cursors: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1436 | Ok((acc, MergingCursor::new(cursors)?, compaction_dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/recover.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 144 | let mut levels = vec![Level::default(); NUM_LEVELS]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let ongoing = Arc::new(Mutex::default()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(Version { [INFO] [stdout] | ________^ [INFO] [stdout] 162 | | options, [INFO] [stdout] 163 | | levels, [INFO] [stdout] 164 | | ongoing, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mani: Manifest = Manifest::open(options.mani.clone(), VERIFY_ROOT(&root))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | root, [INFO] [stdout] 57 | | mani, [INFO] [stdout] 58 | | options, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:228:31 [INFO] [stdout] | [INFO] [stdout] 228 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/verifier.rs:384:12 [INFO] [stdout] | [INFO] [stdout] 376 | let file = match sst::file_manager::open_without_manager(&trash_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | Err(_) => match sst::file_manager::open_without_manager(sst_path) { [INFO] [stdout] 379 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let sst = Sst::from_file_handle(file)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Ok(sst.cursor()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsmtk` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "ae9be9c86412816e843c7ea054f7441259736a9fb13ca03581b740c15f49322d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae9be9c86412816e843c7ea054f7441259736a9fb13ca03581b740c15f49322d", kill_on_drop: false }` [INFO] [stdout] ae9be9c86412816e843c7ea054f7441259736a9fb13ca03581b740c15f49322d