[INFO] fetching crate lrlex 0.13.7... [INFO] checking lrlex-0.13.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lrlex 0.13.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lrlex 0.13.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lrlex 0.13.7 [INFO] finished tweaking crates.io crate lrlex 0.13.7 [INFO] tweaked toml for crates.io crate lrlex 0.13.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lrlex 0.13.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9a955fb23d7eef863050ade4ec0188c6427ce60ac9b3bb9e81ce2af338b3c63 [INFO] running `Command { std: "docker" "start" "-a" "c9a955fb23d7eef863050ade4ec0188c6427ce60ac9b3bb9e81ce2af338b3c63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9a955fb23d7eef863050ade4ec0188c6427ce60ac9b3bb9e81ce2af338b3c63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9a955fb23d7eef863050ade4ec0188c6427ce60ac9b3bb9e81ce2af338b3c63", kill_on_drop: false }` [INFO] [stdout] c9a955fb23d7eef863050ade4ec0188c6427ce60ac9b3bb9e81ce2af338b3c63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c4a24081c2eafc48b9dd078e41657bd865ed5ffb8ce42de49c2cee203378b31 [INFO] running `Command { std: "docker" "start" "-a" "1c4a24081c2eafc48b9dd078e41657bd865ed5ffb8ce42de49c2cee203378b31", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling num_threads v0.1.7 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling vergen v8.3.1 [INFO] [stderr] Compiling vob v3.0.3 [INFO] [stderr] Checking cactus v1.0.7 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling lrpar v0.13.7 [INFO] [stderr] Compiling lrlex v0.13.7 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking packedvec v1.2.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking sparsevec v0.2.0 [INFO] [stderr] Checking cfgrammar v0.13.7 [INFO] [stderr] Checking lrtable v0.13.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:219:12 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn lexer_in_src_dir

(mut self, srcp: P) -> Result> [INFO] [stdout] | -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | Ok(self.output_path(outp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:564:12 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn build(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let mut lexerdef: Box> = match self.lexerkind { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | let (missing_from_lexer, missing_from_parser) = match self.rule_ids_map { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let (x, y) = lexerdef.set_rule_ids(&owned_map); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | let mut f = File::create(outp)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 563 | f.write_all(outs.as_bytes())?; [INFO] [stdout] 564 | Ok(CTLexer { [INFO] [stdout] | ____________^ [INFO] [stdout] 565 | | missing_from_lexer, [INFO] [stdout] 566 | | missing_from_parser, [INFO] [stdout] 567 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:636:12 [INFO] [stdout] | [INFO] [stdout] 625 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 626 | inp: P, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 627 | outp: Q, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 635 | let cl = self.build()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 637 | | cl.missing_from_lexer().map(|x| x.to_owned()), [INFO] [stdout] 638 | | cl.missing_from_parser().map(|x| x.to_owned()), [INFO] [stdout] 639 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lexer.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 81 | tok_id: Option, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut re = RegexBuilder::new(&format!("\\A(?:{})", re_str)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let re = re.build()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Ok(Rule { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | tok_id, [INFO] [stdout] 120 | | name, [INFO] [stdout] 121 | | name_span, [INFO] [stdout] ... | [INFO] [stdout] 125 | | target_state, [INFO] [stdout] 126 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lrlex` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `line_of_offset` is never used [INFO] [stdout] --> src/lib/parser.rs:648:8 [INFO] [stdout] | [INFO] [stdout] 648 | fn line_of_offset(s: &str, off: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `expect_error_at_line` is never used [INFO] [stdout] --> src/lib/parser.rs:653:12 [INFO] [stdout] | [INFO] [stdout] 652 | trait ErrorsHelper { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 653 | fn expect_error_at_line(self, src: &str, kind: LexErrorKind, line: usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:219:12 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn lexer_in_src_dir

(mut self, srcp: P) -> Result> [INFO] [stdout] | -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | Ok(self.output_path(outp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:564:12 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn build(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let mut lexerdef: Box> = match self.lexerkind { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | let (missing_from_lexer, missing_from_parser) = match self.rule_ids_map { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let (x, y) = lexerdef.set_rule_ids(&owned_map); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | let mut f = File::create(outp)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 563 | f.write_all(outs.as_bytes())?; [INFO] [stdout] 564 | Ok(CTLexer { [INFO] [stdout] | ____________^ [INFO] [stdout] 565 | | missing_from_lexer, [INFO] [stdout] 566 | | missing_from_parser, [INFO] [stdout] 567 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/ctbuilder.rs:636:12 [INFO] [stdout] | [INFO] [stdout] 625 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 626 | inp: P, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 627 | outp: Q, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 635 | let cl = self.build()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 637 | | cl.missing_from_lexer().map(|x| x.to_owned()), [INFO] [stdout] 638 | | cl.missing_from_parser().map(|x| x.to_owned()), [INFO] [stdout] 639 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lexer.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 81 | tok_id: Option, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut re = RegexBuilder::new(&format!("\\A(?:{})", re_str)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let re = re.build()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Ok(Rule { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | tok_id, [INFO] [stdout] 120 | | name, [INFO] [stdout] 121 | | name_span, [INFO] [stdout] ... | [INFO] [stdout] 125 | | target_state, [INFO] [stdout] 126 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lrlex` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c4a24081c2eafc48b9dd078e41657bd865ed5ffb8ce42de49c2cee203378b31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c4a24081c2eafc48b9dd078e41657bd865ed5ffb8ce42de49c2cee203378b31", kill_on_drop: false }` [INFO] [stdout] 1c4a24081c2eafc48b9dd078e41657bd865ed5ffb8ce42de49c2cee203378b31