[INFO] fetching crate lp-modeler 0.5.0... [INFO] checking lp-modeler-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lp-modeler 0.5.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate lp-modeler 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lp-modeler 0.5.0 [INFO] finished tweaking crates.io crate lp-modeler 0.5.0 [INFO] tweaked toml for crates.io crate lp-modeler 0.5.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate lp-modeler 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2605b764b4f50f06d4cc79f77b5b8f28749378d39e0b2a2d09b8acf0a98f9284 [INFO] running `Command { std: "docker" "start" "-a" "2605b764b4f50f06d4cc79f77b5b8f28749378d39e0b2a2d09b8acf0a98f9284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2605b764b4f50f06d4cc79f77b5b8f28749378d39e0b2a2d09b8acf0a98f9284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2605b764b4f50f06d4cc79f77b5b8f28749378d39e0b2a2d09b8acf0a98f9284", kill_on_drop: false }` [INFO] [stdout] 2605b764b4f50f06d4cc79f77b5b8f28749378d39e0b2a2d09b8acf0a98f9284 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7cbab3e5254aac0854d17f9794129b0db377e7fcd0034175e7591174e2c3834 [INFO] running `Command { std: "docker" "start" "-a" "f7cbab3e5254aac0854d17f9794129b0db377e7fcd0034175e7591174e2c3834", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking unicode-xid v0.2.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking quote v1.0.9 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking lp-modeler v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `LpCompExpr` is never constructed [INFO] [stdout] --> src/dsl/variables.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | pub(crate) struct LpCompExpr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/variables.rs:1353:62 [INFO] [stdout] | [INFO] [stdout] 1353 | let mut results: Vec = expr.iter().map(|e| e.clone().into()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn le(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | LpConstraint( [INFO] [stdout] 140 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn le(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 146 | fn ge(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | LpConstraint( [INFO] [stdout] 148 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 146 | fn ge(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn equal(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | LpConstraint( [INFO] [stdout] 156 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn equal(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/solvers/mod.rs:105:42 [INFO] [stdout] | [INFO] [stdout] 105 | assert!( is_zero( f-(i as f32)), format!("Value {} cannot be interpreted as integer.", f) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 105 - assert!( is_zero( f-(i as f32)), format!("Value {} cannot be interpreted as integer.", f) ); [INFO] [stdout] 105 + assert!( is_zero( f-(i as f32)), "Value {} cannot be interpreted as integer.", f ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lp-modeler` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `LpCompExpr` is never constructed [INFO] [stdout] --> src/dsl/variables.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | pub(crate) struct LpCompExpr { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `EmptyExpr` is never constructed [INFO] [stdout] --> src/dsl/variables.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 169 | pub(crate) enum LpExprNode { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 174 | EmptyExpr, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LpExprNode` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/variables.rs:1353:62 [INFO] [stdout] | [INFO] [stdout] 1353 | let mut results: Vec = expr.iter().map(|e| e.clone().into()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn le(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | LpConstraint( [INFO] [stdout] 140 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn le(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 146 | fn ge(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | LpConstraint( [INFO] [stdout] 148 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 146 | fn ge(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn equal(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | LpConstraint( [INFO] [stdout] 156 | self.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dsl/operations.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn equal(&self, lhs_expr: T) -> LpConstraint { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | lhs_expr.clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/solvers/mod.rs:105:42 [INFO] [stdout] | [INFO] [stdout] 105 | assert!( is_zero( f-(i as f32)), format!("Value {} cannot be interpreted as integer.", f) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 105 - assert!( is_zero( f-(i as f32)), format!("Value {} cannot be interpreted as integer.", f) ); [INFO] [stdout] 105 + assert!( is_zero( f-(i as f32)), "Value {} cannot be interpreted as integer.", f ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lp-modeler` (lib) due to 8 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f7cbab3e5254aac0854d17f9794129b0db377e7fcd0034175e7591174e2c3834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7cbab3e5254aac0854d17f9794129b0db377e7fcd0034175e7591174e2c3834", kill_on_drop: false }` [INFO] [stdout] f7cbab3e5254aac0854d17f9794129b0db377e7fcd0034175e7591174e2c3834