[INFO] fetching crate longshot 0.1.8... [INFO] checking longshot-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate longshot 0.1.8 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate longshot 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate longshot 0.1.8 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate longshot 0.1.8 [INFO] tweaked toml for crates.io crate longshot 0.1.8 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate longshot 0.1.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f919234e44fe30e99cb5970a9f7240787cedbd710100b791002ea3019fd65ea0 [INFO] running `Command { std: "docker" "start" "-a" "f919234e44fe30e99cb5970a9f7240787cedbd710100b791002ea3019fd65ea0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f919234e44fe30e99cb5970a9f7240787cedbd710100b791002ea3019fd65ea0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f919234e44fe30e99cb5970a9f7240787cedbd710100b791002ea3019fd65ea0", kill_on_drop: false }` [INFO] [stdout] f919234e44fe30e99cb5970a9f7240787cedbd710100b791002ea3019fd65ea0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a921091232f4e0b1f76c21ef3208415acde2aa8e18be740aacd0a43d6c0fb08 [INFO] running `Command { std: "docker" "start" "-a" "9a921091232f4e0b1f76c21ef3208415acde2aa8e18be740aacd0a43d6c0fb08", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling winnow v0.5.34 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking anstream v0.6.7 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking clap_builder v4.4.16 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking ariadne v0.1.5 [INFO] [stderr] Checking tuples v1.15.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking embed_plist v1.2.2 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking const-decoder v0.3.0 [INFO] [stderr] Compiling toml_edit v0.21.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling proc-macro-crate v3.0.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking clap v4.4.16 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking stream-cancel v0.8.2 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking keepcalm v0.3.5 [INFO] [stderr] Checking bluez-generated v0.3.0 [INFO] [stderr] Checking dbus-tokio v0.7.6 [INFO] [stderr] Checking bluez-async v0.7.2 [INFO] [stderr] Checking btleplug v0.11.5 [INFO] [stderr] Checking longshot v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `tuples::TupleTransposeResult::transpose`: use transpose1 [INFO] [stdout] --> src/ecam/stdin_stream.rs:132:61 [INFO] [stdout] | [INFO] [stdout] 132 | let x: Result<_, EcamError> = join!(a, b, c).map(|x| x).transpose(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `tuples::TupleTransposeResult::transpose`: use transpose1 [INFO] [stdout] --> src/ecam/stdin_stream.rs:132:61 [INFO] [stdout] | [INFO] [stdout] 132 | let x: Result<_, EcamError> = join!(a, b, c).map(|x| x).transpose(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecam/ecam_subprocess.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 65 | mut child: tokio::process::Child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | alive: Arc>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let termination = stream! { [INFO] [stdout] | _______________________^ [INFO] [stdout] 103 | | let _ = child.wait().await; [INFO] [stdout] 104 | | *alive.lock().await = false; [INFO] [stdout] 105 | | yield EcamDriverOutput::Done [INFO] [stdout] 106 | | }; [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `stream` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecam/packet_receiver.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 15 | mut stream: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let (tx, rx) = tokio::sync::mpsc::channel(100); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | rx: SharedMut::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/packet.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn from_represenation(representation: T) -> EcamPacket { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | representation: Some(representation), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn collect_map_join(self, sep: &str, f: fn(X) -> String) -> String { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | self.map(f).collect::>().join(sep) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | fn collect_filter_map_join(self, sep: &str, f: fn(X) -> Option) -> String { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.filter_map(f).collect::>().join(sep) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecam/ecam_subprocess.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 65 | mut child: tokio::process::Child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | alive: Arc>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let termination = stream! { [INFO] [stdout] | _______________________^ [INFO] [stdout] 103 | | let _ = child.wait().await; [INFO] [stdout] 104 | | *alive.lock().await = false; [INFO] [stdout] 105 | | yield EcamDriverOutput::Done [INFO] [stdout] 106 | | }; [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `stream` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecam/packet_receiver.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 15 | mut stream: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let (tx, rx) = tokio::sync::mpsc::channel(100); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | rx: SharedMut::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/packet.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn from_represenation(representation: T) -> EcamPacket { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | representation: Some(representation), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn collect_map_join(self, sep: &str, f: fn(X) -> String) -> String { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | self.map(f).collect::>().join(sep) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | fn collect_filter_map_join(self, sep: &str, f: fn(X) -> Option) -> String { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.filter_map(f).collect::>().join(sep) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `longshot` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `longshot` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9a921091232f4e0b1f76c21ef3208415acde2aa8e18be740aacd0a43d6c0fb08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a921091232f4e0b1f76c21ef3208415acde2aa8e18be740aacd0a43d6c0fb08", kill_on_drop: false }` [INFO] [stdout] 9a921091232f4e0b1f76c21ef3208415acde2aa8e18be740aacd0a43d6c0fb08