[INFO] fetching crate logisheets_controller 0.6.0... [INFO] checking logisheets_controller-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logisheets_controller 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate logisheets_controller 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logisheets_controller 0.6.0 [INFO] finished tweaking crates.io crate logisheets_controller 0.6.0 [INFO] tweaked toml for crates.io crate logisheets_controller 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 137 packages to latest compatible versions [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding nalgebra v0.29.0 (latest: v0.33.0) [INFO] [stderr] Adding nalgebra-macros v0.1.0 (latest: v0.2.2) [INFO] [stderr] Adding quick-xml v0.28.2 (latest: v0.36.1) [INFO] [stderr] Adding quick-xml v0.29.0 (latest: v0.36.1) [INFO] [stderr] Adding simba v0.6.0 (latest: v0.9.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding statrs v0.16.1 (latest: v0.17.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding xmlserde v0.5.5 (latest: v0.9.1) [INFO] [stderr] Adding xmlserde_derives v0.5.5 (latest: v0.9.1) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6bfdbb579a899c59ccb96cf56a5ae9ad94d01aff6e2bcdddfb717c16aa08f35d [INFO] running `Command { std: "docker" "start" "-a" "6bfdbb579a899c59ccb96cf56a5ae9ad94d01aff6e2bcdddfb717c16aa08f35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6bfdbb579a899c59ccb96cf56a5ae9ad94d01aff6e2bcdddfb717c16aa08f35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bfdbb579a899c59ccb96cf56a5ae9ad94d01aff6e2bcdddfb717c16aa08f35d", kill_on_drop: false }` [INFO] [stdout] 6bfdbb579a899c59ccb96cf56a5ae9ad94d01aff6e2bcdddfb717c16aa08f35d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 78a46d34f5e1b8e1a5635d7c5e9f8bf08d3d569b6713a756e52cf4bb6543ed29 [INFO] running `Command { std: "docker" "start" "-a" "78a46d34f5e1b8e1a5635d7c5e9f8bf08d3d569b6713a756e52cf4bb6543ed29", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking gents v0.8.0 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking wildescape v0.1.0 [INFO] [stderr] Checking colorsys v0.6.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking simba v0.6.0 [INFO] [stderr] Compiling xmlserde_derives v0.5.5 [INFO] [stderr] Compiling logisheets_workbook_derives v0.4.0 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling gents_derives v0.8.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling uuid-macro-internal v1.10.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking nalgebra v0.29.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking logisheets_lexer v0.6.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking quick-xml v0.29.0 [INFO] [stderr] Checking quick-xml v0.28.2 [INFO] [stderr] Checking xmlserde v0.5.5 [INFO] [stderr] Checking logisheets_workbook v0.6.0 [INFO] [stderr] Checking logisheets_base v0.6.0 [INFO] [stderr] Checking logisheets_parser v0.6.0 [INFO] [stderr] Checking statrs v0.16.1 [INFO] [stderr] Checking logisheets_astchecker v0.6.0 [INFO] [stderr] Checking logisheets_controller v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `index_fetcher::IndexFetcher` [INFO] [stdout] --> src/connectors/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub use index_fetcher::IndexFetcher; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cache` [INFO] [stdout] --> src/navigator/mod.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | sheet_nav::{Cache, SheetNav}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `index_fetcher::IndexFetcher` [INFO] [stdout] --> src/connectors/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub use index_fetcher::IndexFetcher; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cache` [INFO] [stdout] --> src/navigator/mod.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | sheet_nav::{Cache, SheetNav}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/container/executor.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | let mut info = self.container.get_col_info_mut(sheet_id, col_id); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/container/executor.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut info = self.container.get_row_info_mut(sheet_id, row_id); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/navigator/mod.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(mut bp) = sheet_nav.data.blocks.get_mut(&block_id) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/calc_engine/calculator/funcs/mode.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | let mut insert = bmap.entry(s).or_insert((0, l)); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Range` is never constructed [INFO] [stdout] --> src/calc_engine/calculator/calc_vertex.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | pub struct Range { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Range` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `coup_days_bs` and `coup_days_nc` are never used [INFO] [stdout] --> src/calc_engine/calculator/math/day_count.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait DayCountTools { [INFO] [stdout] | ------------- associated functions in this trait [INFO] [stdout] 4 | fn coup_days(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] 5 | fn coup_days_bs(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 6 | fn coup_days_nc(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pcd` is never read [INFO] [stdout] --> src/calc_engine/calculator/math/day_count.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 385 | pub struct PriceYieldFactors { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 386 | pub n: u32, [INFO] [stdout] 387 | pub pcd: EasyDate, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_text` is never used [INFO] [stdout] --> src/calc_engine/connector.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait Connector: AsyncFuncCommitTrait + GetCurrAddrTrait + SetCurrCellTrait { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 14 | fn get_text(&self, tid: &TextId) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `names` is never read [INFO] [stdout] --> src/calc_engine/cycle.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct CycleCalculator<'a, C> [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub names: &'a HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ext_links`, `names_storage`, and `cells_stroage` are never read [INFO] [stdout] --> src/connectors/calc_connector.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct CalcConnector<'a> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub ext_links: &'a mut ExtBooksManager, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub names_storage: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | pub cells_stroage: HashMap<(SheetId, CellId), CalcValue>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `container` is never read [INFO] [stdout] --> src/connectors/formula_connector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct FormulaConnector<'a> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 28 | pub book_name: &'a str, [INFO] [stdout] 29 | pub container: &'a mut DataContainer, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `formula_manager` is never read [INFO] [stdout] --> src/connectors/name_fetcher.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct NameFetcher<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub formula_manager: &'a FormulaManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `external_count` and `formula_manager` are never read [INFO] [stdout] --> src/file_saver/mod.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct Saver<'a> { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 90 | pub part_count: u32, [INFO] [stdout] 91 | pub external_count: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub formula_manager: &'a FormulaManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/workbook.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | let controller = Controller::from_file(book_name, buf)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(Workbook { controller }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calc_order.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn calc_order(rdeps_fetcher: &F, dirty_nodes: HashSet) -> VecDeque> [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let mut entrance_time: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut low: HashMap = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut node_status: HashMap = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut scc_id: u32 = 0; [INFO] [stdout] 30 | let mut scc_map: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut time: u32 = 0; [INFO] [stdout] 32 | let orders = dirty_nodes.into_iter().map(|v| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | orders.fold(VecDeque::>::new(), |mut prev, c| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/and.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn calc(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | / args.into_iter() [INFO] [stdout] 11 | | .map(|arg| fetcher.get_calc_value(arg)) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/asyncs.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn calc(name: &str, args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let cid = fetcher.get_cell_id(sheet_id, curr_cell.row, curr_cell.col); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | CalcVertex::Value(CalcValue::Scalar(decode_result(res))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/asyncs.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | .map(|arg| fetcher.get_calc_value(arg).to_async_arg()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/row.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn calc_row(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | match args.into_iter().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/row.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn calc_column(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match args.into_iter().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/switch.rs:34:11 [INFO] [stdout] | [INFO] [stdout] 26 | mut iter: std::vec::IntoIter, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let condition_or_default = iter.next(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let value = iter.next(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match (condition_or_default, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/infix/intersect.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn intersect(lhs: CalcVertex, rhs: CalcVertex) -> CalcVertex { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/infix/range.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_range(lhs: CalcVertex, rhs: CalcVertex) -> CalcVertex { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectors/calc_connector.rs:233:41 [INFO] [stdout] | [INFO] [stdout] 233 | .map(|arg| Box::new(self.get_calc_value(*arg))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:57:50 [INFO] [stdout] | [INFO] [stdout] 57 | write(workbook).map_err(|e| Error::Serde(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:65:30 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn from(status: Status, book_name: String, settings: Settings) -> Self { [INFO] [stdout] | -------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | version_manager: VersionManager::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(load(res, name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/executor.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 56 | fn execute_payload(self, payload: EditPayload) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut result = self; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let sheet_pos_manager = result.execute_sheet_pos(&payload)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let old_navigator = result.status.navigator.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let nav_executor = result.execute_navigator(payload.clone())?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | let range_executor = result.execute_range(payload.clone())?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let cube_executor = result.execute_cube(payload.clone())?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let container_executor = result.execute_container(payload.clone())?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut dirty_ranges = range_executor.dirty_ranges; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut dirty_cubes = cube_executor.dirty_cubes; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let formula_executor = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Executor { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | status: Status { [INFO] [stdout] 88 | | navigator: result.status.navigator, [INFO] [stdout] 89 | | range_manager: result.status.range_manager, [INFO] [stdout] ... | [INFO] [stdout] 110 | | updated_cells: result.updated_cells, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cube_manager/executors/mod.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(manager: CubeManager) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | dirty_cubes: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cube_manager/executors/mod.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(manager: CubeManager) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | removed_cubes: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext_book_manager.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 110 | let mut sheets = Vector::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | data_set: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_saver/utils.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn to_vec(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | / self.inner [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] 53 | | .sorted_by_key(|(_, v)| *v) [INFO] [stdout] 54 | | .map(|(k, _)| k) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formula_manager/executors/input_formula.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 11 | executor: FormulaExecutor, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut new_formula_deps = HashSet::::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | mut graph, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | mut formulas, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | names, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(FormulaExecutor { [INFO] [stdout] | ________^ [INFO] [stdout] 67 | | manager: FormulaManager { [INFO] [stdout] 68 | | graph, [INFO] [stdout] 69 | | formulas, [INFO] [stdout] ... | [INFO] [stdout] 72 | | dirty_vertices: executor.dirty_vertices, [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:196:15 [INFO] [stdout] | [INFO] [stdout] 182 | fn insert_new_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let rows = sheet_nav.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let row_max = rows.len(); [INFO] [stdout] 188 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | data: sheet_nav.data.update_rows(new_rows), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:197:16 [INFO] [stdout] | [INFO] [stdout] 182 | fn insert_new_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let rows = sheet_nav.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let row_max = rows.len(); [INFO] [stdout] 188 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn insert_new_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let cols = sheet_nav.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let col_max = cols.len(); [INFO] [stdout] 208 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | data: sheet_nav.data.update_cols(new_cols), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 202 | fn insert_new_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let cols = sheet_nav.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let col_max = cols.len(); [INFO] [stdout] 208 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:250:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn delete_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 224 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | let rows = result.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let removed_cnt = std::cmp::min(rows.len() - idx, cnt as usize); [INFO] [stdout] 230 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | data: result.data.update_rows(new_rows).update_blocks(new_blocks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:251:16 [INFO] [stdout] | [INFO] [stdout] 222 | fn delete_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 224 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | let rows = result.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let removed_cnt = std::cmp::min(rows.len() - idx, cnt as usize); [INFO] [stdout] 230 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:284:15 [INFO] [stdout] | [INFO] [stdout] 256 | fn delete_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 258 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let cols = result.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let removed_cnt = std::cmp::min(cols.len() - idx, cnt as usize); [INFO] [stdout] 264 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | data: result.data.update_cols(new_cols).update_blocks(new_blocks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 256 | fn delete_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 258 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let cols = result.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let removed_cnt = std::cmp::min(cols.len() - idx, cnt as usize); [INFO] [stdout] 264 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&u32` instead of cloning the inner type [INFO] [stdout] --> src/navigator/id_manager.rs:55:62 [INFO] [stdout] | [INFO] [stdout] 55 | .any(|c| self.has_allocated.contains(&(*p.clone(), c.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&u32` instead of cloning the inner type [INFO] [stdout] --> src/navigator/id_manager.rs:78:73 [INFO] [stdout] | [INFO] [stdout] 78 | .any(|r| self.has_allocated.contains(&(r.clone(), *p.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_manager/executors/mod.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(manager: RangeManager) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | dirty_ranges: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_manager/executors/mod.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(manager: RangeManager) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | removed_ranges: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_manager/manager.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | let id_data = self.id_to_data.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | / id_data [INFO] [stdout] 64 | | .into_iter() [INFO] [stdout] 65 | | .filter(|(i, _)| *i >= self.init_id) [INFO] [stdout] 66 | | .sorted_by(|(a, _), (b, _)| Ord::cmp(a, b)) [INFO] [stdout] 67 | | .map(|(_, v)| v) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_manager/manager.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | let id_data = self.id_to_data.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | / id_data [INFO] [stdout] 74 | | .into_iter() [INFO] [stdout] 75 | | .filter(|(i, _)| *i >= self.init_id) [INFO] [stdout] 76 | | .sorted_by(|(a, _), (b, _)| Ord::cmp(a, b)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/mod.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 104 | let mut result: HashSet = HashSet::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Some(SheetDiff { data: result }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/container/executor.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | let mut info = self.container.get_col_info_mut(sheet_id, col_id); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/container/executor.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut info = self.container.get_row_info_mut(sheet_id, row_id); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logisheets_controller` (lib) due to 34 previous errors; 19 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/navigator/mod.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(mut bp) = sheet_nav.data.blocks.get_mut(&block_id) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Range` is never constructed [INFO] [stdout] --> src/calc_engine/calculator/calc_vertex.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | pub struct Range { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Range` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `coup_days_bs` and `coup_days_nc` are never used [INFO] [stdout] --> src/calc_engine/calculator/math/day_count.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait DayCountTools { [INFO] [stdout] | ------------- associated functions in this trait [INFO] [stdout] 4 | fn coup_days(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] 5 | fn coup_days_bs(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 6 | fn coup_days_nc(settlement: EasyDate, maturity: EasyDate, freq: u8) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pcd` is never read [INFO] [stdout] --> src/calc_engine/calculator/math/day_count.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 385 | pub struct PriceYieldFactors { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 386 | pub n: u32, [INFO] [stdout] 387 | pub pcd: EasyDate, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_text` is never used [INFO] [stdout] --> src/calc_engine/connector.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait Connector: AsyncFuncCommitTrait + GetCurrAddrTrait + SetCurrCellTrait { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 14 | fn get_text(&self, tid: &TextId) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `names` is never read [INFO] [stdout] --> src/calc_engine/cycle.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct CycleCalculator<'a, C> [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub names: &'a HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ext_links`, `names_storage`, and `cells_stroage` are never read [INFO] [stdout] --> src/connectors/calc_connector.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct CalcConnector<'a> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub ext_links: &'a mut ExtBooksManager, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub names_storage: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | pub cells_stroage: HashMap<(SheetId, CellId), CalcValue>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `container` is never read [INFO] [stdout] --> src/connectors/formula_connector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct FormulaConnector<'a> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 28 | pub book_name: &'a str, [INFO] [stdout] 29 | pub container: &'a mut DataContainer, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `formula_manager` is never read [INFO] [stdout] --> src/connectors/name_fetcher.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct NameFetcher<'a> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub formula_manager: &'a FormulaManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `external_count` and `formula_manager` are never read [INFO] [stdout] --> src/file_saver/mod.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct Saver<'a> { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 90 | pub part_count: u32, [INFO] [stdout] 91 | pub external_count: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub formula_manager: &'a FormulaManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/workbook.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | let controller = Controller::from_file(book_name, buf)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(Workbook { controller }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calc_order.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn calc_order(rdeps_fetcher: &F, dirty_nodes: HashSet) -> VecDeque> [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let mut entrance_time: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut low: HashMap = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut node_status: HashMap = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut scc_id: u32 = 0; [INFO] [stdout] 30 | let mut scc_map: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut time: u32 = 0; [INFO] [stdout] 32 | let orders = dirty_nodes.into_iter().map(|v| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | orders.fold(VecDeque::>::new(), |mut prev, c| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/and.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn calc(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | / args.into_iter() [INFO] [stdout] 11 | | .map(|arg| fetcher.get_calc_value(arg)) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/asyncs.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn calc(name: &str, args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let cid = fetcher.get_cell_id(sheet_id, curr_cell.row, curr_cell.col); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | CalcVertex::Value(CalcValue::Scalar(decode_result(res))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/asyncs.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | .map(|arg| fetcher.get_calc_value(arg).to_async_arg()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/row.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn calc_row(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | match args.into_iter().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/row.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn calc_column(args: Vec, fetcher: &mut C) -> CalcVertex [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match args.into_iter().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/funcs/switch.rs:34:11 [INFO] [stdout] | [INFO] [stdout] 26 | mut iter: std::vec::IntoIter, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let condition_or_default = iter.next(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let value = iter.next(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match (condition_or_default, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/infix/intersect.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn intersect(lhs: CalcVertex, rhs: CalcVertex) -> CalcVertex { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calc_engine/calculator/infix/range.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn get_range(lhs: CalcVertex, rhs: CalcVertex) -> CalcVertex { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectors/calc_connector.rs:233:41 [INFO] [stdout] | [INFO] [stdout] 233 | .map(|arg| Box::new(self.get_calc_value(*arg))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:57:50 [INFO] [stdout] | [INFO] [stdout] 57 | write(workbook).map_err(|e| Error::Serde(e.into())) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:65:30 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn from(status: Status, book_name: String, settings: Settings) -> Self { [INFO] [stdout] | -------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | version_manager: VersionManager::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/mod.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(load(res, name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller/executor.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 56 | fn execute_payload(self, payload: EditPayload) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut result = self; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let sheet_pos_manager = result.execute_sheet_pos(&payload)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let old_navigator = result.status.navigator.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let nav_executor = result.execute_navigator(payload.clone())?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | let range_executor = result.execute_range(payload.clone())?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let cube_executor = result.execute_cube(payload.clone())?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let container_executor = result.execute_container(payload.clone())?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut dirty_ranges = range_executor.dirty_ranges; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let mut dirty_cubes = cube_executor.dirty_cubes; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let formula_executor = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Executor { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | status: Status { [INFO] [stdout] 88 | | navigator: result.status.navigator, [INFO] [stdout] 89 | | range_manager: result.status.range_manager, [INFO] [stdout] ... | [INFO] [stdout] 110 | | updated_cells: result.updated_cells, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cube_manager/executors/mod.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(manager: CubeManager) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | dirty_cubes: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cube_manager/executors/mod.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(manager: CubeManager) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | removed_cubes: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext_book_manager.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 110 | let mut sheets = Vector::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | data_set: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_saver/utils.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn to_vec(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | / self.inner [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] 53 | | .sorted_by_key(|(_, v)| *v) [INFO] [stdout] 54 | | .map(|(k, _)| k) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formula_manager/executors/input_formula.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 11 | executor: FormulaExecutor, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut new_formula_deps = HashSet::::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | mut graph, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | mut formulas, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | names, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(FormulaExecutor { [INFO] [stdout] | ________^ [INFO] [stdout] 67 | | manager: FormulaManager { [INFO] [stdout] 68 | | graph, [INFO] [stdout] 69 | | formulas, [INFO] [stdout] ... | [INFO] [stdout] 72 | | dirty_vertices: executor.dirty_vertices, [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:196:15 [INFO] [stdout] | [INFO] [stdout] 182 | fn insert_new_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let rows = sheet_nav.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let row_max = rows.len(); [INFO] [stdout] 188 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | data: sheet_nav.data.update_rows(new_rows), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:197:16 [INFO] [stdout] | [INFO] [stdout] 182 | fn insert_new_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let rows = sheet_nav.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let row_max = rows.len(); [INFO] [stdout] 188 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn insert_new_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let cols = sheet_nav.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let col_max = cols.len(); [INFO] [stdout] 208 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | data: sheet_nav.data.update_cols(new_cols), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 202 | fn insert_new_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let mut new_id_manager = sheet_nav.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let cols = sheet_nav.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let col_max = cols.len(); [INFO] [stdout] 208 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:250:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn delete_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 224 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | let rows = result.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let removed_cnt = std::cmp::min(rows.len() - idx, cnt as usize); [INFO] [stdout] 230 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | data: result.data.update_rows(new_rows).update_blocks(new_blocks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:251:16 [INFO] [stdout] | [INFO] [stdout] 222 | fn delete_rows(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 224 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let new_ids = new_id_manager.get_row_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let new_rows = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | let rows = result.data.rows.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let removed_cnt = std::cmp::min(rows.len() - idx, cnt as usize); [INFO] [stdout] 230 | let (mut left, right) = rows.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:284:15 [INFO] [stdout] | [INFO] [stdout] 256 | fn delete_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 258 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let cols = result.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let removed_cnt = std::cmp::min(cols.len() - idx, cnt as usize); [INFO] [stdout] 264 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | data: result.data.update_cols(new_cols).update_blocks(new_blocks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigator/executor.rs:285:16 [INFO] [stdout] | [INFO] [stdout] 256 | fn delete_cols(sheet_nav: SheetNav, idx: usize, cnt: u32) -> SheetNav { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let sheet_id = sheet_nav.sheet_id; [INFO] [stdout] 258 | let result = sheet_nav; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let mut new_id_manager = result.id_manager.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let new_ids = new_id_manager.get_col_ids(cnt); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let new_cols = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let cols = result.data.cols.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let removed_cnt = std::cmp::min(cols.len() - idx, cnt as usize); [INFO] [stdout] 264 | let (mut left, right) = cols.split_at(idx); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let new_blocks = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let mut old_blocks = result.data.blocks.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&u32` instead of cloning the inner type [INFO] [stdout] --> src/navigator/id_manager.rs:55:62 [INFO] [stdout] | [INFO] [stdout] 55 | .any(|c| self.has_allocated.contains(&(*p.clone(), c.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&u32` instead of cloning the inner type [INFO] [stdout] --> src/navigator/id_manager.rs:78:73 [INFO] [stdout] | [INFO] [stdout] 78 | .any(|r| self.has_allocated.contains(&(r.clone(), *p.clone()))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_manager/executors/mod.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(manager: RangeManager) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | dirty_ranges: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_manager/executors/mod.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(manager: RangeManager) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | removed_ranges: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_manager/manager.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | let id_data = self.id_to_data.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | / id_data [INFO] [stdout] 64 | | .into_iter() [INFO] [stdout] 65 | | .filter(|(i, _)| *i >= self.init_id) [INFO] [stdout] 66 | | .sorted_by(|(a, _), (b, _)| Ord::cmp(a, b)) [INFO] [stdout] 67 | | .map(|(_, v)| v) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_manager/manager.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | let id_data = self.id_to_data.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | / id_data [INFO] [stdout] 74 | | .into_iter() [INFO] [stdout] 75 | | .filter(|(i, _)| *i >= self.init_id) [INFO] [stdout] 76 | | .sorted_by(|(a, _), (b, _)| Ord::cmp(a, b)) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version_manager/mod.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 104 | let mut result: HashSet = HashSet::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Some(SheetDiff { data: result }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logisheets_controller` (lib test) due to 34 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "78a46d34f5e1b8e1a5635d7c5e9f8bf08d3d569b6713a756e52cf4bb6543ed29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78a46d34f5e1b8e1a5635d7c5e9f8bf08d3d569b6713a756e52cf4bb6543ed29", kill_on_drop: false }` [INFO] [stdout] 78a46d34f5e1b8e1a5635d7c5e9f8bf08d3d569b6713a756e52cf4bb6543ed29