[INFO] fetching crate logimesh 0.1.9... [INFO] checking logimesh-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logimesh 0.1.9 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate logimesh 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logimesh 0.1.9 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate logimesh 0.1.9 [INFO] tweaked toml for crates.io crate logimesh 0.1.9 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate logimesh 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b98a0af359a10e7d09202b8bb93b0e73359422829e00369a69790d419c82a1c5 [INFO] running `Command { std: "docker" "start" "-a" "b98a0af359a10e7d09202b8bb93b0e73359422829e00369a69790d419c82a1c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b98a0af359a10e7d09202b8bb93b0e73359422829e00369a69790d419c82a1c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b98a0af359a10e7d09202b8bb93b0e73359422829e00369a69790d419c82a1c5", kill_on_drop: false }` [INFO] [stdout] b98a0af359a10e7d09202b8bb93b0e73359422829e00369a69790d419c82a1c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 620ef554f7de85bcddf60c7b7e84b6843764e92f130d76c3a7c5e6b03118ec30 [INFO] running `Command { std: "docker" "start" "-a" "620ef554f7de85bcddf60c7b7e84b6843764e92f130d76c3a7c5e6b03118ec30", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking flate2 v1.0.32 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.16.0 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling tarpc-plugins v0.13.1 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.1 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Compiling logimesh-macro v0.1.9 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Compiling enum-ordinalize v4.3.0 [INFO] [stderr] Compiling educe v0.5.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking opentelemetry v0.24.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking futures-test v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking prost v0.13.1 [INFO] [stderr] Checking faststr v0.2.22 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Checking tokio-serde v0.9.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking axum-core v0.3.4 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking metainfo v0.7.12 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking opentelemetry_sdk v0.24.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tracing-opentelemetry v0.25.0 [INFO] [stderr] Checking tarpc-copy v0.34.0-copy.f81ddd6 [INFO] [stderr] Checking logimesh v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/balance/random.rs:103:43 [INFO] [stdout] | [INFO] [stdout] 102 | fn start_balance(&self, channels: Vec>) { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.channels.store(Box::into_raw(Box::new(Arc::new(WeightedChannels::from(channels)))), Ordering::Release) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/balance/random.rs:164:71 [INFO] [stdout] | [INFO] [stdout] 164 | let sum_of_weights = channels.iter().fold(0, |lhs, rhs| lhs + rhs.config().instance.weight as isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/channel.rs:212:23 [INFO] [stdout] | [INFO] [stdout] 206 | pub(crate) fn clone_update_instance(&self, instance: Arc) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let mut inner = InnerRpcChannel { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Self { inner: Arc::new(inner) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/discover/fixed.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 33 | let instances = address_list [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | instance_cluster: InstanceCluster::Rpc(instances), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/discover/fixed.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn from_address_str(address_list: Vec>) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(Self::from_address(list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/lrcall/lrcall.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(component: Component, discover: D, load_balance: LB) -> Self { [INFO] [stdout] | ----------------------- ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | discover: Arc::new(discover), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/lrcall/lrcall.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(component: Component, discover: D, load_balance: LB) -> Self { [INFO] [stdout] | ----------------------- ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | load_balance: Arc::new(load_balance), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/lrcall/lrcall.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(component: Component, discover: D, load_balance: LB) -> Self { [INFO] [stdout] | ----------------------- ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | retry_fn: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(service_name: impl Into) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Self { [INFO] [stdout] 47 | service_name: service_name.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(service_name: impl Into) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | tags: FastStrMap::with_capacity(DEFAULT_MAP_CAPACITY), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/probe.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 35 | let s = Socket::new(Domain::IPV6, Type::STREAM, Some(Protocol::TCP)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let s = match s { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | s.bind(&addr.into()).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/probe.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 47 | let s = Socket::new(Domain::IPV6, Type::STREAM, Some(Protocol::TCP)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let s = match s { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | !s.only_v6().unwrap_or(true) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logimesh` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "620ef554f7de85bcddf60c7b7e84b6843764e92f130d76c3a7c5e6b03118ec30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "620ef554f7de85bcddf60c7b7e84b6843764e92f130d76c3a7c5e6b03118ec30", kill_on_drop: false }` [INFO] [stdout] 620ef554f7de85bcddf60c7b7e84b6843764e92f130d76c3a7c5e6b03118ec30