[INFO] fetching crate logiclib 0.2.3... [INFO] checking logiclib-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logiclib 0.2.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate logiclib 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logiclib 0.2.3 [INFO] finished tweaking crates.io crate logiclib 0.2.3 [INFO] tweaked toml for crates.io crate logiclib 0.2.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 81 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding compact_str v0.6.1 (latest: v0.8.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding glam v0.20.5 (latest: v0.29.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding libertyparse v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding ulib v0.2.1 (latest: v0.3.3) [INFO] [stderr] Adding vek v0.15.10 (latest: v0.17.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 835c129e6ffe249919305b4469da5c54644cb84dd954ce529ee10ebd23bb4652 [INFO] running `Command { std: "docker" "start" "-a" "835c129e6ffe249919305b4469da5c54644cb84dd954ce529ee10ebd23bb4652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "835c129e6ffe249919305b4469da5c54644cb84dd954ce529ee10ebd23bb4652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "835c129e6ffe249919305b4469da5c54644cb84dd954ce529ee10ebd23bb4652", kill_on_drop: false }` [INFO] [stdout] 835c129e6ffe249919305b4469da5c54644cb84dd954ce529ee10ebd23bb4652 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4202c4aae60166b8db3beee54f1e270340a39f7e6432353c13fbbf0ca4f0d10c [INFO] running `Command { std: "docker" "start" "-a" "4202c4aae60166b8db3beee54f1e270340a39f7e6432353c13fbbf0ca4f0d10c", kill_on_drop: false }` [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking compact_str v0.6.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling zeroable_derive v0.2.0 [INFO] [stderr] Checking zeroable v0.2.0 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Checking clilog v0.2.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling readonly v0.2.12 [INFO] [stderr] Checking ulib v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking libertyparse v0.2.2 [INFO] [stderr] Checking logiclib v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 178 | row: impl IntoIterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | row.into_iter().copied().map(move |r| match r { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 15 | let cell_refs: IndexMap<&CompactString, &Cell> = liberty.libs.iter() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let mut logic_cells = cell_refs.into_iter().map(|(name, cell)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut truthtable = UVec::new_zeroed(truthtable_size, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | logic_cells: logic_cells.into_iter() [INFO] [stdout] | __________________________^ [INFO] [stdout] 46 | | .map(|(name, (_, lc, _))| (name, lc)).collect(), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | let (logic_cell, seq) = LogicCell::build_pin_sizes(cell); [INFO] [stdout] | ---------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | (name.clone(), (cell, logic_cell, seq)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:21:28 [INFO] [stdout] | [INFO] [stdout] 20 | let (logic_cell, seq) = LogicCell::build_pin_sizes(cell); [INFO] [stdout] | ---------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | (name.clone(), (cell, logic_cell, seq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:67:10 [INFO] [stdout] | [INFO] [stdout] 57 | let inputs = cell.pins.iter().filter_map(|(n, p)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let seq = match &cell.sequential_def { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | (LogicCell { [INFO] [stdout] | __________^ [INFO] [stdout] 68 | | output_pins: cell.pins.iter().filter_map(|(n, p)| { [INFO] [stdout] 69 | | match p.direction { [INFO] [stdout] 70 | | PinDirection::I => None, [INFO] [stdout] ... | [INFO] [stdout] 81 | | }).collect() [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 117 | let mut related_inputs = IndexMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | Ok(LogicOutputPin { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | related_inputs, [INFO] [stdout] 153 | | num_internals: num_internals.try_into().unwrap(), [INFO] [stdout] 154 | | table_size, [INFO] [stdout] 155 | | table_start: usize::MAX [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 178 | row: impl IntoIterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | row.into_iter().copied().map(move |r| match r { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logiclib` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 15 | let cell_refs: IndexMap<&CompactString, &Cell> = liberty.libs.iter() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let mut logic_cells = cell_refs.into_iter().map(|(name, cell)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut truthtable = UVec::new_zeroed(truthtable_size, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | logic_cells: logic_cells.into_iter() [INFO] [stdout] | __________________________^ [INFO] [stdout] 46 | | .map(|(name, (_, lc, _))| (name, lc)).collect(), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | let (logic_cell, seq) = LogicCell::build_pin_sizes(cell); [INFO] [stdout] | ---------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | (name.clone(), (cell, logic_cell, seq)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:21:28 [INFO] [stdout] | [INFO] [stdout] 20 | let (logic_cell, seq) = LogicCell::build_pin_sizes(cell); [INFO] [stdout] | ---------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | (name.clone(), (cell, logic_cell, seq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:67:10 [INFO] [stdout] | [INFO] [stdout] 57 | let inputs = cell.pins.iter().filter_map(|(n, p)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let seq = match &cell.sequential_def { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | (LogicCell { [INFO] [stdout] | __________^ [INFO] [stdout] 68 | | output_pins: cell.pins.iter().filter_map(|(n, p)| { [INFO] [stdout] 69 | | match p.direction { [INFO] [stdout] 70 | | PinDirection::I => None, [INFO] [stdout] ... | [INFO] [stdout] 81 | | }).collect() [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 117 | let mut related_inputs = IndexMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | Ok(LogicOutputPin { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | related_inputs, [INFO] [stdout] 153 | | num_internals: num_internals.try_into().unwrap(), [INFO] [stdout] 154 | | table_size, [INFO] [stdout] 155 | | table_start: usize::MAX [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logiclib` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "4202c4aae60166b8db3beee54f1e270340a39f7e6432353c13fbbf0ca4f0d10c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4202c4aae60166b8db3beee54f1e270340a39f7e6432353c13fbbf0ca4f0d10c", kill_on_drop: false }` [INFO] [stdout] 4202c4aae60166b8db3beee54f1e270340a39f7e6432353c13fbbf0ca4f0d10c