[INFO] fetching crate logic_based_learning_paths 0.0.0... [INFO] checking logic_based_learning_paths-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logic_based_learning_paths 0.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate logic_based_learning_paths 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logic_based_learning_paths 0.0.0 [INFO] finished tweaking crates.io crate logic_based_learning_paths 0.0.0 [INFO] tweaked toml for crates.io crate logic_based_learning_paths 0.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63d36515c8ee3c10b148a89e2669e4405017ed7e3927eb4158f7493ad1034abb [INFO] running `Command { std: "docker" "start" "-a" "63d36515c8ee3c10b148a89e2669e4405017ed7e3927eb4158f7493ad1034abb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63d36515c8ee3c10b148a89e2669e4405017ed7e3927eb4158f7493ad1034abb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63d36515c8ee3c10b148a89e2669e4405017ed7e3927eb4158f7493ad1034abb", kill_on_drop: false }` [INFO] [stdout] 63d36515c8ee3c10b148a89e2669e4405017ed7e3927eb4158f7493ad1034abb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52170252f224307aea5f6198b8894eb3ce622ee5c35289654f2de431ee9770a2 [INFO] running `Command { std: "docker" "start" "-a" "52170252f224307aea5f6198b8894eb3ce622ee5c35289654f2de431ee9770a2", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking logic_based_learning_paths v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 46 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut extension_fields = HashMap::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Node { [INFO] [stdout] | ____________________^ [INFO] [stdout] 85 | | id, [INFO] [stdout] 86 | | title, [INFO] [stdout] 87 | | extension_fields, [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:252:20 [INFO] [stdout] | [INFO] [stdout] 225 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut parameters = HashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | Ok(PluginForSerialization { path, parameters }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn build(self, folder_name: String) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | // this gives a vector of results [INFO] [stdout] 262 | let nodes: Vec<_> = self.nodes.iter().map(|n| n.build(&folder_name)).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | // turn it into a result for a vector [INFO] [stdout] 264 | let nodes: Result, _> = nodes.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | println!("about to create new ClusterForSerialization"); [INFO] [stdout] 266 | let node_plugins = load_node_processing_plugins( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | let node_plugins = node_plugins.map_err(|e| anyhow::format_err!(e))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | println!("Outcome 2: {:#?}", node_plugins); [INFO] [stdout] 279 | let node_plugins = Arc::new(node_plugins); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | println!("Done loading node plugins"); [INFO] [stdout] 281 | Ok(domain::Cluster { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | namespace_prefix: folder_name.clone(), [INFO] [stdout] 283 | | nodes: nodes?, [INFO] [stdout] 284 | | edges: self [INFO] [stdout] ... | [INFO] [stdout] 334 | | ), [INFO] [stdout] 335 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logic_based_learning_paths` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 46 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut extension_fields = HashMap::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Node { [INFO] [stdout] | ____________________^ [INFO] [stdout] 85 | | id, [INFO] [stdout] 86 | | title, [INFO] [stdout] 87 | | extension_fields, [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:252:20 [INFO] [stdout] | [INFO] [stdout] 225 | fn visit_map(self, mut map: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut parameters = HashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | Ok(PluginForSerialization { path, parameters }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialization.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn build(self, folder_name: String) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | // this gives a vector of results [INFO] [stdout] 262 | let nodes: Vec<_> = self.nodes.iter().map(|n| n.build(&folder_name)).collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | // turn it into a result for a vector [INFO] [stdout] 264 | let nodes: Result, _> = nodes.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | println!("about to create new ClusterForSerialization"); [INFO] [stdout] 266 | let node_plugins = load_node_processing_plugins( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | let node_plugins = node_plugins.map_err(|e| anyhow::format_err!(e))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | println!("Outcome 2: {:#?}", node_plugins); [INFO] [stdout] 279 | let node_plugins = Arc::new(node_plugins); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | println!("Done loading node plugins"); [INFO] [stdout] 281 | Ok(domain::Cluster { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | namespace_prefix: folder_name.clone(), [INFO] [stdout] 283 | | nodes: nodes?, [INFO] [stdout] 284 | | edges: self [INFO] [stdout] ... | [INFO] [stdout] 334 | | ), [INFO] [stdout] 335 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logic_based_learning_paths` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "52170252f224307aea5f6198b8894eb3ce622ee5c35289654f2de431ee9770a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52170252f224307aea5f6198b8894eb3ce622ee5c35289654f2de431ee9770a2", kill_on_drop: false }` [INFO] [stdout] 52170252f224307aea5f6198b8894eb3ce622ee5c35289654f2de431ee9770a2