[INFO] fetching crate logic-rs 0.1.1... [INFO] checking logic-rs-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logic-rs 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate logic-rs 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logic-rs 0.1.1 [INFO] finished tweaking crates.io crate logic-rs 0.1.1 [INFO] tweaked toml for crates.io crate logic-rs 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding bstr v0.2.17 (latest: v1.10.0) [INFO] [stderr] Adding csv v1.1.6 (latest: v1.3.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding ordered-float v2.8.0 (latest: v4.2.2) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e276ea2b114f383123fb9f85eb74cdbdd323e9fd865fafec17211fabcd9f0b46 [INFO] running `Command { std: "docker" "start" "-a" "e276ea2b114f383123fb9f85eb74cdbdd323e9fd865fafec17211fabcd9f0b46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e276ea2b114f383123fb9f85eb74cdbdd323e9fd865fafec17211fabcd9f0b46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e276ea2b114f383123fb9f85eb74cdbdd323e9fd865fafec17211fabcd9f0b46", kill_on_drop: false }` [INFO] [stdout] e276ea2b114f383123fb9f85eb74cdbdd323e9fd865fafec17211fabcd9f0b46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59dda4f7dda07d934e1c7c703a03a83fbfd0d3a255ea077b036329c5ff3cf2b3 [INFO] running `Command { std: "docker" "start" "-a" "59dda4f7dda07d934e1c7c703a03a83fbfd0d3a255ea077b036329c5ff3cf2b3", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking ordered-float v2.8.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking logic-rs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `trace` [INFO] [stdout] --> src/operators/until.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 34 | fn satisfied_by(&self, trace: &Trace) -> Result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_trace` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `trace` [INFO] [stdout] --> src/operators/until.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | fn distance(&self, trace: &Trace) -> Result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_trace` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Freeze` is never constructed [INFO] [stdout] --> src/operators/freeze.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Freeze

{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/operators/freeze.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl

Freeze

{ [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 7 | pub fn new(name: &str, phi: P) -> Freeze

{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `phi`, `rho`, and `bounds` are never read [INFO] [stdout] --> src/operators/until.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Until { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 8 | phi: P, [INFO] [stdout] | ^^^ [INFO] [stdout] 9 | rho: R, [INFO] [stdout] | ^^^ [INFO] [stdout] 10 | bounds: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `new_bounded` are never used [INFO] [stdout] --> src/operators/until.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Until { [INFO] [stdout] | ---------------------- associated functions in this implementation [INFO] [stdout] 14 | pub fn new(phi: P, rho: R) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | pub fn new_bounded>(phi: P, rho: R, bounds: B) -> Self { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 81 | let later_states = self.timed_states.split_off(&split_key); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Some(Trace { [INFO] [stdout] | ______________^ [INFO] [stdout] 84 | | timed_states: later_states, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:125:50 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|(time, state)| (time - offset, state.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:136:68 [INFO] [stdout] | [INFO] [stdout] 136 | .map(|(time, state)| (NotNan::try_from(time).unwrap(), Rc::new(state))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operators/implies.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | self.consequent.satisfied_by(value).map_err(BinaryError::Right) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operators/next.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | let future_trace = second_time.and_then(|time| trace.clone().split_at(time)); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operators/next.rs:51:56 [INFO] [stdout] | [INFO] [stdout] 51 | let future_trace = second_time.and_then(|time| trace.clone().split_at(time)); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logic-rs` (lib) due to 7 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "59dda4f7dda07d934e1c7c703a03a83fbfd0d3a255ea077b036329c5ff3cf2b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59dda4f7dda07d934e1c7c703a03a83fbfd0d3a255ea077b036329c5ff3cf2b3", kill_on_drop: false }` [INFO] [stdout] 59dda4f7dda07d934e1c7c703a03a83fbfd0d3a255ea077b036329c5ff3cf2b3