[INFO] fetching crate loghawk 0.1.1... [INFO] checking loghawk-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate loghawk 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate loghawk 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate loghawk 0.1.1 [INFO] finished tweaking crates.io crate loghawk 0.1.1 [INFO] tweaked toml for crates.io crate loghawk 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate loghawk 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efe5840a4f2587cad2ed2a1de810346dabf8bbba988b050d693463a60ccaf89a [INFO] running `Command { std: "docker" "start" "-a" "efe5840a4f2587cad2ed2a1de810346dabf8bbba988b050d693463a60ccaf89a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efe5840a4f2587cad2ed2a1de810346dabf8bbba988b050d693463a60ccaf89a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efe5840a4f2587cad2ed2a1de810346dabf8bbba988b050d693463a60ccaf89a", kill_on_drop: false }` [INFO] [stdout] efe5840a4f2587cad2ed2a1de810346dabf8bbba988b050d693463a60ccaf89a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 341d11aa73ea0ea1d07e4d98342fa0a8bb2adf6c9be545f3c79ce6c75f3c49e0 [INFO] running `Command { std: "docker" "start" "-a" "341d11aa73ea0ea1d07e4d98342fa0a8bb2adf6c9be545f3c79ce6c75f3c49e0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking clio v0.3.5 [INFO] [stderr] Checking loghawk v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(cli: Cli) -> anyhow::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let data: Box = match cli.file_format() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | running: true, [INFO] [stdout] 43 | | cli, [INFO] [stdout] 44 | | data, [INFO] [stdout] 45 | | viewstate, [INFO] [stdout] 46 | | page_size: 1, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csv_data.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|c| usize::try_from(*c.width()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csv_data.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|c| usize::try_from(*c.width()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | wrap_iterator!(IndexRows, ListItem<'_>); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | wrap_iterator!(DataRows, Row<'_>); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 128 | wrap_iterator!(DataWidths, usize); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|c| usize::try_from(*c.width()).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loghawk` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(cli: Cli) -> anyhow::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let data: Box = match cli.file_format() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | running: true, [INFO] [stdout] 43 | | cli, [INFO] [stdout] 44 | | data, [INFO] [stdout] 45 | | viewstate, [INFO] [stdout] 46 | | page_size: 1, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csv_data.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|c| usize::try_from(*c.width()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csv_data.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|c| usize::try_from(*c.width()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | wrap_iterator!(IndexRows, ListItem<'_>); [INFO] [stdout] | --------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | wrap_iterator!(DataRows, Row<'_>); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn from(value: I) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 128 | wrap_iterator!(DataWidths, usize); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `wrap_iterator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_data.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|c| usize::try_from(*c.width()).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loghawk` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "341d11aa73ea0ea1d07e4d98342fa0a8bb2adf6c9be545f3c79ce6c75f3c49e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "341d11aa73ea0ea1d07e4d98342fa0a8bb2adf6c9be545f3c79ce6c75f3c49e0", kill_on_drop: false }` [INFO] [stdout] 341d11aa73ea0ea1d07e4d98342fa0a8bb2adf6c9be545f3c79ce6c75f3c49e0