[INFO] fetching crate loggestd 0.6.3... [INFO] checking loggestd-0.6.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate loggestd 0.6.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate loggestd 0.6.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate loggestd 0.6.3 [INFO] finished tweaking crates.io crate loggestd 0.6.3 [INFO] tweaked toml for crates.io crate loggestd 0.6.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate loggestd 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbf657e242ca30800df70a9c7a96a11a595e3c4f7ceb8584983d1cae633d35c1 [INFO] running `Command { std: "docker" "start" "-a" "cbf657e242ca30800df70a9c7a96a11a595e3c4f7ceb8584983d1cae633d35c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbf657e242ca30800df70a9c7a96a11a595e3c4f7ceb8584983d1cae633d35c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf657e242ca30800df70a9c7a96a11a595e3c4f7ceb8584983d1cae633d35c1", kill_on_drop: false }` [INFO] [stdout] cbf657e242ca30800df70a9c7a96a11a595e3c4f7ceb8584983d1cae633d35c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e36062a6be9c8341dec460a10e024018e1d20ad6ad162bbaa14692363367ea2 [INFO] running `Command { std: "docker" "start" "-a" "6e36062a6be9c8341dec460a10e024018e1d20ad6ad162bbaa14692363367ea2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking tokio-executor v0.1.9 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling jobserver v0.1.17 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Checking tokio-threadpool v0.1.17 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Compiling nix v0.16.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking tokio-reactor v0.1.11 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking signal-hook v0.1.12 [INFO] [stderr] Checking tokio-timer v0.2.12 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Compiling zstd-sys v1.4.15+zstd.1.4.4 [INFO] [stderr] Checking tokio-udp v0.1.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.3.5 [INFO] [stderr] Checking structopt v0.3.5 [INFO] [stderr] Checking zstd-safe v2.0.3+zstd.1.4.4 [INFO] [stderr] Checking zstd v0.5.1+zstd.1.4.4 [INFO] [stderr] Checking loggestd v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_file.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | let file = File::create(&filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(LogFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | file, [INFO] [stdout] 37 | | base_filename, [INFO] [stdout] 38 | | consumed_data: 0, [INFO] [stdout] 39 | | index, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(connection: C, opt: Arc) -> Self { [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (r, _) = connection.split(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = FramedRead::new(r, LoggestdCodec::default()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | state: State::Initiated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:133:61 [INFO] [stdout] | [INFO] [stdout] 133 | let a_mtime = a.1.as_ref().and_then(|m| m.modified().ok()).unwrap_or(now); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:134:61 [INFO] [stdout] | [INFO] [stdout] 134 | let b_mtime = b.1.as_ref().and_then(|m| m.modified().ok()).unwrap_or(now); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:142:62 [INFO] [stdout] | [INFO] [stdout] 142 | .filter_map(|(entry, metadata)| metadata.map(|m| (entry, m))) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loggestd` (bin "loggestd") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_file.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | let file = File::create(&filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(LogFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | file, [INFO] [stdout] 37 | | base_filename, [INFO] [stdout] 38 | | consumed_data: 0, [INFO] [stdout] 39 | | index, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(connection: C, opt: Arc) -> Self { [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (r, _) = connection.split(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let reader = FramedRead::new(r, LoggestdCodec::default()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | state: State::Initiated, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:133:61 [INFO] [stdout] | [INFO] [stdout] 133 | let a_mtime = a.1.as_ref().and_then(|m| m.modified().ok()).unwrap_or(now); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:134:61 [INFO] [stdout] | [INFO] [stdout] 134 | let b_mtime = b.1.as_ref().and_then(|m| m.modified().ok()).unwrap_or(now); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/usage_monitor.rs:142:62 [INFO] [stdout] | [INFO] [stdout] 142 | .filter_map(|(entry, metadata)| metadata.map(|m| (entry, m))) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loggestd` (bin "loggestd" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "6e36062a6be9c8341dec460a10e024018e1d20ad6ad162bbaa14692363367ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e36062a6be9c8341dec460a10e024018e1d20ad6ad162bbaa14692363367ea2", kill_on_drop: false }` [INFO] [stdout] 6e36062a6be9c8341dec460a10e024018e1d20ad6ad162bbaa14692363367ea2