[INFO] fetching crate logfast 1.1.8... [INFO] checking logfast-1.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate logfast 1.1.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate logfast 1.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate logfast 1.1.8 [INFO] finished tweaking crates.io crate logfast 1.1.8 [INFO] tweaked toml for crates.io crate logfast 1.1.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 665c0128a6b86c22a63b6ae6b065db60bae1160543f9693cb44d39025d0d539e [INFO] running `Command { std: "docker" "start" "-a" "665c0128a6b86c22a63b6ae6b065db60bae1160543f9693cb44d39025d0d539e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "665c0128a6b86c22a63b6ae6b065db60bae1160543f9693cb44d39025d0d539e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "665c0128a6b86c22a63b6ae6b065db60bae1160543f9693cb44d39025d0d539e", kill_on_drop: false }` [INFO] [stdout] 665c0128a6b86c22a63b6ae6b065db60bae1160543f9693cb44d39025d0d539e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a092fce72ab3a50f2c90e01488889842560f4601d74496fc21922c6619a0af6 [INFO] running `Command { std: "docker" "start" "-a" "5a092fce72ab3a50f2c90e01488889842560f4601d74496fc21922c6619a0af6", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking die v0.2.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking logfast v1.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 63 | let barrier_moved = barrier.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 67 | | while let Ok(msg) = dest.recv() { [INFO] [stdout] 68 | | writeln!(log_file, "{}", msg).unwrap_or_else(|err| { [INFO] [stdout] 69 | | die!("Error writing to log file '{}': {}", filename_moved, err) [INFO] [stdout] ... | [INFO] [stdout] 73 | | barrier_moved.wait(); [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mut log_file = match OpenOptions::new().create(true).append(true).open(filename) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Ok(log_file) => log_file, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Err(err) => return Err(format!("Error opening log file '{}': {}", filename, err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (src, dest) = sync_channel::(buffer_size); [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let barrier = Arc::new(Barrier::new(2)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(LogFast { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | filename: filename.to_string(), [INFO] [stdout] 79 | | src: Some(src), [INFO] [stdout] 80 | | barrier, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logfast` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 63 | let barrier_moved = barrier.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 67 | | while let Ok(msg) = dest.recv() { [INFO] [stdout] 68 | | writeln!(log_file, "{}", msg).unwrap_or_else(|err| { [INFO] [stdout] 69 | | die!("Error writing to log file '{}': {}", filename_moved, err) [INFO] [stdout] ... | [INFO] [stdout] 73 | | barrier_moved.wait(); [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mut log_file = match OpenOptions::new().create(true).append(true).open(filename) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Ok(log_file) => log_file, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Err(err) => return Err(format!("Error opening log file '{}': {}", filename, err)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (src, dest) = sync_channel::(buffer_size); [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let barrier = Arc::new(Barrier::new(2)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(LogFast { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | filename: filename.to_string(), [INFO] [stdout] 79 | | src: Some(src), [INFO] [stdout] 80 | | barrier, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logfast` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "5a092fce72ab3a50f2c90e01488889842560f4601d74496fc21922c6619a0af6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a092fce72ab3a50f2c90e01488889842560f4601d74496fc21922c6619a0af6", kill_on_drop: false }` [INFO] [stdout] 5a092fce72ab3a50f2c90e01488889842560f4601d74496fc21922c6619a0af6