[INFO] fetching crate local-spawn-pool 0.1.0... [INFO] checking local-spawn-pool-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate local-spawn-pool 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate local-spawn-pool 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate local-spawn-pool 0.1.0 [INFO] finished tweaking crates.io crate local-spawn-pool 0.1.0 [INFO] tweaked toml for crates.io crate local-spawn-pool 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f46a6346fa594f19697b146a6867ec9e51e123c1c8e7041880a5b7a7a5fa2c48 [INFO] running `Command { std: "docker" "start" "-a" "f46a6346fa594f19697b146a6867ec9e51e123c1c8e7041880a5b7a7a5fa2c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f46a6346fa594f19697b146a6867ec9e51e123c1c8e7041880a5b7a7a5fa2c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f46a6346fa594f19697b146a6867ec9e51e123c1c8e7041880a5b7a7a5fa2c48", kill_on_drop: false }` [INFO] [stdout] f46a6346fa594f19697b146a6867ec9e51e123c1c8e7041880a5b7a7a5fa2c48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70352c08cd69ea0c301493bcc40b2a052d02f04ffabb1c3144ca31f7783a98e1 [INFO] running `Command { std: "docker" "start" "-a" "70352c08cd69ea0c301493bcc40b2a052d02f04ffabb1c3144ca31f7783a98e1", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking local-spawn-pool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn spawn(&self, future: F) -> JoinHandle [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | self.0.borrow_mut().spawn(future) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:26 [INFO] [stdout] | [INFO] [stdout] 226 | join_handle: JoinHandle, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | join_handle: Box::pin(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn create_task(future: F) -> (Task, JoinHandle) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let (output_tx, output_rx) = oneshot::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / Task::from(GenericTask { [INFO] [stdout] 20 | | future: Box::pin(future), [INFO] [stdout] 21 | | output_tx: Some(output_tx), [INFO] [stdout] 22 | | abort: Rc::clone(&abort), [INFO] [stdout] 23 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn create_task(future: F) -> (Task, JoinHandle) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let (output_tx, output_rx) = oneshot::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | / JoinHandle(RefCell::new(JoinHandleInner::Pending { [INFO] [stdout] 25 | | output_rx: Box::pin(output_rx), [INFO] [stdout] 26 | | abort, [INFO] [stdout] 27 | | })), [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(generic_task: GenericTask) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self(Box::pin(generic_task)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn access_mut(&self, f: impl FnOnce(&mut Vec) -> R) -> R { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | f(&mut self.0.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(not(test))] f: impl FnOnce(Option<&TasksToAdd>) -> R, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | TASKS_TO_ADD_REF.with(|tasks_to_add_ref| f(tasks_to_add_ref.borrow().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:54:48 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(not(test))] f: impl FnOnce(Option<&TasksToAdd>) -> R, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | TASKS_TO_ADD_REF.with(|tasks_to_add_ref| f(tasks_to_add_ref.borrow().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `local-spawn-pool` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn spawn(&self, future: F) -> JoinHandle [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | self.0.borrow_mut().spawn(future) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:26 [INFO] [stdout] | [INFO] [stdout] 226 | join_handle: JoinHandle, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | join_handle: Box::pin(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn create_task(future: F) -> (Task, JoinHandle) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let (output_tx, output_rx) = oneshot::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / Task::from(GenericTask { [INFO] [stdout] 20 | | future: Box::pin(future), [INFO] [stdout] 21 | | output_tx: Some(output_tx), [INFO] [stdout] 22 | | abort: Rc::clone(&abort), [INFO] [stdout] 23 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn create_task(future: F) -> (Task, JoinHandle) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let (output_tx, output_rx) = oneshot::channel::(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | / JoinHandle(RefCell::new(JoinHandleInner::Pending { [INFO] [stdout] 25 | | output_rx: Box::pin(output_rx), [INFO] [stdout] 26 | | abort, [INFO] [stdout] 27 | | })), [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(generic_task: GenericTask) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self(Box::pin(generic_task)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn access_mut(&self, f: impl FnOnce(&mut Vec) -> R) -> R { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | f(&mut self.0.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 52 | #[cfg(test)] f: impl FnOnce(Option<&(TasksToAdd, &'static str)>) -> R, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ) -> R { [INFO] [stdout] 54 | TASKS_TO_ADD_REF.with(|tasks_to_add_ref| f(tasks_to_add_ref.borrow().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tasks_to_add.rs:54:48 [INFO] [stdout] | [INFO] [stdout] 52 | #[cfg(test)] f: impl FnOnce(Option<&(TasksToAdd, &'static str)>) -> R, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ) -> R { [INFO] [stdout] 54 | TASKS_TO_ADD_REF.with(|tasks_to_add_ref| f(tasks_to_add_ref.borrow().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `local-spawn-pool` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "70352c08cd69ea0c301493bcc40b2a052d02f04ffabb1c3144ca31f7783a98e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70352c08cd69ea0c301493bcc40b2a052d02f04ffabb1c3144ca31f7783a98e1", kill_on_drop: false }` [INFO] [stdout] 70352c08cd69ea0c301493bcc40b2a052d02f04ffabb1c3144ca31f7783a98e1