[INFO] fetching crate lnk-thrussh 0.33.5... [INFO] checking lnk-thrussh-0.33.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lnk-thrussh 0.33.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lnk-thrussh 0.33.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lnk-thrussh 0.33.5 [INFO] finished tweaking crates.io crate lnk-thrussh 0.33.5 [INFO] tweaked toml for crates.io crate lnk-thrussh 0.33.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate lnk-thrussh 0.33.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e89e84935185bf09ac87e73ebdf9698ec589c1d2e037af7830ac49e51eb7728 [INFO] running `Command { std: "docker" "start" "-a" "7e89e84935185bf09ac87e73ebdf9698ec589c1d2e037af7830ac49e51eb7728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e89e84935185bf09ac87e73ebdf9698ec589c1d2e037af7830ac49e51eb7728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e89e84935185bf09ac87e73ebdf9698ec589c1d2e037af7830ac49e51eb7728", kill_on_drop: false }` [INFO] [stdout] 7e89e84935185bf09ac87e73ebdf9698ec589c1d2e037af7830ac49e51eb7728 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6deaa124d5d787ff8c744d85d1dd06b419cabcae8612838cad7656cb2b5157c7 [INFO] running `Command { std: "docker" "start" "-a" "6deaa124d5d787ff8c744d85d1dd06b419cabcae8612838cad7656cb2b5157c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking base64ct v1.3.3 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking blowfish v0.8.0 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Checking block-modes v0.8.1 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking lnk-cryptovec v0.6.1 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking password-hash v0.2.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pbkdf2 v0.8.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bcrypt-pbkdf v0.6.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking yasna v0.4.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking lnk-thrussh-encoding v0.1.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking lnk-thrussh-agent v0.1.0 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking lnk-thrussh-libsodium v0.2.1 [INFO] [stderr] Checking lnk-thrussh-keys v0.21.0 [INFO] [stderr] Checking lnk-thrussh v0.33.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::kex::*` [INFO] [stdout] --> src/server/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub use self::kex::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::kex::*` [INFO] [stdout] --> src/server/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub use self::kex::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/encrypted.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let mut enc = self.common.encrypted.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/encrypted.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut enc = self.common.encrypted.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/encrypted.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let mut enc = self.common.encrypted.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server/encrypted.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut enc = self.common.encrypted.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `algo` are never read [INFO] [stdout] --> src/auth.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | PublicKey { [INFO] [stdout] | --------- fields in this variant [INFO] [stdout] 143 | key: CryptoVec, [INFO] [stdout] | ^^^ [INFO] [stdout] 144 | algo: CryptoVec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurrentRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/cipher/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Cipher { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 24 | pub name: Name, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `wants_reply` is never read [INFO] [stdout] --> src/session.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) struct Encrypted { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub wants_reply: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Encrypted` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `received` is never read [INFO] [stdout] --> src/session.rs:508:9 [INFO] [stdout] | [INFO] [stdout] 501 | pub struct NewKeys { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 508 | pub received: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewKeys` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:32 [INFO] [stdout] | [INFO] [stdout] 455 | fn finished(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | futures::future::ready(Ok(t)) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:462:18 [INFO] [stdout] | [INFO] [stdout] 461 | fn finished(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | Box::new(futures::future::ready(Ok(t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:88:35 [INFO] [stdout] | [INFO] [stdout] 86 | fn auth_publickey_sign(self, key: &key::PublicKey, to_sign: CryptoVec) -> Self::Future { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let fut = self.sign_request(key, to_sign); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | futures::FutureExt::boxed(async move { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 89 | | let (a, b) = fut.await; [INFO] [stdout] 90 | | (a, b.map_err(AgentAuthError::Client)) [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 87 | let fut = self.sign_request(key, to_sign); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | futures::FutureExt::boxed(async move { [INFO] [stdout] 89 | let (a, b) = fut.await; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | (a, b.map_err(AgentAuthError::Client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ssh_read.rs:51:10 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn split(self) -> (SshRead>, tokio::io::WriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let (r, w) = tokio::io::split(self.r); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (SshRead { id: self.id, r }, w) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ssh_read.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(r: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | SshRead { [INFO] [stdout] 109 | id: Some(ReadSshIdBuffer::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:487:12 [INFO] [stdout] | [INFO] [stdout] 474 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | Ok(NewKeys { [INFO] [stdout] | ____________^ [INFO] [stdout] 488 | | exchange: self.exchange, [INFO] [stdout] 489 | | names: self.names, [INFO] [stdout] 490 | | kex: self.kex, [INFO] [stdout] ... | [INFO] [stdout] 495 | | sent: false, [INFO] [stdout] 496 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/encrypted.rs:464:41 [INFO] [stdout] | [INFO] [stdout] 464 | .map_err(|e| H::Error::from(crate::Error::from(e))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:1101:16 [INFO] [stdout] | [INFO] [stdout] 1053 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1071 | let mut buffer = buffer.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1099 | let mut newkeys = self.compute_keys(hash, false)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1100 | newkeys.sent = true; [INFO] [stdout] 1101 | Ok(Kex::NewKeys(newkeys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/kex.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 10 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(KexDhDone { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | exchange: self.exchange, [INFO] [stdout] 49 | | names: algo, [INFO] [stdout] 50 | | kex: kex, [INFO] [stdout] 51 | | key: 0, [INFO] [stdout] 52 | | session_id: self.session_id, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lnk-thrussh` (lib) due to 11 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `key` and `algo` are never read [INFO] [stdout] --> src/auth.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | PublicKey { [INFO] [stdout] | --------- fields in this variant [INFO] [stdout] 143 | key: CryptoVec, [INFO] [stdout] | ^^^ [INFO] [stdout] 144 | algo: CryptoVec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurrentRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/cipher/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Cipher { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 24 | pub name: Name, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `wants_reply` is never read [INFO] [stdout] --> src/session.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) struct Encrypted { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub wants_reply: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Encrypted` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `received` is never read [INFO] [stdout] --> src/session.rs:508:9 [INFO] [stdout] | [INFO] [stdout] 501 | pub struct NewKeys { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 508 | pub received: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NewKeys` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `client_pubkey` is never read [INFO] [stdout] --> src/lib.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 717 | struct Server { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 718 | client_pubkey: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Server` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:32 [INFO] [stdout] | [INFO] [stdout] 455 | fn finished(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | futures::future::ready(Ok(t)) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:462:18 [INFO] [stdout] | [INFO] [stdout] 461 | fn finished(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | Box::new(futures::future::ready(Ok(t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:88:35 [INFO] [stdout] | [INFO] [stdout] 86 | fn auth_publickey_sign(self, key: &key::PublicKey, to_sign: CryptoVec) -> Self::Future { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let fut = self.sign_request(key, to_sign); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | futures::FutureExt::boxed(async move { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 89 | | let (a, b) = fut.await; [INFO] [stdout] 90 | | (a, b.map_err(AgentAuthError::Client)) [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 87 | let fut = self.sign_request(key, to_sign); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | futures::FutureExt::boxed(async move { [INFO] [stdout] 89 | let (a, b) = fut.await; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | (a, b.map_err(AgentAuthError::Client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ssh_read.rs:51:10 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn split(self) -> (SshRead>, tokio::io::WriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let (r, w) = tokio::io::split(self.r); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (SshRead { id: self.id, r }, w) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ssh_read.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(r: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | SshRead { [INFO] [stdout] 109 | id: Some(ReadSshIdBuffer::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:487:12 [INFO] [stdout] | [INFO] [stdout] 474 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | Ok(NewKeys { [INFO] [stdout] | ____________^ [INFO] [stdout] 488 | | exchange: self.exchange, [INFO] [stdout] 489 | | names: self.names, [INFO] [stdout] 490 | | kex: self.kex, [INFO] [stdout] ... | [INFO] [stdout] 495 | | sent: false, [INFO] [stdout] 496 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/encrypted.rs:464:41 [INFO] [stdout] | [INFO] [stdout] 464 | .map_err(|e| H::Error::from(crate::Error::from(e))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:1101:16 [INFO] [stdout] | [INFO] [stdout] 1053 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1071 | let mut buffer = buffer.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1099 | let mut newkeys = self.compute_keys(hash, false)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1100 | newkeys.sent = true; [INFO] [stdout] 1101 | Ok(Kex::NewKeys(newkeys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/kex.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 10 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(KexDhDone { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | exchange: self.exchange, [INFO] [stdout] 49 | | names: algo, [INFO] [stdout] 50 | | kex: kex, [INFO] [stdout] 51 | | key: 0, [INFO] [stdout] 52 | | session_id: self.session_id, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:708:9 [INFO] [stdout] | [INFO] [stdout] 708 | match msg { [INFO] [stdout] | _________^ - [INFO] [stdout] | |___________________| [INFO] [stdout] 709 | || ChannelMsg::Data { data: msg_data } => { [INFO] [stdout] 710 | || assert_eq!(*data, *msg_data) [INFO] [stdout] 711 | || } [INFO] [stdout] 712 | || msg => panic!("Unexpected message {:?}", msg), [INFO] [stdout] 713 | || } [INFO] [stdout] | ||_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:739:36 [INFO] [stdout] | [INFO] [stdout] 738 | fn finished_auth(self, auth: Auth) -> Self::FutureAuth { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 739 | futures::future::ready(Ok((self, auth))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:742:36 [INFO] [stdout] | [INFO] [stdout] 741 | fn finished_bool(self, b: bool, s: Session) -> Self::FutureBool { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | futures::future::ready(Ok((self, s, b))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:745:36 [INFO] [stdout] | [INFO] [stdout] 744 | fn finished(self, s: Session) -> Self::FutureUnit { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 745 | futures::future::ready(Ok((self, s))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:776:36 [INFO] [stdout] | [INFO] [stdout] 775 | fn finished(self, session: client::Session) -> Self::FutureUnit { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 776 | futures::future::ready(Ok((self, session))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lnk-thrussh` (lib test) due to 16 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6deaa124d5d787ff8c744d85d1dd06b419cabcae8612838cad7656cb2b5157c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6deaa124d5d787ff8c744d85d1dd06b419cabcae8612838cad7656cb2b5157c7", kill_on_drop: false }` [INFO] [stdout] 6deaa124d5d787ff8c744d85d1dd06b419cabcae8612838cad7656cb2b5157c7