[INFO] fetching crate lmb_engine_simulator 0.1.0... [INFO] checking lmb_engine_simulator-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lmb_engine_simulator 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate lmb_engine_simulator 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lmb_engine_simulator 0.1.0 [INFO] finished tweaking crates.io crate lmb_engine_simulator 0.1.0 [INFO] tweaked toml for crates.io crate lmb_engine_simulator 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate lmb_engine_simulator 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34b2e93c3d24efe988c2daedf29d535ece921e8dd7a0ae973cd74f28884e9c84 [INFO] running `Command { std: "docker" "start" "-a" "34b2e93c3d24efe988c2daedf29d535ece921e8dd7a0ae973cd74f28884e9c84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34b2e93c3d24efe988c2daedf29d535ece921e8dd7a0ae973cd74f28884e9c84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34b2e93c3d24efe988c2daedf29d535ece921e8dd7a0ae973cd74f28884e9c84", kill_on_drop: false }` [INFO] [stdout] 34b2e93c3d24efe988c2daedf29d535ece921e8dd7a0ae973cd74f28884e9c84 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b11d21434a266da9dd1421c61cbacc47db9c01481aa8fb604c5a8d0b5e8b384 [INFO] running `Command { std: "docker" "start" "-a" "7b11d21434a266da9dd1421c61cbacc47db9c01481aa8fb604c5a8d0b5e8b384", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling ndarray v0.13.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking dyn-clone v1.0.2 [INFO] [stderr] Checking gnuplot v0.0.34 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling serde_derive v1.0.105 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking lmb_engine_simulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `max_lift` is never read [INFO] [stdout] --> src/connector/valve.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Valve { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | max_lift: f64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Valve` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `time_opened`, `acceler_ratio`, and `max_lift_diam_ratio` are never read [INFO] [stdout] --> src/connector/valve.rs:374:5 [INFO] [stdout] | [INFO] [stdout] 373 | struct ValveLift { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 374 | time_opened: f64, //in crank angle degree [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 375 | acceler_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 376 | max_lift_diam_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ValveLift` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `air_fuel_ratio` is never read [INFO] [stdout] --> src/reaction/combustion.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct TwoZoneCombustion { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 36 | air_fuel_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TwoZoneCombustion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/system_builder.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn build_system(self) -> System { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match System::new( [INFO] [stdout] | _______________^ [INFO] [stdout] 48 | | self.objs_info, [INFO] [stdout] 49 | | self.engine, [INFO] [stdout] 50 | | self.zero_dim, [INFO] [stdout] 51 | | self.one_dim, [INFO] [stdout] 52 | | self.connector, [INFO] [stdout] 53 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine.rs:333:54 [INFO] [stdout] | [INFO] [stdout] 333 | .for_each(|c| c.set_combustion_model(comb.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zero_dim/cylinder.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 53 | combustion: Box, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Cylinder { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | name, [INFO] [stdout] 108 | | gas: gas.clone(), [INFO] [stdout] 109 | | mass: gas.P() * volume / (gas.R() * gas.T()), [INFO] [stdout] ... | [INFO] [stdout] 130 | | residual_mass_frac: 0.0, [INFO] [stdout] 131 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lmb_engine_simulator` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `max_lift` is never read [INFO] [stdout] --> src/connector/valve.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Valve { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | max_lift: f64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Valve` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `time_opened`, `acceler_ratio`, and `max_lift_diam_ratio` are never read [INFO] [stdout] --> src/connector/valve.rs:374:5 [INFO] [stdout] | [INFO] [stdout] 373 | struct ValveLift { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 374 | time_opened: f64, //in crank angle degree [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 375 | acceler_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 376 | max_lift_diam_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ValveLift` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `air_fuel_ratio` is never read [INFO] [stdout] --> src/reaction/combustion.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct TwoZoneCombustion { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 36 | air_fuel_ratio: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TwoZoneCombustion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/system_builder.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn build_system(self) -> System { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match System::new( [INFO] [stdout] | _______________^ [INFO] [stdout] 48 | | self.objs_info, [INFO] [stdout] 49 | | self.engine, [INFO] [stdout] 50 | | self.zero_dim, [INFO] [stdout] 51 | | self.one_dim, [INFO] [stdout] 52 | | self.connector, [INFO] [stdout] 53 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/engine.rs:333:54 [INFO] [stdout] | [INFO] [stdout] 333 | .for_each(|c| c.set_combustion_model(comb.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zero_dim/cylinder.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 53 | combustion: Box, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Cylinder { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | name, [INFO] [stdout] 108 | | gas: gas.clone(), [INFO] [stdout] 109 | | mass: gas.P() * volume / (gas.R() * gas.T()), [INFO] [stdout] ... | [INFO] [stdout] 130 | | residual_mass_frac: 0.0, [INFO] [stdout] 131 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lmb_engine_simulator` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7b11d21434a266da9dd1421c61cbacc47db9c01481aa8fb604c5a8d0b5e8b384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b11d21434a266da9dd1421c61cbacc47db9c01481aa8fb604c5a8d0b5e8b384", kill_on_drop: false }` [INFO] [stdout] 7b11d21434a266da9dd1421c61cbacc47db9c01481aa8fb604c5a8d0b5e8b384