[INFO] fetching crate lluvia 0.0.2... [INFO] checking lluvia-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lluvia 0.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate lluvia 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lluvia 0.0.2 [INFO] finished tweaking crates.io crate lluvia 0.0.2 [INFO] tweaked toml for crates.io crate lluvia 0.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4f8d6d5e95389958fd038af5dfef23b0afacecc8b9f1ac5034f031b6d269b94 [INFO] running `Command { std: "docker" "start" "-a" "b4f8d6d5e95389958fd038af5dfef23b0afacecc8b9f1ac5034f031b6d269b94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4f8d6d5e95389958fd038af5dfef23b0afacecc8b9f1ac5034f031b6d269b94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4f8d6d5e95389958fd038af5dfef23b0afacecc8b9f1ac5034f031b6d269b94", kill_on_drop: false }` [INFO] [stdout] b4f8d6d5e95389958fd038af5dfef23b0afacecc8b9f1ac5034f031b6d269b94 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94701d543fe93bebcc6ee3c244081eb9b26cdd69084ddd42e0a02afc5f47c588 [INFO] running `Command { std: "docker" "start" "-a" "94701d543fe93bebcc6ee3c244081eb9b26cdd69084ddd42e0a02afc5f47c588", kill_on_drop: false }` [INFO] [stderr] Checking lluvia v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `as_mut_any` is never used [INFO] [stdout] --> src/lib.rs:456:8 [INFO] [stdout] | [INFO] [stdout] 448 | trait ComponentTable { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 456 | fn as_mut_any(&mut self) -> &mut dyn Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:501:25 [INFO] [stdout] | [INFO] [stdout] 499 | pub fn new(container: C) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 500 | Self { [INFO] [stdout] 501 | t_internal: Arc::new(RwLock::new(TableInternal { [INFO] [stdout] | _________________________^ [INFO] [stdout] 502 | | t_entity: container, [INFO] [stdout] 503 | | _t_phantom: PhantomData, [INFO] [stdout] 504 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:670:32 [INFO] [stdout] | [INFO] [stdout] 666 | pub fn add_non_sparse_component(&mut self, callback: F) -> NonSparseComponent [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | self.add_raw_component(SliceContainer { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 671 | | v_vec: Vec::new(), [INFO] [stdout] 672 | | v_callback: Box::new(callback), [INFO] [stdout] 673 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1047:21 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1046 | Self { [INFO] [stdout] 1047 | s_data: RawComponent { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1048 | | c_table: Table::new(VecContainer::new(DEFAULT_LLUVIA_SNAPSHOT_BLOCK_SIZE)), [INFO] [stdout] 1049 | | c_inst: parent.c_inst.clone(), [INFO] [stdout] 1050 | | _c_phantom: PhantomData, [INFO] [stdout] 1051 | | c_modified: Arc::new(AtomicBool::new(false)), [INFO] [stdout] 1052 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1053:20 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1053 | s_ids: RawComponent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1054 | | c_table: Table::new(VecContainer::new(DEFAULT_LLUVIA_SNAPSHOT_BLOCK_SIZE)), [INFO] [stdout] 1055 | | c_inst: parent.c_inst.clone(), [INFO] [stdout] 1056 | | _c_phantom: PhantomData, [INFO] [stdout] 1057 | | c_modified: Arc::new(AtomicBool::new(false)), [INFO] [stdout] 1058 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1061:26 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1061 | s_committed: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lluvia` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `as_mut_any` is never used [INFO] [stdout] --> src/lib.rs:456:8 [INFO] [stdout] | [INFO] [stdout] 448 | trait ComponentTable { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 456 | fn as_mut_any(&mut self) -> &mut dyn Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:501:25 [INFO] [stdout] | [INFO] [stdout] 499 | pub fn new(container: C) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 500 | Self { [INFO] [stdout] 501 | t_internal: Arc::new(RwLock::new(TableInternal { [INFO] [stdout] | _________________________^ [INFO] [stdout] 502 | | t_entity: container, [INFO] [stdout] 503 | | _t_phantom: PhantomData, [INFO] [stdout] 504 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:670:32 [INFO] [stdout] | [INFO] [stdout] 666 | pub fn add_non_sparse_component(&mut self, callback: F) -> NonSparseComponent [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | self.add_raw_component(SliceContainer { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 671 | | v_vec: Vec::new(), [INFO] [stdout] 672 | | v_callback: Box::new(callback), [INFO] [stdout] 673 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1047:21 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1046 | Self { [INFO] [stdout] 1047 | s_data: RawComponent { [INFO] [stdout] | _____________________^ [INFO] [stdout] 1048 | | c_table: Table::new(VecContainer::new(DEFAULT_LLUVIA_SNAPSHOT_BLOCK_SIZE)), [INFO] [stdout] 1049 | | c_inst: parent.c_inst.clone(), [INFO] [stdout] 1050 | | _c_phantom: PhantomData, [INFO] [stdout] 1051 | | c_modified: Arc::new(AtomicBool::new(false)), [INFO] [stdout] 1052 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1053:20 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1053 | s_ids: RawComponent { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1054 | | c_table: Table::new(VecContainer::new(DEFAULT_LLUVIA_SNAPSHOT_BLOCK_SIZE)), [INFO] [stdout] 1055 | | c_inst: parent.c_inst.clone(), [INFO] [stdout] 1056 | | _c_phantom: PhantomData, [INFO] [stdout] 1057 | | c_modified: Arc::new(AtomicBool::new(false)), [INFO] [stdout] 1058 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1061:26 [INFO] [stdout] | [INFO] [stdout] 1045 | fn new(parent: Box>, parent_snapshot: Option>>) -> Self { [INFO] [stdout] | ------------------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1061 | s_committed: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lluvia` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "94701d543fe93bebcc6ee3c244081eb9b26cdd69084ddd42e0a02afc5f47c588", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94701d543fe93bebcc6ee3c244081eb9b26cdd69084ddd42e0a02afc5f47c588", kill_on_drop: false }` [INFO] [stdout] 94701d543fe93bebcc6ee3c244081eb9b26cdd69084ddd42e0a02afc5f47c588