[INFO] fetching crate llrb 0.0.1... [INFO] checking llrb-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate llrb 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate llrb 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate llrb 0.0.1 [INFO] finished tweaking crates.io crate llrb 0.0.1 [INFO] tweaked toml for crates.io crate llrb 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a147fda9acbfd8cd81ada8be9b25202b500f0ff694c12231dd11cc7b5161ca28 [INFO] running `Command { std: "docker" "start" "-a" "a147fda9acbfd8cd81ada8be9b25202b500f0ff694c12231dd11cc7b5161ca28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a147fda9acbfd8cd81ada8be9b25202b500f0ff694c12231dd11cc7b5161ca28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a147fda9acbfd8cd81ada8be9b25202b500f0ff694c12231dd11cc7b5161ca28", kill_on_drop: false }` [INFO] [stdout] a147fda9acbfd8cd81ada8be9b25202b500f0ff694c12231dd11cc7b5161ca28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e5fae6eceb93d38d91c3363c86919703b2cc1076608d68ec45da2095566039f [INFO] running `Command { std: "docker" "start" "-a" "9e5fae6eceb93d38d91c3363c86919703b2cc1076608d68ec45da2095566039f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking llrb v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `right_is_red` [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | let right_is_red = is_red(&self.left); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_right_is_red` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/lib.rs:289:43 [INFO] [stdout] | [INFO] [stdout] 289 | if let Some((ref mut key, ref mut val)) = self.kv { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/lib.rs:335:30 [INFO] [stdout] | [INFO] [stdout] 335 | pub fn append(&mut self, other: &mut Self) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_red_right`, `move_red_left`, and `min` are never used [INFO] [stdout] --> src/lib.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 49 | impl LLRB { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn move_red_right(&mut self) {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 93 | [INFO] [stdout] 94 | fn move_red_left(&mut self) {} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 303 | fn min(&self) -> &LLRB { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:399:65 [INFO] [stdout] | [INFO] [stdout] 399 | let mut child = child_ref.take().unwrap_or_else(|| Box::new(LLRB::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `llrb` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `right_is_red` [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | let right_is_red = is_red(&self.left); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_right_is_red` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/lib.rs:289:43 [INFO] [stdout] | [INFO] [stdout] 289 | if let Some((ref mut key, ref mut val)) = self.kv { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/lib.rs:335:30 [INFO] [stdout] | [INFO] [stdout] 335 | pub fn append(&mut self, other: &mut Self) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_red_right`, `move_red_left`, and `min` are never used [INFO] [stdout] --> src/lib.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 49 | impl LLRB { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 92 | fn move_red_right(&mut self) {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 93 | [INFO] [stdout] 94 | fn move_red_left(&mut self) {} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 303 | fn min(&self) -> &LLRB { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:399:65 [INFO] [stdout] | [INFO] [stdout] 399 | let mut child = child_ref.take().unwrap_or_else(|| Box::new(LLRB::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `llrb` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9e5fae6eceb93d38d91c3363c86919703b2cc1076608d68ec45da2095566039f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e5fae6eceb93d38d91c3363c86919703b2cc1076608d68ec45da2095566039f", kill_on_drop: false }` [INFO] [stdout] 9e5fae6eceb93d38d91c3363c86919703b2cc1076608d68ec45da2095566039f