[INFO] fetching crate llm-weaver 0.1.97... [INFO] checking llm-weaver-0.1.97 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate llm-weaver 0.1.97 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate llm-weaver 0.1.97 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate llm-weaver 0.1.97 [INFO] finished tweaking crates.io crate llm-weaver 0.1.97 [INFO] tweaked toml for crates.io crate llm-weaver 0.1.97 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 196 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding aquamarine v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding async-openai v0.23.4 (latest: v0.24.0) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding fancy-regex v0.12.0 (latest: v0.13.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redis v0.25.4 (latest: v0.26.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustls v0.22.4 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.25.0 (latest: v0.26.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee57ac4a624b31359c5e8ac16f68d37907c0d2e50ec13c89953944ebe2bd8ac9 [INFO] running `Command { std: "docker" "start" "-a" "ee57ac4a624b31359c5e8ac16f68d37907c0d2e50ec13c89953944ebe2bd8ac9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee57ac4a624b31359c5e8ac16f68d37907c0d2e50ec13c89953944ebe2bd8ac9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee57ac4a624b31359c5e8ac16f68d37907c0d2e50ec13c89953944ebe2bd8ac9", kill_on_drop: false }` [INFO] [stdout] ee57ac4a624b31359c5e8ac16f68d37907c0d2e50ec13c89953944ebe2bd8ac9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a54eaaa3311167c310ca1b9fc1a6e4db20e7dc421cf72e53b10460f543af7b96 [INFO] running `Command { std: "docker" "start" "-a" "a54eaaa3311167c310ca1b9fc1a6e4db20e7dc421cf72e53b10460f543af7b96", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling derive_builder_core v0.20.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking async-convert v1.0.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking bounded-integer v0.5.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling include_dir v0.7.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Compiling derive_builder_macro v0.20.1 [INFO] [stderr] Checking derive_builder v0.20.1 [INFO] [stderr] Checking rustls v0.22.4 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling aquamarine v0.3.3 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking fancy-regex v0.12.0 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking tiktoken-rs v0.5.9 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking reqwest-eventsource v0.6.0 [INFO] [stderr] Checking async-openai v0.23.4 [INFO] [stderr] Checking redis v0.25.4 [INFO] [stderr] Checking llm-weaver v0.1.97 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:100:2 [INFO] [stdout] | [INFO] [stdout] 100 | / async fn save_tapestry_fragment( [INFO] [stdout] 101 | | tapestry_id: &TID, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | pipe.query(con) [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:154:2 [INFO] [stdout] | [INFO] [stdout] 154 | / async fn save_tapestry_metadata< [INFO] [stdout] 155 | | TID: TapestryId, [INFO] [stdout] 156 | | M: ToRedisArgs + Debug + Clone + Send + Sync, [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:167:7 [INFO] [stdout] | [INFO] [stdout] 167 | con.hset(key, "metadata", metadata.clone()).await.map_err(|e| { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:100:2 [INFO] [stdout] | [INFO] [stdout] 100 | / async fn save_tapestry_fragment( [INFO] [stdout] 101 | | tapestry_id: &TID, [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | pipe.query(con) [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:154:2 [INFO] [stdout] | [INFO] [stdout] 154 | / async fn save_tapestry_metadata< [INFO] [stdout] 155 | | TID: TapestryId, [INFO] [stdout] 156 | | M: ToRedisArgs + Debug + Clone + Send + Sync, [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:167:7 [INFO] [stdout] | [INFO] [stdout] 167 | con.hset(key, "metadata", metadata.clone()).await.map_err(|e| { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:269:2 [INFO] [stdout] | [INFO] [stdout] 269 | async fn delete_tapestry(tapestry_id: TID) -> crate::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | con.del(&instance_key).await.map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:311:2 [INFO] [stdout] | [INFO] [stdout] 311 | async fn delete_tapestry_fragment( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:328:7 [INFO] [stdout] | [INFO] [stdout] 328 | con.del(&key).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:269:2 [INFO] [stdout] | [INFO] [stdout] 269 | async fn delete_tapestry(tapestry_id: TID) -> crate::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | con.del(&instance_key).await.map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/storage.rs:311:2 [INFO] [stdout] | [INFO] [stdout] 311 | async fn delete_tapestry_fragment( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/storage.rs:328:7 [INFO] [stdout] | [INFO] [stdout] 328 | con.del(&key).map_err(|e| { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | .map(|m| T::PromptModel::count_tokens(&m.content).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:22 [INFO] [stdout] | [INFO] [stdout] 533 | summary_model_config: LlmConfig, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | ) -> Result { [INFO] [stdout] | _________________________^ [INFO] [stdout] 537 | | trace!( [INFO] [stdout] 538 | | "Generating summary with max tokens: {:?}, for tapestry fragment: {:?}", [INFO] [stdout] 539 | | summary_max_tokens, [INFO] [stdout] ... | [INFO] [stdout] 570 | | Ok(summary_response_content.unwrap_or_default()) [INFO] [stdout] 571 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 146 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | error!("Failed to save tapestry fragment: {}", e); [INFO] [stdout] 148 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:160:25 [INFO] [stdout] | [INFO] [stdout] 158 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | metadata: M, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 161 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 162 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] 163 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(()) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 167 | con.hset(key, "metadata", metadata.clone()).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | error!("Failed to save \"metadata\" member to {} key: {}", key, e); [INFO] [stdout] 169 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:177:89 [INFO] [stdout] | [INFO] [stdout] 177 | async fn get_tapestry(tapestry_id: TID) -> crate::Result> { [INFO] [stdout] | ____________________________________________----------------________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 179 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] ... | [INFO] [stdout] 197 | | Ok(Some(tapestry)) [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 183 | let exists: bool = con.exists(base_key).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | error!("Failed to check if {} tapestry_id exists: {}", base_key, e); [INFO] [stdout] 185 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:194:20 [INFO] [stdout] | [INFO] [stdout] 192 | let tapestry: u16 = con.hget(base_key, INSTANCE_COUNT).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | error!("Failed to get {} tapestry_id: {}", base_key, e); [INFO] [stdout] 194 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:203:50 [INFO] [stdout] | [INFO] [stdout] 201 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | instance: Option, [INFO] [stdout] 203 | ) -> crate::Result>> { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 204 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 205 | | let mut con = client.get_connection()?; [INFO] [stdout] 206 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 244 | | Ok(Some(tapestry_fragment)) [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 219 | let context_tokens_str: String = con.hget(&key, "context_tokens").map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | error!("Failed to get \"context_tokens\" member from {} key: {}", key, e); [INFO] [stdout] 221 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 230 | con.hget(&key, "context_messages").map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | error!("Failed to get \"context_messages\" member from {} key: {}", key, e); [INFO] [stdout] 232 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:249:32 [INFO] [stdout] | [INFO] [stdout] 248 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | ) -> crate::Result> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 250 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 251 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] 252 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 266 | | Ok(Some(tapestry_metadata)) [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:258:20 [INFO] [stdout] | [INFO] [stdout] 256 | let metadata_raw: Vec = con.hget(key, "metadata").await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | error!("Failed to get \"metadata\" member from {} key: {}", key, e); [INFO] [stdout] 258 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:269:83 [INFO] [stdout] | [INFO] [stdout] 269 | async fn delete_tapestry(tapestry_id: TID) -> crate::Result<()> { [INFO] [stdout] | _______________________________________________----------------_______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 271 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] ... | [INFO] [stdout] 308 | | Ok(()) [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:277:20 [INFO] [stdout] | [INFO] [stdout] 275 | let exists: bool = con.exists(tapestry_id).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | error!("Failed to check if {} tapestry_id exists: {}", tapestry_id, e); [INFO] [stdout] 277 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 285 | let instance_count: u16 = con.hget(tapestry_id, INSTANCE_COUNT).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | error!("Failed to get {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 287 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 295 | con.del(&instance_key).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | error!("Failed to delete {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 297 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:303:20 [INFO] [stdout] | [INFO] [stdout] 301 | con.del(tapestry_id).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | error!("Failed to delete {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 303 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:314:25 [INFO] [stdout] | [INFO] [stdout] 312 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | instance: Option, [INFO] [stdout] 314 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 315 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 316 | | let mut con = client.get_connection()?; [INFO] [stdout] 317 | | let base_key = &tapestry_id.base_key(); [INFO] [stdout] ... | [INFO] [stdout] 335 | | Ok(()) [INFO] [stdout] 336 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:330:20 [INFO] [stdout] | [INFO] [stdout] 328 | con.del(&key).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | error!("Failed to delete {} tapestry_id: {}", key, e); [INFO] [stdout] 330 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:388:21 [INFO] [stdout] | [INFO] [stdout] 386 | None => con.hget(base_key, INSTANCE_COUNT).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | error!("Failed to get {} tapestry_id: {}", base_key, e); [INFO] [stdout] 388 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(error: Box) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | match error.downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `llm-weaver` (lib) due to 23 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | .map(|m| T::PromptModel::count_tokens(&m.content).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:536:22 [INFO] [stdout] | [INFO] [stdout] 533 | summary_model_config: LlmConfig, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | ) -> Result { [INFO] [stdout] | _________________________^ [INFO] [stdout] 537 | | trace!( [INFO] [stdout] 538 | | "Generating summary with max tokens: {:?}, for tapestry fragment: {:?}", [INFO] [stdout] 539 | | summary_max_tokens, [INFO] [stdout] ... | [INFO] [stdout] 570 | | Ok(summary_response_content.unwrap_or_default()) [INFO] [stdout] 571 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 146 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | error!("Failed to save tapestry fragment: {}", e); [INFO] [stdout] 148 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:160:25 [INFO] [stdout] | [INFO] [stdout] 158 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | metadata: M, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 161 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 162 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] 163 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(()) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 167 | con.hset(key, "metadata", metadata.clone()).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | error!("Failed to save \"metadata\" member to {} key: {}", key, e); [INFO] [stdout] 169 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:177:89 [INFO] [stdout] | [INFO] [stdout] 177 | async fn get_tapestry(tapestry_id: TID) -> crate::Result> { [INFO] [stdout] | ____________________________________________----------------________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 179 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] ... | [INFO] [stdout] 197 | | Ok(Some(tapestry)) [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 183 | let exists: bool = con.exists(base_key).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | error!("Failed to check if {} tapestry_id exists: {}", base_key, e); [INFO] [stdout] 185 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:194:20 [INFO] [stdout] | [INFO] [stdout] 192 | let tapestry: u16 = con.hget(base_key, INSTANCE_COUNT).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | error!("Failed to get {} tapestry_id: {}", base_key, e); [INFO] [stdout] 194 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:203:50 [INFO] [stdout] | [INFO] [stdout] 201 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | instance: Option, [INFO] [stdout] 203 | ) -> crate::Result>> { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 204 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 205 | | let mut con = client.get_connection()?; [INFO] [stdout] 206 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 244 | | Ok(Some(tapestry_fragment)) [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 219 | let context_tokens_str: String = con.hget(&key, "context_tokens").map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | error!("Failed to get \"context_tokens\" member from {} key: {}", key, e); [INFO] [stdout] 221 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 230 | con.hget(&key, "context_messages").map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | error!("Failed to get \"context_messages\" member from {} key: {}", key, e); [INFO] [stdout] 232 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:249:32 [INFO] [stdout] | [INFO] [stdout] 248 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | ) -> crate::Result> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 250 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 251 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] 252 | | debug!("Connected to Redis"); [INFO] [stdout] ... | [INFO] [stdout] 266 | | Ok(Some(tapestry_metadata)) [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:258:20 [INFO] [stdout] | [INFO] [stdout] 256 | let metadata_raw: Vec = con.hget(key, "metadata").await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | error!("Failed to get \"metadata\" member from {} key: {}", key, e); [INFO] [stdout] 258 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:269:83 [INFO] [stdout] | [INFO] [stdout] 269 | async fn delete_tapestry(tapestry_id: TID) -> crate::Result<()> { [INFO] [stdout] | _______________________________________________----------------_______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 271 | | let mut con = client.get_multiplexed_async_connection().await?; [INFO] [stdout] ... | [INFO] [stdout] 308 | | Ok(()) [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:277:20 [INFO] [stdout] | [INFO] [stdout] 275 | let exists: bool = con.exists(tapestry_id).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | error!("Failed to check if {} tapestry_id exists: {}", tapestry_id, e); [INFO] [stdout] 277 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 285 | let instance_count: u16 = con.hget(tapestry_id, INSTANCE_COUNT).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | error!("Failed to get {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 287 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 295 | con.del(&instance_key).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | error!("Failed to delete {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 297 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:303:20 [INFO] [stdout] | [INFO] [stdout] 301 | con.del(tapestry_id).await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | error!("Failed to delete {} tapestry_id: {}", tapestry_id, e); [INFO] [stdout] 303 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:314:25 [INFO] [stdout] | [INFO] [stdout] 312 | tapestry_id: TID, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | instance: Option, [INFO] [stdout] 314 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 315 | | let client = get_client().await.expect("Failed to get redis client"); [INFO] [stdout] 316 | | let mut con = client.get_connection()?; [INFO] [stdout] 317 | | let base_key = &tapestry_id.base_key(); [INFO] [stdout] ... | [INFO] [stdout] 335 | | Ok(()) [INFO] [stdout] 336 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:330:20 [INFO] [stdout] | [INFO] [stdout] 328 | con.del(&key).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | error!("Failed to delete {} tapestry_id: {}", key, e); [INFO] [stdout] 330 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:388:21 [INFO] [stdout] | [INFO] [stdout] 386 | None => con.hget(base_key, INSTANCE_COUNT).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | error!("Failed to get {} tapestry_id: {}", base_key, e); [INFO] [stdout] 388 | LoomError::from(StorageError::Redis(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(error: Box) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | match error.downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 29 | _tapestry_id: TID, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | _metadata: M, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 32 | | Ok(()) [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:35:90 [INFO] [stdout] | [INFO] [stdout] 35 | async fn get_tapestry(_tapestry_id: TID) -> crate::Result> { [INFO] [stdout] | ____________________________________________-----------------________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | Ok(Some(0)) [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:42:56 [INFO] [stdout] | [INFO] [stdout] 40 | _tapestry_id: TID, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | _instance: Option, [INFO] [stdout] 42 | ) -> crate::Result>> { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 43 | | Ok(Some(TapestryFragment { context_tokens: 0, context_messages: vec![] })) [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 47 | _tapestry_id: TID, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> crate::Result> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 49 | | Ok(Some(serde_json::from_str("{}").unwrap())) [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:52:84 [INFO] [stdout] | [INFO] [stdout] 52 | async fn delete_tapestry(_tapestry_id: TID) -> crate::Result<()> { [INFO] [stdout] | _______________________________________________-----------------_______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | | Ok(()) [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 57 | _tapestry_id: TID, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | _instance: Option, [INFO] [stdout] 59 | ) -> crate::Result<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 60 | | Ok(()) [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | .map(|r| ::PromptModel::count_tokens(&r.msg).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `llm-weaver` (lib test) due to 30 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a54eaaa3311167c310ca1b9fc1a6e4db20e7dc421cf72e53b10460f543af7b96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a54eaaa3311167c310ca1b9fc1a6e4db20e7dc421cf72e53b10460f543af7b96", kill_on_drop: false }` [INFO] [stdout] a54eaaa3311167c310ca1b9fc1a6e4db20e7dc421cf72e53b10460f543af7b96