[INFO] fetching crate lll 0.1.1... [INFO] checking lll-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lll 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lll 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lll 0.1.1 [INFO] finished tweaking crates.io crate lll 0.1.1 [INFO] tweaked toml for crates.io crate lll 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lll 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5cc197d0b298406ee937d2c0afd51d97302703c0f00e0e23347663d75f654b74 [INFO] running `Command { std: "docker" "start" "-a" "5cc197d0b298406ee937d2c0afd51d97302703c0f00e0e23347663d75f654b74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5cc197d0b298406ee937d2c0afd51d97302703c0f00e0e23347663d75f654b74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cc197d0b298406ee937d2c0afd51d97302703c0f00e0e23347663d75f654b74", kill_on_drop: false }` [INFO] [stdout] 5cc197d0b298406ee937d2c0afd51d97302703c0f00e0e23347663d75f654b74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa9c08cbd1761c70fc63b5238742810a6f70b65f5237e0e6e8ae15a6c5dff29b [INFO] running `Command { std: "docker" "start" "-a" "fa9c08cbd1761c70fc63b5238742810a6f70b65f5237e0e6e8ae15a6c5dff29b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling syn v0.15.39 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking arc-swap v0.3.11 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking array-macro v1.0.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking reexport-proc-macro v1.0.6 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking unicode-segmentation v1.3.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking xi-unicode v0.1.0 [INFO] [stderr] Checking fern v0.5.8 [INFO] [stderr] Checking alphanumeric-sort v1.0.6 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.0.1 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking signal-hook v0.1.9 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking backtrace v0.3.33 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling enum-map-derive v0.4.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking enum-map v0.4.1 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Compiling enumset_derive v0.3.2 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking enumset v0.3.19 [INFO] [stderr] Checking cursive v0.9.2 [INFO] [stderr] Checking lll v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `focused_tab` is never read [INFO] [stdout] --> src/application/app.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct App { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | focused_tab: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut siv = Cursive::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let c_widget = MultiSelectView::::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let c_widget = OnEventView::new(c_widget).with_id("current"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let top_widget = LinearLayout::horizontal().child( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut panes = LinearLayout::horizontal(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let h_panes = LinearLayout::vertical() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | siv, [INFO] [stdout] 83 | | vec_tabs, [INFO] [stdout] 84 | | focused_entry: 0, [INFO] [stdout] 85 | | focused_tab: 0, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 145 | let cb = s.select_up(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Some(EventResult::Consumed(Some(cb))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 149 | let cb = s.select_down(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Some(EventResult::Consumed(Some(cb))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn on_select(self, cb: F) -> Self [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | self.with(|s| s.set_on_select(cb)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn on_submit(self, cb: F) -> Self [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | self.with(|s| s.set_on_submit(cb)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 290 | pub fn item>(self, label: S, value: T) -> Self { [INFO] [stdout] | ---- -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | self.with(|s| s.add_item(label, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:313:19 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn with_all(self, iter: I) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | self.with(|s| s.add_all(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 425 | let cb = self.on_submit.clone().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | / self.selection() [INFO] [stdout] 429 | | .map(|v| Callback::from_fn(move |s| cb(s, &v))), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:429:44 [INFO] [stdout] | [INFO] [stdout] 425 | let cb = self.on_submit.clone().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | .map(|v| Callback::from_fn(move |s| cb(s, &v))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:515:13 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:516:22 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] 516 | .map(|v| Callback::from_fn(move |s| cb(s, &v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:516:44 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] 516 | .map(|v| Callback::from_fn(move |s| cb(s, &v))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:557:30 [INFO] [stdout] | [INFO] [stdout] 523 | let mut tree = MenuTree::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | let tree = Rc::new(tree); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | EventResult::with_cb(move |s| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 558 | | // The callback will want to work with a fresh Rc [INFO] [stdout] 559 | | let tree = Rc::clone(&tree); [INFO] [stdout] 560 | | // We'll relativise the absolute position, [INFO] [stdout] ... | [INFO] [stdout] 568 | | .add_layer_at(Position::parent(offset), MenuPopup::new(tree).focus(focus)); [INFO] [stdout] 569 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:596:19 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn item_str>(self, label: S) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 596 | self.with(|s| s.add_item_str(label)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:636:19 [INFO] [stdout] | [INFO] [stdout] 631 | pub fn with_all_str(self, iter: I) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | self.with(|s| s.add_all_str(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:746:20 [INFO] [stdout] | [INFO] [stdout] 743 | fn new(label: String, value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | value: Rc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `focused_tab` is never read [INFO] [stdout] --> src/application/app.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct App { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | focused_tab: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lll` (lib) due to 17 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut siv = Cursive::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let c_widget = MultiSelectView::::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let c_widget = OnEventView::new(c_widget).with_id("current"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let top_widget = LinearLayout::horizontal().child( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut panes = LinearLayout::horizontal(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let h_panes = LinearLayout::vertical() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | siv, [INFO] [stdout] 83 | | vec_tabs, [INFO] [stdout] 84 | | focused_entry: 0, [INFO] [stdout] 85 | | focused_tab: 0, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 145 | let cb = s.select_up(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Some(EventResult::Consumed(Some(cb))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application/app.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 149 | let cb = s.select_down(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Some(EventResult::Consumed(Some(cb))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:156:19 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn on_select(self, cb: F) -> Self [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | self.with(|s| s.set_on_select(cb)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn on_submit(self, cb: F) -> Self [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | self.with(|s| s.set_on_submit(cb)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 290 | pub fn item>(self, label: S, value: T) -> Self { [INFO] [stdout] | ---- -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | self.with(|s| s.add_item(label, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:313:19 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn with_all(self, iter: I) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | self.with(|s| s.add_all(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 425 | let cb = self.on_submit.clone().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | / self.selection() [INFO] [stdout] 429 | | .map(|v| Callback::from_fn(move |s| cb(s, &v))), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:429:44 [INFO] [stdout] | [INFO] [stdout] 425 | let cb = self.on_submit.clone().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | .map(|v| Callback::from_fn(move |s| cb(s, &v))), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:515:13 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:516:22 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] 516 | .map(|v| Callback::from_fn(move |s| cb(s, &v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:516:44 [INFO] [stdout] | [INFO] [stdout] 514 | self.on_select.clone().and_then(|cb| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | self.selection() [INFO] [stdout] 516 | .map(|v| Callback::from_fn(move |s| cb(s, &v))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:557:30 [INFO] [stdout] | [INFO] [stdout] 523 | let mut tree = MenuTree::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | let tree = Rc::new(tree); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | EventResult::with_cb(move |s| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 558 | | // The callback will want to work with a fresh Rc [INFO] [stdout] 559 | | let tree = Rc::clone(&tree); [INFO] [stdout] 560 | | // We'll relativise the absolute position, [INFO] [stdout] ... | [INFO] [stdout] 568 | | .add_layer_at(Position::parent(offset), MenuPopup::new(tree).focus(focus)); [INFO] [stdout] 569 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:596:19 [INFO] [stdout] | [INFO] [stdout] 595 | pub fn item_str>(self, label: S) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 596 | self.with(|s| s.add_item_str(label)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:636:19 [INFO] [stdout] | [INFO] [stdout] 631 | pub fn with_all_str(self, iter: I) -> Self [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | self.with(|s| s.add_all_str(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/multi_select.rs:746:20 [INFO] [stdout] | [INFO] [stdout] 743 | fn new(label: String, value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | value: Rc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lll` (lib test) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "fa9c08cbd1761c70fc63b5238742810a6f70b65f5237e0e6e8ae15a6c5dff29b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa9c08cbd1761c70fc63b5238742810a6f70b65f5237e0e6e8ae15a6c5dff29b", kill_on_drop: false }` [INFO] [stdout] fa9c08cbd1761c70fc63b5238742810a6f70b65f5237e0e6e8ae15a6c5dff29b