[INFO] fetching crate lium 0.1.2... [INFO] checking lium-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lium 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lium 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate lium 0.1.2 [INFO] finished tweaking crates.io crate lium 0.1.2 [INFO] tweaked toml for crates.io crate lium 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate lium 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72fbace58fefaabf2ef36e891b0f72f34990d55fe9983b96e702f43c2d4b3fec [INFO] running `Command { std: "docker" "start" "-a" "72fbace58fefaabf2ef36e891b0f72f34990d55fe9983b96e702f43c2d4b3fec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72fbace58fefaabf2ef36e891b0f72f34990d55fe9983b96e702f43c2d4b3fec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72fbace58fefaabf2ef36e891b0f72f34990d55fe9983b96e702f43c2d4b3fec", kill_on_drop: false }` [INFO] [stdout] 72fbace58fefaabf2ef36e891b0f72f34990d55fe9983b96e702f43c2d4b3fec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a146c8ff13671decfb280277e096f7b89dd2b80f96f11c7315d7cf82c75c48f [INFO] running `Command { std: "docker" "start" "-a" "3a146c8ff13671decfb280277e096f7b89dd2b80f96f11c7315d7cf82c75c48f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling rustix v0.37.25 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking parking v2.1.0 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling async-process v1.7.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking concurrent-queue v2.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking sharded-slab v0.1.6 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking macaddr v1.0.1 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking rayon-core v1.12.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking termion v2.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking retry v2.0.0 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking regex-macro v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking lium v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `result_option_inspect` has been stable since 1.76.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | #![feature(result_option_inspect)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `result_option_inspect` has been stable since 1.76.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | #![feature(result_option_inspect)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 71 | let file = self.file.lock().expect("lock failed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut file_lock = self.file.lock().expect("lock failed"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | match serde_json::from_str(&json) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let map = map.as_mut().unwrap(); [INFO] [stdout] 101 | Ok(map.get(key).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let map = map.as_mut().unwrap(); [INFO] [stdout] 126 | let mut file = self.file.lock().expect("lock failed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | file.sync_all().context("failed to sync backed file") [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 135 | let map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Ok((*map).clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chroot.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut cmd = async_process::Command::new("bash"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | cmd.spawn().context("exec_in_chroot_async failed") [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | write(gen_path_in_lium_dir(CONFIG_FILE_NAME)?, s.into_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | block_on(Self::from_ssh(&ssh, &Vec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:229:18 [INFO] [stdout] | [INFO] [stdout] 229 | block_on(Self::from_ssh(&ssh, &Vec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:611:34 [INFO] [stdout] | [INFO] [stdout] 608 | let cmd = self.ssh_cmd(None)?.spawn()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 611 | exit_status.exit_ok().or(Err(anyhow!( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 612 | | "Failed to establish ssh connection. code = {:?}", [INFO] [stdout] 613 | | exit_status.code() [INFO] [stdout] 614 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:265:8 [INFO] [stdout] | [INFO] [stdout] 264 | let paths = fs::read_dir("/sys/bus/usb/devices/").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | Ok(paths [INFO] [stdout] | ________^ [INFO] [stdout] 266 | | .flat_map(|usb_path| -> Result { [INFO] [stdout] 267 | | let usb_sysfs_path = usb_path?.path(); [INFO] [stdout] 268 | | let product = read_usb_attribute(&usb_sysfs_path, "product")?; [INFO] [stdout] ... | [INFO] [stdout] 300 | | } [INFO] [stdout] 301 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:533:13 [INFO] [stdout] | [INFO] [stdout] 533 | / RE_EC_VERSION [INFO] [stdout] 534 | | .captures(&output) [INFO] [stdout] 535 | | .map(|c| c["version"].trim().to_lowercase()) [INFO] [stdout] 536 | | .context(anyhow!("Failed to get EC version")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:555:13 [INFO] [stdout] | [INFO] [stdout] 555 | / RE_MAC_ADDR [INFO] [stdout] 556 | | .captures(output) [INFO] [stdout] 557 | | .map(|c| c["addr"].to_lowercase()) [INFO] [stdout] 558 | | .ok_or(anyhow!("macaddr not found in the output. retrying...")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:42:45 [INFO] [stdout] | [INFO] [stdout] 42 | let lines = child.stdout.take().map(|s| BufReader::new(s).lines()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:43:49 [INFO] [stdout] | [INFO] [stdout] 43 | let lines_err = child.stderr.take().map(|s| BufReader::new(s).lines()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 48 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / c.arg("-c") [INFO] [stdout] 55 | | .arg(cmd) [INFO] [stdout] 56 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 102 | let mut c = async_process::Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | / c.arg("-c") [INFO] [stdout] 109 | | .arg(cmd) [INFO] [stdout] 110 | | .stdout(Stdio::piped()) [INFO] [stdout] 111 | | .stderr(Stdio::piped()) [INFO] [stdout] 112 | | .spawn() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|s| std::io::BufReader::new(s).lines()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | .map(|s| std::io::BufReader::new(s).lines()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:222:24 [INFO] [stdout] | [INFO] [stdout] 213 | stdout_iter: IOut, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | stderr_iter: IErr, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | stdout_snd: std::sync::mpsc::SyncSender, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | stderr_snd: std::sync::mpsc::SyncSender, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 223 | | let _stdout_stderr_output_reader_span = [INFO] [stdout] 224 | | tracing::trace_span!("subprocess output reader").entered(); [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lium` (lib test) due to 20 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 71 | let file = self.file.lock().expect("lock failed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut file_lock = self.file.lock().expect("lock failed"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | match serde_json::from_str(&json) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let map = map.as_mut().unwrap(); [INFO] [stdout] 101 | Ok(map.get(key).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 124 | let mut map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let map = map.as_mut().unwrap(); [INFO] [stdout] 126 | let mut file = self.file.lock().expect("lock failed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | file.sync_all().context("failed to sync backed file") [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 135 | let map = self.map.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Ok((*map).clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chroot.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut cmd = async_process::Command::new("bash"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | cmd.spawn().context("exec_in_chroot_async failed") [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | write(gen_path_in_lium_dir(CONFIG_FILE_NAME)?, s.into_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | block_on(Self::from_ssh(&ssh, &Vec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:229:18 [INFO] [stdout] | [INFO] [stdout] 229 | block_on(Self::from_ssh(&ssh, &Vec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dut.rs:611:34 [INFO] [stdout] | [INFO] [stdout] 608 | let cmd = self.ssh_cmd(None)?.spawn()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 611 | exit_status.exit_ok().or(Err(anyhow!( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 612 | | "Failed to establish ssh connection. code = {:?}", [INFO] [stdout] 613 | | exit_status.code() [INFO] [stdout] 614 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:265:8 [INFO] [stdout] | [INFO] [stdout] 264 | let paths = fs::read_dir("/sys/bus/usb/devices/").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | Ok(paths [INFO] [stdout] | ________^ [INFO] [stdout] 266 | | .flat_map(|usb_path| -> Result { [INFO] [stdout] 267 | | let usb_sysfs_path = usb_path?.path(); [INFO] [stdout] 268 | | let product = read_usb_attribute(&usb_sysfs_path, "product")?; [INFO] [stdout] ... | [INFO] [stdout] 300 | | } [INFO] [stdout] 301 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:533:13 [INFO] [stdout] | [INFO] [stdout] 533 | / RE_EC_VERSION [INFO] [stdout] 534 | | .captures(&output) [INFO] [stdout] 535 | | .map(|c| c["version"].trim().to_lowercase()) [INFO] [stdout] 536 | | .context(anyhow!("Failed to get EC version")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/servo.rs:555:13 [INFO] [stdout] | [INFO] [stdout] 555 | / RE_MAC_ADDR [INFO] [stdout] 556 | | .captures(output) [INFO] [stdout] 557 | | .map(|c| c["addr"].to_lowercase()) [INFO] [stdout] 558 | | .ok_or(anyhow!("macaddr not found in the output. retrying...")) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:42:45 [INFO] [stdout] | [INFO] [stdout] 42 | let lines = child.stdout.take().map(|s| BufReader::new(s).lines()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:43:49 [INFO] [stdout] | [INFO] [stdout] 43 | let lines_err = child.stderr.take().map(|s| BufReader::new(s).lines()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 48 | let mut c = Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / c.arg("-c") [INFO] [stdout] 55 | | .arg(cmd) [INFO] [stdout] 56 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 102 | let mut c = async_process::Command::new("bash"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | / c.arg("-c") [INFO] [stdout] 109 | | .arg(cmd) [INFO] [stdout] 110 | | .stdout(Stdio::piped()) [INFO] [stdout] 111 | | .stderr(Stdio::piped()) [INFO] [stdout] 112 | | .spawn() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|s| std::io::BufReader::new(s).lines()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:171:18 [INFO] [stdout] | [INFO] [stdout] 171 | .map(|s| std::io::BufReader::new(s).lines()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/shell_helpers.rs:222:24 [INFO] [stdout] | [INFO] [stdout] 213 | stdout_iter: IOut, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | stderr_iter: IErr, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | stdout_snd: std::sync::mpsc::SyncSender, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | stderr_snd: std::sync::mpsc::SyncSender, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 223 | | let _stdout_stderr_output_reader_span = [INFO] [stdout] 224 | | tracing::trace_span!("subprocess output reader").entered(); [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lium` (lib) due to 20 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3a146c8ff13671decfb280277e096f7b89dd2b80f96f11c7315d7cf82c75c48f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a146c8ff13671decfb280277e096f7b89dd2b80f96f11c7315d7cf82c75c48f", kill_on_drop: false }` [INFO] [stdout] 3a146c8ff13671decfb280277e096f7b89dd2b80f96f11c7315d7cf82c75c48f