[INFO] fetching crate little-loadshedder 0.2.0... [INFO] checking little-loadshedder-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate little-loadshedder 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate little-loadshedder 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate little-loadshedder 0.2.0 [INFO] finished tweaking crates.io crate little-loadshedder 0.2.0 [INFO] tweaked toml for crates.io crate little-loadshedder 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate little-loadshedder 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f4c32a29afd1c5d2d3ec12cd78898dc28040a63b33662643d59e74374f39a5a [INFO] running `Command { std: "docker" "start" "-a" "7f4c32a29afd1c5d2d3ec12cd78898dc28040a63b33662643d59e74374f39a5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f4c32a29afd1c5d2d3ec12cd78898dc28040a63b33662643d59e74374f39a5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f4c32a29afd1c5d2d3ec12cd78898dc28040a63b33662643d59e74374f39a5a", kill_on_drop: false }` [INFO] [stdout] 7f4c32a29afd1c5d2d3ec12cd78898dc28040a63b33662643d59e74374f39a5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fdfa583c91628c615b15ef9caad3da084e1366676f2b045032062ba4e10e01ec [INFO] running `Command { std: "docker" "start" "-a" "fdfa583c91628c615b15ef9caad3da084e1366676f2b045032062ba4e10e01ec", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling cc v1.0.87 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking raw-cpuid v11.0.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling portable-atomic v0.3.20 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking metrics v0.22.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling metrics v0.20.1 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Checking quanta v0.12.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking metrics-util v0.16.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Compiling metrics-macros v0.6.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking little-loadshedder v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 257 | fn new(permit: OwnedSemaphorePermit, component: &'static str) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | permit: Some(permit), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 268 | fn forget(mut self) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | self.permit.take().unwrap().forget() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:19 [INFO] [stdout] | [INFO] [stdout] 317 | pub fn new(inner: Inner, ewma_param: f64, target: Duration) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 320 | conf: LoadShedConf::new(ewma_param, target.as_secs_f64()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:382:18 [INFO] [stdout] | [INFO] [stdout] 377 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 380 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | let mut conf = self.conf.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 383 | | let permit = match conf.start().await { [INFO] [stdout] 384 | | Ok(permit) => { [INFO] [stdout] 385 | | #[cfg(feature = "metrics")] [INFO] [stdout] ... | [INFO] [stdout] 400 | | Ok(LoadShedResponse::Inner(response?)) [INFO] [stdout] 401 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:16 [INFO] [stdout] | [INFO] [stdout] 377 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 380 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | let mut conf = self.conf.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | Box::pin(async move { [INFO] [stdout] 383 | let permit = match conf.start().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Ok(permit) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | let response = inner.oneshot(req).await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | conf.stop(start.elapsed(), permit); [INFO] [stdout] 400 | Ok(LoadShedResponse::Inner(response?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `little-loadshedder` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "fdfa583c91628c615b15ef9caad3da084e1366676f2b045032062ba4e10e01ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdfa583c91628c615b15ef9caad3da084e1366676f2b045032062ba4e10e01ec", kill_on_drop: false }` [INFO] [stdout] fdfa583c91628c615b15ef9caad3da084e1366676f2b045032062ba4e10e01ec