[INFO] fetching crate literate-crypto 0.0.3... [INFO] checking literate-crypto-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate literate-crypto 0.0.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate literate-crypto 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate literate-crypto 0.0.3 [INFO] finished tweaking crates.io crate literate-crypto 0.0.3 [INFO] tweaked toml for crates.io crate literate-crypto 0.0.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding pulldown-cmark v0.10.3 (latest: v0.12.0) [INFO] [stderr] Adding pulldown-cmark-escape v0.10.1 (latest: v0.11.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27fb347302a7e7711753c53187990e9bcf9c4f3df363a49250d05b6ab7db3509 [INFO] running `Command { std: "docker" "start" "-a" "27fb347302a7e7711753c53187990e9bcf9c4f3df363a49250d05b6ab7db3509", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27fb347302a7e7711753c53187990e9bcf9c4f3df363a49250d05b6ab7db3509", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27fb347302a7e7711753c53187990e9bcf9c4f3df363a49250d05b6ab7db3509", kill_on_drop: false }` [INFO] [stdout] 27fb347302a7e7711753c53187990e9bcf9c4f3df363a49250d05b6ab7db3509 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95f9285c080bd94ef09e0f3a853e0b211056fc1ca32c557df706467b3c25325d [INFO] running `Command { std: "docker" "start" "-a" "95f9285c080bd94ef09e0f3a853e0b211056fc1ca32c557df706467b3c25325d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling tinyvec v1.8.0 [INFO] [stderr] Compiling pulldown-cmark v0.10.3 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling getopts v0.2.21 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling pulldown-cmark-escape v0.10.1 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling url v2.5.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling docext v0.0.11 [INFO] [stderr] Checking literate-crypto v0.0.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stdout] warning: the feature `return_position_impl_trait_in_trait` has been stable since 1.75.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | #![feature(return_position_impl_trait_in_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `associated_type_bounds` has been stable since 1.79.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | #![feature(associated_type_bounds)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher/block/modes/ctr.rs:88:28 [INFO] [stdout] | [INFO] [stdout] 85 | key: Self::EncryptionKey, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | .encrypt(data, keystream(&self.enc, key, self.nonce)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher/block/modes/ctr.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 105 | key: Self::DecryptionKey, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | .decrypt(data, keystream(&self.enc, key, self.nonce)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher/block/modes/ctr.rs:119:77 [INFO] [stdout] | [INFO] [stdout] 113 | fn keystream(enc: &Enc, key: Enc::EncryptionKey, nonce: u64) -> impl Iterator + '_ [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | iter::successors(Some(nonce), |ctr| Some(ctr.wrapping_add(1))).flat_map(move |ctr| { [INFO] [stdout] | _____________________________________________________________________________^ [INFO] [stdout] 120 | | // Copy the counter bytes into a block and encrypt it. [INFO] [stdout] 121 | | let mut ctr_block = Enc::EncryptionBlock::default(); [INFO] [stdout] 122 | | ctr_block [INFO] [stdout] ... | [INFO] [stdout] 127 | | enc.encrypt(ctr_block, key.clone()).into_iter() [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cipher/block/modes/ctr.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn keystream(enc: &Enc, key: Enc::EncryptionKey, nonce: u64) -> impl Iterator + '_ [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let mut ctr_block = Enc::EncryptionBlock::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | enc.encrypt(ctr_block, key.clone()).into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash/merkledamgard/daviesmeyer.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 59 | fn compress(&self, state: Self::State, block: Self::Block) -> Self::State { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | self.step [INFO] [stdout] 61 | .step(state.clone(), self.enc.encrypt(state, block)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash/merkledamgard/daviesmeyer.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 59 | fn compress(&self, state: Self::State, block: Self::Block) -> Self::State { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | self.step [INFO] [stdout] 61 | .step(state.clone(), self.enc.encrypt(state, block)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey/ecc/schnorr.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(curve: C, hash: H, rng: R) -> Self { [INFO] [stdout] | -------- ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | rng: rng.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey/ecc/schnorr/multisig.rs:161:14 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn new(curve: C, hash: H, rng: R) -> Self { [INFO] [stdout] | -------- ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Self(Schnorr::new(curve, hash, rng)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey/ecc/schnorr/sag.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(curve: C, hash: H, rng: R) -> Self { [INFO] [stdout] | -------- ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | rng: rng.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/fortuna.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(entropy: Ent, enc: Enc, hash: H) -> Result { [INFO] [stdout] | ------------ -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | entropy, [INFO] [stdout] 53 | | ctr: Ctr::new(enc, 0)?, [INFO] [stdout] 54 | | hash, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/fortuna.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 81 | fn into_iter(mut self) -> Self::IntoIter { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let mut key = Enc::EncryptionKey::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | / iter::repeat_with(move || { [INFO] [stdout] 84 | | // Fetch random bytes from the source of entropy to use for reseeding. [INFO] [stdout] 85 | | let mut seed = [0; SEED_SIZE]; [INFO] [stdout] 86 | | self.entropy.get(&mut seed); [INFO] [stdout] ... | [INFO] [stdout] 95 | | self.ctr.encrypt(vec![0; RESEED_SIZE], key.clone()).unwrap() [INFO] [stdout] 96 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/fortuna.rs:95:52 [INFO] [stdout] | [INFO] [stdout] 81 | fn into_iter(mut self) -> Self::IntoIter { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let mut key = Enc::EncryptionKey::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | self.ctr.encrypt(vec![0; RESEED_SIZE], key.clone()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `literate-crypto` (lib) due to 13 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "95f9285c080bd94ef09e0f3a853e0b211056fc1ca32c557df706467b3c25325d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95f9285c080bd94ef09e0f3a853e0b211056fc1ca32c557df706467b3c25325d", kill_on_drop: false }` [INFO] [stdout] 95f9285c080bd94ef09e0f3a853e0b211056fc1ca32c557df706467b3c25325d