[INFO] fetching crate listload 0.1.0... [INFO] checking listload-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate listload 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate listload 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate listload 0.1.0 [INFO] finished tweaking crates.io crate listload 0.1.0 [INFO] tweaked toml for crates.io crate listload 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate listload 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51e73d109b6d5583227563758362e86092af9effbe282c0b489b77eaa547b302 [INFO] running `Command { std: "docker" "start" "-a" "51e73d109b6d5583227563758362e86092af9effbe282c0b489b77eaa547b302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51e73d109b6d5583227563758362e86092af9effbe282c0b489b77eaa547b302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51e73d109b6d5583227563758362e86092af9effbe282c0b489b77eaa547b302", kill_on_drop: false }` [INFO] [stdout] 51e73d109b6d5583227563758362e86092af9effbe282c0b489b77eaa547b302 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9595911fd51d46433e33ef70a97442e6d5cb255e7c9cce70fb873e79428c7d68 [INFO] running `Command { std: "docker" "start" "-a" "9595911fd51d46433e33ef70a97442e6d5cb255e7c9cce70fb873e79428c7d68", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustls v0.21.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Compiling serde_json v1.0.99 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rustls-pemfile v1.0.2 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking winnow v0.4.7 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Compiling indoc v2.0.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.8 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustls-webpki v0.100.1 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking webpki-roots v0.22.6 [INFO] [stderr] Checking clap v4.3.8 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking toml_edit v0.19.11 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking toml v0.7.5 [INFO] [stderr] Checking hyper-rustls v0.24.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking downloader v0.2.7 [INFO] [stderr] Checking listload v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `target` is never used [INFO] [stdout] --> src/persistent_state.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl PersistentState { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn target(&self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/target_list.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl TargetList { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 21 | pub fn name(&self) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `target` is never used [INFO] [stdout] --> src/persistent_state.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl PersistentState { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn target(&self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/target_list.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl TargetList { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 21 | pub fn name(&self) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:105:33 [INFO] [stdout] | [INFO] [stdout] 104 | ... .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | / ... fs::copy(&res.file_name, &target) [INFO] [stdout] 106 | | ... .map(|_| ()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:105:33 [INFO] [stdout] | [INFO] [stdout] 104 | ... .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | / ... fs::copy(&res.file_name, &target) [INFO] [stdout] 106 | | ... .map(|_| ()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent_state.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn read_from(reader: impl Read) -> anyhow::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | serde_json::from_reader(reader).context("failed to parse persistent state file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent_state.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn read_from(reader: impl Read) -> anyhow::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | serde_json::from_reader(reader).context("failed to parse persistent state file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent_state.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn save_to(&self, writer: impl Write) -> anyhow::Result<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | serde_json::to_writer(writer, &self).context("failed to write persistent state file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent_state.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn save_to(&self, writer: impl Write) -> anyhow::Result<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | serde_json::to_writer(writer, &self).context("failed to write persistent state file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target_list.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 112 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Ok(Self { inner, file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target_list.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 112 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Ok(Self { inner, file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `listload` (bin "listload") due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `listload` (bin "listload" test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9595911fd51d46433e33ef70a97442e6d5cb255e7c9cce70fb873e79428c7d68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9595911fd51d46433e33ef70a97442e6d5cb255e7c9cce70fb873e79428c7d68", kill_on_drop: false }` [INFO] [stdout] 9595911fd51d46433e33ef70a97442e6d5cb255e7c9cce70fb873e79428c7d68