[INFO] fetching crate linux_l6470 0.1.0... [INFO] checking linux_l6470-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linux_l6470 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate linux_l6470 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linux_l6470 0.1.0 [INFO] finished tweaking crates.io crate linux_l6470 0.1.0 [INFO] tweaked toml for crates.io crate linux_l6470 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.3.3 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding nix v0.6.0 (latest: v0.29.0) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding rustc_version v0.1.7 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.1.20 (latest: v1.0.23) [INFO] [stderr] Adding spidev v0.3.0 (latest: v0.6.0) [INFO] [stderr] Adding sysfs_gpio v0.5.4 (latest: v0.6.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 203816247b764dbac563fe5799bdddfd1a9ea2f5737b62599500684994a91cb1 [INFO] running `Command { std: "docker" "start" "-a" "203816247b764dbac563fe5799bdddfd1a9ea2f5737b62599500684994a91cb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "203816247b764dbac563fe5799bdddfd1a9ea2f5737b62599500684994a91cb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "203816247b764dbac563fe5799bdddfd1a9ea2f5737b62599500684994a91cb1", kill_on_drop: false }` [INFO] [stdout] 203816247b764dbac563fe5799bdddfd1a9ea2f5737b62599500684994a91cb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf1bdd7803028537765e85e24b44e01dde5873cf74bb053319ec373700d3dcd0 [INFO] running `Command { std: "docker" "start" "-a" "bf1bdd7803028537765e85e24b44e01dde5873cf74bb053319ec373700d3dcd0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking bitflags v0.3.3 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking spidev v0.3.0 [INFO] [stderr] Checking sysfs_gpio v0.5.4 [INFO] [stderr] Checking linux_l6470 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | try!(self.spi.transfer(&mut transfer)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | try!(self.spi.transfer(&mut transfer)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tick_ns` [INFO] [stdout] --> src/lib.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let tick_ns = 250; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tick_ns` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | self.transfer(&buf[0..self.daisy_chain as usize]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 178 | let _ = self.transfer(&buf[0..self.daisy_chain as usize]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new>(path: P) -> L6470Connector { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | L6470Connector { [INFO] [stdout] 250 | spi_bus: Spidev::open(path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn build(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let mut spi = self.spi_bus?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | spi.configure(&self.spi_options)?; [INFO] [stdout] 271 | Ok(L6470{ [INFO] [stdout] | ____________^ [INFO] [stdout] 272 | | spi: spi, [INFO] [stdout] 273 | | daisy_chain: self.daisy_chain, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tick_ns` [INFO] [stdout] --> src/lib.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let tick_ns = 250; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tick_ns` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linux_l6470` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | self.transfer(&buf[0..self.daisy_chain as usize]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 178 | let _ = self.transfer(&buf[0..self.daisy_chain as usize]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new>(path: P) -> L6470Connector { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | L6470Connector { [INFO] [stdout] 250 | spi_bus: Spidev::open(path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn build(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let mut spi = self.spi_bus?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | spi.configure(&self.spi_options)?; [INFO] [stdout] 271 | Ok(L6470{ [INFO] [stdout] | ____________^ [INFO] [stdout] 272 | | spi: spi, [INFO] [stdout] 273 | | daisy_chain: self.daisy_chain, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linux_l6470` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bf1bdd7803028537765e85e24b44e01dde5873cf74bb053319ec373700d3dcd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf1bdd7803028537765e85e24b44e01dde5873cf74bb053319ec373700d3dcd0", kill_on_drop: false }` [INFO] [stdout] bf1bdd7803028537765e85e24b44e01dde5873cf74bb053319ec373700d3dcd0