[INFO] fetching crate linux-video-core 0.1.1... [INFO] checking linux-video-core-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linux-video-core 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate linux-video-core 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linux-video-core 0.1.1 [INFO] finished tweaking crates.io crate linux-video-core 0.1.1 [INFO] tweaked toml for crates.io crate linux-video-core 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding dcv-color-primitives v0.5.4 (latest: v0.6.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding parse-display v0.8.2 (latest: v0.10.0) [INFO] [stderr] Adding parse-display-derive v0.8.2 (latest: v0.10.0) [INFO] [stderr] Adding regex-syntax v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding structmeta v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding structmeta-derive v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ab2be3efdc3c6d4bee4edce032bd26fa525bee73cc7b657e1474b9f723aef75 [INFO] running `Command { std: "docker" "start" "-a" "8ab2be3efdc3c6d4bee4edce032bd26fa525bee73cc7b657e1474b9f723aef75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ab2be3efdc3c6d4bee4edce032bd26fa525bee73cc7b657e1474b9f723aef75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ab2be3efdc3c6d4bee4edce032bd26fa525bee73cc7b657e1474b9f723aef75", kill_on_drop: false }` [INFO] [stdout] 8ab2be3efdc3c6d4bee4edce032bd26fa525bee73cc7b657e1474b9f723aef75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed0065e7c9da2312f15f12505d4133276c8298138fbbe34190617c1a76c657f1 [INFO] running `Command { std: "docker" "start" "-a" "ed0065e7c9da2312f15f12505d4133276c8298138fbbe34190617c1a76c657f1", kill_on_drop: false }` [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling structmeta-derive v0.2.0 [INFO] [stderr] Compiling bitmask-enum v2.2.4 [INFO] [stderr] Compiling structmeta v0.2.0 [INFO] [stderr] Compiling parse-display-derive v0.8.2 [INFO] [stderr] Checking parse-display v0.8.2 [INFO] [stderr] Checking linux-video-core v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `capability::*` [INFO] [stdout] --> src/impls.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub use capability::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `formats::*` [INFO] [stdout] --> src/impls.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use formats::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Weak` [INFO] [stdout] --> src/safe_ref.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | rc::{Rc as Ref, Weak}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `capability::*` [INFO] [stdout] --> src/impls.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub use capability::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `formats::*` [INFO] [stdout] --> src/impls.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use formats::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Weak` [INFO] [stdout] --> src/safe_ref.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | rc::{Rc as Ref, Weak}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/types.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use enums::*; [INFO] [stdout] | ^^^^^^^^ the name `Vp8LoopFilter` in the type namespace is first re-exported here [INFO] [stdout] ... [INFO] [stdout] 13 | pub use structs::*; [INFO] [stdout] | ---------- but the name `Vp8LoopFilter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/types.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use enums::*; [INFO] [stdout] | ^^^^^^^^ the name `Vp8LoopFilter` in the type namespace is first re-exported here [INFO] [stdout] ... [INFO] [stdout] 13 | pub use structs::*; [INFO] [stdout] | ---------- but the name `Vp8LoopFilter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls/buffer.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 306 | let mut buffers = Vec::with_capacity(count as _); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(QueueData { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | buffers, [INFO] [stdout] 318 | | dequeued: Mut::new(VecDeque::with_capacity(count as _)), [INFO] [stdout] 319 | | on: AtomicBool::new(false), [INFO] [stdout] ... | [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/safe_ref.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self(Cell::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private/internals.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn map(self, mapper: impl FnOnce(T) -> R) -> Internal { [INFO] [stdout] | ---- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | mapper(self.into_inner()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls/buffer.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 306 | let mut buffers = Vec::with_capacity(count as _); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(QueueData { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | buffers, [INFO] [stdout] 318 | | dequeued: Mut::new(VecDeque::with_capacity(count as _)), [INFO] [stdout] 319 | | on: AtomicBool::new(false), [INFO] [stdout] ... | [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/safe_ref.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self(Cell::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linux-video-core` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private/internals.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn map(self, mapper: impl FnOnce(T) -> R) -> Internal { [INFO] [stdout] | ---- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | mapper(self.into_inner()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linux-video-core` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ed0065e7c9da2312f15f12505d4133276c8298138fbbe34190617c1a76c657f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed0065e7c9da2312f15f12505d4133276c8298138fbbe34190617c1a76c657f1", kill_on_drop: false }` [INFO] [stdout] ed0065e7c9da2312f15f12505d4133276c8298138fbbe34190617c1a76c657f1