[INFO] fetching crate linux-drm 0.2.0... [INFO] checking linux-drm-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linux-drm 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate linux-drm 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linux-drm 0.2.0 [INFO] finished tweaking crates.io crate linux-drm 0.2.0 [INFO] tweaked toml for crates.io crate linux-drm 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate linux-drm 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64dfb073efc558d465d54ed46859dcb343cfa1fe41e2e186263dcd81b4c8b8d1 [INFO] running `Command { std: "docker" "start" "-a" "64dfb073efc558d465d54ed46859dcb343cfa1fe41e2e186263dcd81b4c8b8d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64dfb073efc558d465d54ed46859dcb343cfa1fe41e2e186263dcd81b4c8b8d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64dfb073efc558d465d54ed46859dcb343cfa1fe41e2e186263dcd81b4c8b8d1", kill_on_drop: false }` [INFO] [stdout] 64dfb073efc558d465d54ed46859dcb343cfa1fe41e2e186263dcd81b4c8b8d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c360e9f87be735dedc3a9339186b7c7d6d674c3e5e81796fceea58c1de1c902 [INFO] running `Command { std: "docker" "start" "-a" "5c360e9f87be735dedc3a9339186b7c7d6d674c3e5e81796fceea58c1de1c902", kill_on_drop: false }` [INFO] [stderr] Compiling linux-unsafe v0.11.0 [INFO] [stderr] Checking linux-io v0.9.1 [INFO] [stderr] Checking linux-drm v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub unsafe fn from_file_unchecked(f: linux_io::File) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let f: linux_io::File = unsafe { f.to_device(ioctl::DrmCardDevice) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self { f: Arc::new(f) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub unsafe fn from_file_unchecked(f: linux_io::File) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let f: linux_io::File = unsafe { f.to_device(ioctl::DrmCardDevice) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self { f: Arc::new(f) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:680:12 [INFO] [stdout] | [INFO] [stdout] 643 | let mut cleanup_db = util::Cleanup::new(|| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | let mut cleanup_fb = util::Cleanup::new(|| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | Ok(modeset::DumbBuffer { [INFO] [stdout] | ____________^ [INFO] [stdout] 681 | | width: buf_req.width, [INFO] [stdout] 682 | | height: buf_req.height, [INFO] [stdout] 683 | | bpp: buf_req.bpp, [INFO] [stdout] ... | [INFO] [stdout] 689 | | file: Arc::downgrade(&self.f), [INFO] [stdout] 690 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:680:12 [INFO] [stdout] | [INFO] [stdout] 643 | let mut cleanup_db = util::Cleanup::new(|| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | let mut cleanup_fb = util::Cleanup::new(|| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | Ok(modeset::DumbBuffer { [INFO] [stdout] | ____________^ [INFO] [stdout] 681 | | width: buf_req.width, [INFO] [stdout] 682 | | height: buf_req.height, [INFO] [stdout] 683 | | bpp: buf_req.bpp, [INFO] [stdout] ... | [INFO] [stdout] 689 | | file: Arc::downgrade(&self.f), [INFO] [stdout] 690 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:739:12 [INFO] [stdout] | [INFO] [stdout] 738 | let raws = self.read_events_raw(buf)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 739 | Ok(raws.map(|raw| event::DrmEvent::from_raw(raw))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:739:12 [INFO] [stdout] | [INFO] [stdout] 738 | let raws = self.read_events_raw(buf)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 739 | Ok(raws.map(|raw| event::DrmEvent::from_raw(raw))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 750 | pub fn take_file(self) -> linux_io::result::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 751 | Arc::into_inner(self.f).ok_or(linux_io::result::EBUSY) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 750 | pub fn take_file(self) -> linux_io::result::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 751 | Arc::into_inner(self.f).ok_or(linux_io::result::EBUSY) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modeset/props.rs:376:28 [INFO] [stdout] | [INFO] [stdout] 375 | fn into_raw_property_value(self) -> (u64, Option>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | (self.id() as u64, Some(Box::new(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modeset/props.rs:376:28 [INFO] [stdout] | [INFO] [stdout] 375 | fn into_raw_property_value(self) -> (u64, Option>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | (self.id() as u64, Some(Box::new(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { f: Some(f) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { f: Some(f) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linux-drm` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `linux-drm` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5c360e9f87be735dedc3a9339186b7c7d6d674c3e5e81796fceea58c1de1c902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c360e9f87be735dedc3a9339186b7c7d6d674c3e5e81796fceea58c1de1c902", kill_on_drop: false }` [INFO] [stdout] 5c360e9f87be735dedc3a9339186b7c7d6d674c3e5e81796fceea58c1de1c902