[INFO] fetching crate lintje 0.11.3... [INFO] checking lintje-0.11.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lintje 0.11.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lintje 0.11.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate lintje 0.11.3 [INFO] finished tweaking crates.io crate lintje 0.11.3 [INFO] tweaked toml for crates.io crate lintje 0.11.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate lintje 0.11.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c3498a2899b04ab6c4de01f57505ea49ba06cf7df13fefbc6ab1a3ca45f9b85 [INFO] running `Command { std: "docker" "start" "-a" "2c3498a2899b04ab6c4de01f57505ea49ba06cf7df13fefbc6ab1a3ca45f9b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c3498a2899b04ab6c4de01f57505ea49ba06cf7df13fefbc6ab1a3ca45f9b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c3498a2899b04ab6c4de01f57505ea49ba06cf7df13fefbc6ab1a3ca45f9b85", kill_on_drop: false }` [INFO] [stdout] 2c3498a2899b04ab6c4de01f57505ea49ba06cf7df13fefbc6ab1a3ca45f9b85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e59cd120636bd5e50826158ad4c246126a43589c06e10c6c62c574f3123550e [INFO] running `Command { std: "docker" "start" "-a" "0e59cd120636bd5e50826158ad4c246126a43589c06e10c6c62c574f3123550e", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking termtree v0.2.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling lintje v0.11.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking predicates-tree v1.0.4 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking predicates v2.1.0 [INFO] [stderr] Checking assert_cmd v1.0.8 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:115:11 [INFO] [stdout] | [INFO] [stdout] 113 | let mut command = Command::new(cmd); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | command.args(args); [INFO] [stdout] 115 | match command.output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 139 | let command = Command::new(cmd) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut child = match command { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(handler) => handler, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let mut child_stdin = child.stdin.take().expect("Lintje failed to open stdin"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | match child.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lintje` (bin "lintje") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:115:11 [INFO] [stdout] | [INFO] [stdout] 113 | let mut command = Command::new(cmd); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | command.args(args); [INFO] [stdout] 115 | match command.output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 139 | let command = Command::new(cmd) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut child = match command { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(handler) => handler, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let mut child_stdin = child.stdin.take().expect("Lintje failed to open stdin"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | match child.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatter.rs:316:15 [INFO] [stdout] | [INFO] [stdout] 314 | let bufwtr = BufferWriter::stdout(ColorChoice::Never); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | let mut out = bufwtr.buffer(); [INFO] [stdout] 316 | match formatted_commit_issue(&mut out, commit, issue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatter.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 323 | let bufwtr = BufferWriter::stdout(ColorChoice::Always); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | let mut out = bufwtr.buffer(); [INFO] [stdout] 325 | match formatted_commit_issue(&mut out, commit, issue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatter.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 332 | let bufwtr = BufferWriter::stdout(ColorChoice::Never); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 333 | let mut out = bufwtr.buffer(); [INFO] [stdout] 334 | match formatted_branch_issue(&mut out, branch, issue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatter.rs:343:15 [INFO] [stdout] | [INFO] [stdout] 341 | let bufwtr = BufferWriter::stdout(ColorChoice::Always); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let mut out = bufwtr.buffer(); [INFO] [stdout] 343 | match formatted_branch_issue(&mut out, branch, issue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 33 | let bufwtr = BufferWriter::stdout(ColorChoice::Never); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut out = bufwtr.buffer(); [INFO] [stdout] 35 | match formatted_context_real(&mut out, issue) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lintje` (bin "lintje" test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0e59cd120636bd5e50826158ad4c246126a43589c06e10c6c62c574f3123550e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e59cd120636bd5e50826158ad4c246126a43589c06e10c6c62c574f3123550e", kill_on_drop: false }` [INFO] [stdout] 0e59cd120636bd5e50826158ad4c246126a43589c06e10c6c62c574f3123550e