[INFO] fetching crate linkstore 1.0.2... [INFO] checking linkstore-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linkstore 1.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate linkstore 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linkstore 1.0.2 [INFO] finished tweaking crates.io crate linkstore 1.0.2 [INFO] tweaked toml for crates.io crate linkstore 1.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding goblin v0.6.1 (latest: v0.8.2) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding ouroboros v0.15.6 (latest: v0.18.4) [INFO] [stderr] Adding ouroboros_macro v0.15.6 (latest: v0.18.4) [INFO] [stderr] Adding scroll v0.11.0 (latest: v0.12.0) [INFO] [stderr] Adding scroll_derive v0.11.1 (latest: v0.12.0) [INFO] [stderr] Adding sealed v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82c7a429f4d145c9a1dafa7fbb1561c1706d6016c98f279af9b087c77f2802a8 [INFO] running `Command { std: "docker" "start" "-a" "82c7a429f4d145c9a1dafa7fbb1561c1706d6016c98f279af9b087c77f2802a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82c7a429f4d145c9a1dafa7fbb1561c1706d6016c98f279af9b087c77f2802a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82c7a429f4d145c9a1dafa7fbb1561c1706d6016c98f279af9b087c77f2802a8", kill_on_drop: false }` [INFO] [stdout] 82c7a429f4d145c9a1dafa7fbb1561c1706d6016c98f279af9b087c77f2802a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf885f17dbc3b6b571995d1381589fc38b5a8ad8cca68a7dde7244d72f8b7a79 [INFO] running `Command { std: "docker" "start" "-a" "cf885f17dbc3b6b571995d1381589fc38b5a8ad8cca68a7dde7244d72f8b7a79", kill_on_drop: false }` [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling scroll_derive v0.11.1 [INFO] [stderr] Checking scroll v0.11.0 [INFO] [stderr] Checking goblin v0.6.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling ouroboros_macro v0.15.6 [INFO] [stderr] Compiling sealed v0.4.0 [INFO] [stderr] Checking ouroboros v0.15.6 [INFO] [stderr] Checking linkstore v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub const fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self(UnsafeCell::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embed/embedder/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn open_binary>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(std::fs::OpenOptions::new().truncate(false).write(true).read(true).open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embed/embedder/formats/macho.rs:13:60 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|(section, _)| filter_map_linkstore_section(section.name().ok()?.as_bytes(), section)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub const fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self(UnsafeCell::new(val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embed/embedder/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn open_binary>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(std::fs::OpenOptions::new().truncate(false).write(true).read(true).open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embed/embedder/formats/macho.rs:13:60 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|(section, _)| filter_map_linkstore_section(section.name().ok()?.as_bytes(), section)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linkstore` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `linkstore` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "cf885f17dbc3b6b571995d1381589fc38b5a8ad8cca68a7dde7244d72f8b7a79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf885f17dbc3b6b571995d1381589fc38b5a8ad8cca68a7dde7244d72f8b7a79", kill_on_drop: false }` [INFO] [stdout] cf885f17dbc3b6b571995d1381589fc38b5a8ad8cca68a7dde7244d72f8b7a79