[INFO] fetching crate linfb 0.2.1... [INFO] checking linfb-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linfb 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate linfb 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linfb 0.2.1 [INFO] finished tweaking crates.io crate linfb 0.2.1 [INFO] tweaked toml for crates.io crate linfb 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate linfb 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f37812fce4d4fcb8f35b46884e0df25c39d6cde139f05bb4a0c11281bb3b3da3 [INFO] running `Command { std: "docker" "start" "-a" "f37812fce4d4fcb8f35b46884e0df25c39d6cde139f05bb4a0c11281bb3b3da3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f37812fce4d4fcb8f35b46884e0df25c39d6cde139f05bb4a0c11281bb3b3da3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37812fce4d4fcb8f35b46884e0df25c39d6cde139f05bb4a0c11281bb3b3da3", kill_on_drop: false }` [INFO] [stdout] f37812fce4d4fcb8f35b46884e0df25c39d6cde139f05bb4a0c11281bb3b3da3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db1a0578d3638f33a855e92cc16a14b7ddcc52681110abba88a2c0292c1018fe [INFO] running `Command { std: "docker" "start" "-a" "db1a0578d3638f33a855e92cc16a14b7ddcc52681110abba88a2c0292c1018fe", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling pkg-config v0.3.16 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling cmake v0.1.42 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling servo-fontconfig-sys v4.0.7 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking stb_truetype v0.3.0 [INFO] [stderr] Checking downcast-rs v1.0.4 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling servo-freetype-sys v4.0.5 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking png v0.15.0 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking servo-fontconfig v0.4.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking font-loader v0.8.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking rusttype v0.8.1 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking linfb v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 98 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let framebuffer = unsafe { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | screen, [INFO] [stdout] 122 | | framebuffer, [INFO] [stdout] 123 | | screen_info, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:139:40 [INFO] [stdout] | [INFO] [stdout] 137 | fn at(self, x: usize, y: usize) -> PositionedShape [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | where Self: Sized + 'static { [INFO] [stdout] 139 | PositionedShape { x, y, shape: Box::new(self) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn new(x: usize, y: usize, shape: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Self { x, y, shape: Box::new(shape) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/text.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | .filter(|c| self.font.glyph(*c).standalone().get_data().and_then(|g| Some(g.id != 0)).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/text.rs:216:26 [INFO] [stdout] | [INFO] [stdout] 216 | &new_row[width - row_len..].copy_from_slice(&row[..row_len]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 216 | let _ = &new_row[width - row_len..].copy_from_slice(&row[..row_len]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/text.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | &new_row[offset..row_len + offset].copy_from_slice(&row[..row_len]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 228 | let _ = &new_row[offset..row_len + offset].copy_from_slice(&row[..row_len]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfb` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 98 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let framebuffer = unsafe { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | screen, [INFO] [stdout] 122 | | framebuffer, [INFO] [stdout] 123 | | screen_info, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:139:40 [INFO] [stdout] | [INFO] [stdout] 137 | fn at(self, x: usize, y: usize) -> PositionedShape [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | where Self: Sized + 'static { [INFO] [stdout] 139 | PositionedShape { x, y, shape: Box::new(self) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn new(x: usize, y: usize, shape: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Self { x, y, shape: Box::new(shape) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/text.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | .filter(|c| self.font.glyph(*c).standalone().get_data().and_then(|g| Some(g.id != 0)).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/text.rs:216:26 [INFO] [stdout] | [INFO] [stdout] 216 | &new_row[width - row_len..].copy_from_slice(&row[..row_len]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 216 | let _ = &new_row[width - row_len..].copy_from_slice(&row[..row_len]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/text.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | &new_row[offset..row_len + offset].copy_from_slice(&row[..row_len]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 228 | let _ = &new_row[offset..row_len + offset].copy_from_slice(&row[..row_len]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfb` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "db1a0578d3638f33a855e92cc16a14b7ddcc52681110abba88a2c0292c1018fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db1a0578d3638f33a855e92cc16a14b7ddcc52681110abba88a2c0292c1018fe", kill_on_drop: false }` [INFO] [stdout] db1a0578d3638f33a855e92cc16a14b7ddcc52681110abba88a2c0292c1018fe