[INFO] fetching crate linfa-reduction 0.7.0... [INFO] checking linfa-reduction-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linfa-reduction 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate linfa-reduction 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linfa-reduction 0.7.0 [INFO] finished tweaking crates.io crate linfa-reduction 0.7.0 [INFO] tweaked toml for crates.io crate linfa-reduction 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate linfa-reduction 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ad8ca1fe4296d6a3a8b09b9c2b5652799cbf170f875e3ba366ab40ae636c045 [INFO] running `Command { std: "docker" "start" "-a" "8ad8ca1fe4296d6a3a8b09b9c2b5652799cbf170f875e3ba366ab40ae636c045", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ad8ca1fe4296d6a3a8b09b9c2b5652799cbf170f875e3ba366ab40ae636c045", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ad8ca1fe4296d6a3a8b09b9c2b5652799cbf170f875e3ba366ab40ae636c045", kill_on_drop: false }` [INFO] [stdout] 8ad8ca1fe4296d6a3a8b09b9c2b5652799cbf170f875e3ba366ab40ae636c045 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d24f41f5eeb625bf296e7e48a55110ac1f366614155350adffa6eee77e0aea1 [INFO] running `Command { std: "docker" "start" "-a" "0d24f41f5eeb625bf296e7e48a55110ac1f366614155350adffa6eee77e0aea1", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling linfa v0.7.0 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking noisy_float v0.2.0 [INFO] [stderr] Checking kdtree v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling pest v2.7.4 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Checking sprs v0.11.1 [INFO] [stderr] Checking ndarray-stats v0.5.1 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stderr] Checking linfa-linalg v0.1.0 [INFO] [stderr] Checking ndarray-csv v0.5.1 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Checking py_literal v0.4.0 [INFO] [stderr] Checking ndarray-npy v0.8.1 [INFO] [stderr] Checking linfa-nn v0.7.0 [INFO] [stderr] Checking linfa-datasets v0.7.0 [INFO] [stderr] Checking linfa-kernel v0.7.0 [INFO] [stderr] Checking linfa-reduction v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pca.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 89 | let mean = x.mean_axis(Axis(0)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let x = x - &mean; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let result = TruncatedSvd::new_with_rng(x, Order::Largest, SmallRng::seed_from_u64(42)) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let (_, sigma, mut v_t) = result.values_vectors(); [INFO] [stdout] | ----- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let sigma = sigma.mapv(|x| x.max(1e-8)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Pca { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | embedding: v_t, [INFO] [stdout] 116 | | sigma, [INFO] [stdout] 117 | | mean, [INFO] [stdout] 118 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pca.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 203 | fn transform(&self, ds: DatasetBase, T>) -> DatasetBase, T> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let DatasetBase { [INFO] [stdout] 205 | records, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | targets, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | weights, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let mut new_records = self.default_target(&records); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | DatasetBase::new(new_records, targets).with_weights(weights) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfa-reduction` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pca.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 89 | let mean = x.mean_axis(Axis(0)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let x = x - &mean; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let result = TruncatedSvd::new_with_rng(x, Order::Largest, SmallRng::seed_from_u64(42)) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let (_, sigma, mut v_t) = result.values_vectors(); [INFO] [stdout] | ----- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let sigma = sigma.mapv(|x| x.max(1e-8)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Pca { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | embedding: v_t, [INFO] [stdout] 116 | | sigma, [INFO] [stdout] 117 | | mean, [INFO] [stdout] 118 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pca.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 203 | fn transform(&self, ds: DatasetBase, T>) -> DatasetBase, T> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let DatasetBase { [INFO] [stdout] 205 | records, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | targets, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | weights, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let mut new_records = self.default_target(&records); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | DatasetBase::new(new_records, targets).with_weights(weights) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfa-reduction` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "0d24f41f5eeb625bf296e7e48a55110ac1f366614155350adffa6eee77e0aea1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d24f41f5eeb625bf296e7e48a55110ac1f366614155350adffa6eee77e0aea1", kill_on_drop: false }` [INFO] [stdout] 0d24f41f5eeb625bf296e7e48a55110ac1f366614155350adffa6eee77e0aea1