[INFO] fetching crate linfa-elasticnet 0.7.0... [INFO] checking linfa-elasticnet-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate linfa-elasticnet 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate linfa-elasticnet 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate linfa-elasticnet 0.7.0 [INFO] finished tweaking crates.io crate linfa-elasticnet 0.7.0 [INFO] tweaked toml for crates.io crate linfa-elasticnet 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate linfa-elasticnet 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fc6ff605b00f433f05921c3486fbfa4d656ff5631b5a5bfa732b0f613560e7c [INFO] running `Command { std: "docker" "start" "-a" "7fc6ff605b00f433f05921c3486fbfa4d656ff5631b5a5bfa732b0f613560e7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fc6ff605b00f433f05921c3486fbfa4d656ff5631b5a5bfa732b0f613560e7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fc6ff605b00f433f05921c3486fbfa4d656ff5631b5a5bfa732b0f613560e7c", kill_on_drop: false }` [INFO] [stdout] 7fc6ff605b00f433f05921c3486fbfa4d656ff5631b5a5bfa732b0f613560e7c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca96bc8bf638676169021fbcdc12ce69e208211ab07cfbee97d8f005d069d9a7 [INFO] running `Command { std: "docker" "start" "-a" "ca96bc8bf638676169021fbcdc12ce69e208211ab07cfbee97d8f005d069d9a7", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling linfa v0.7.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking sprs v0.11.1 [INFO] [stderr] Checking linfa-linalg v0.1.0 [INFO] [stderr] Checking ndarray-csv v0.5.1 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stderr] Checking linfa-datasets v0.7.0 [INFO] [stderr] Checking linfa-elasticnet v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 46 | let (intercept, y) = compute_intercept(self.with_intercept(), target); [INFO] [stdout] | --------- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let (hyperplane, duality_gap, n_steps) = coordinate_descent( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let y_est = dataset.records().dot(&hyperplane) + intercept; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let variance = variance_params(dataset, y_est.view()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(ElasticNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | hyperplane, [INFO] [stdout] 64 | | intercept, [INFO] [stdout] 65 | | duality_gap, [INFO] [stdout] 66 | | n_steps, [INFO] [stdout] 67 | | variance, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 92 | let (intercept, y) = compute_intercept(self.with_intercept(), targets); [INFO] [stdout] | --------- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | let (hyperplane, duality_gap, n_steps) = block_coordinate_descent( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let y_est = dataset.records().dot(&hyperplane) + &intercept; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let variance = variance_params(dataset, y_est.view()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Ok(MultiTaskElasticNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | hyperplane, [INFO] [stdout] 110 | | intercept, [INFO] [stdout] 111 | | duality_gap, [INFO] [stdout] 112 | | n_steps, [INFO] [stdout] 113 | | variance, [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:503:23 [INFO] [stdout] | [INFO] [stdout] 499 | let ds2 = ds.records().t().dot(ds.records()).with_lapack(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 503 | let inv_cov = (|| ds2.qr_into()?.inverse())(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfa-elasticnet` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 46 | let (intercept, y) = compute_intercept(self.with_intercept(), target); [INFO] [stdout] | --------- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let (hyperplane, duality_gap, n_steps) = coordinate_descent( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let y_est = dataset.records().dot(&hyperplane) + intercept; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let variance = variance_params(dataset, y_est.view()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(ElasticNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | hyperplane, [INFO] [stdout] 64 | | intercept, [INFO] [stdout] 65 | | duality_gap, [INFO] [stdout] 66 | | n_steps, [INFO] [stdout] 67 | | variance, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 92 | let (intercept, y) = compute_intercept(self.with_intercept(), targets); [INFO] [stdout] | --------- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | let (hyperplane, duality_gap, n_steps) = block_coordinate_descent( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let y_est = dataset.records().dot(&hyperplane) + &intercept; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let variance = variance_params(dataset, y_est.view()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Ok(MultiTaskElasticNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | hyperplane, [INFO] [stdout] 110 | | intercept, [INFO] [stdout] 111 | | duality_gap, [INFO] [stdout] 112 | | n_steps, [INFO] [stdout] 113 | | variance, [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:503:23 [INFO] [stdout] | [INFO] [stdout] 499 | let ds2 = ds.records().t().dot(ds.records()).with_lapack(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 503 | let inv_cov = (|| ds2.qr_into()?.inverse())(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `linfa-elasticnet` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ca96bc8bf638676169021fbcdc12ce69e208211ab07cfbee97d8f005d069d9a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca96bc8bf638676169021fbcdc12ce69e208211ab07cfbee97d8f005d069d9a7", kill_on_drop: false }` [INFO] [stdout] ca96bc8bf638676169021fbcdc12ce69e208211ab07cfbee97d8f005d069d9a7