[INFO] fetching crate line_cardinality 1.0.2... [INFO] checking line_cardinality-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate line_cardinality 1.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate line_cardinality 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate line_cardinality 1.0.2 [INFO] finished tweaking crates.io crate line_cardinality 1.0.2 [INFO] tweaked toml for crates.io crate line_cardinality 1.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48e85932e00a490cae6ba1d259e4a51a540e11b2dbc5721c2de65f0c4b63312b [INFO] running `Command { std: "docker" "start" "-a" "48e85932e00a490cae6ba1d259e4a51a540e11b2dbc5721c2de65f0c4b63312b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48e85932e00a490cae6ba1d259e4a51a540e11b2dbc5721c2de65f0c4b63312b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48e85932e00a490cae6ba1d259e4a51a540e11b2dbc5721c2de65f0c4b63312b", kill_on_drop: false }` [INFO] [stdout] 48e85932e00a490cae6ba1d259e4a51a540e11b2dbc5721c2de65f0c4b63312b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9674da62af666aae507bdf15bd95c158362ee384daae492899dc823260005024 [INFO] running `Command { std: "docker" "start" "-a" "9674da62af666aae507bdf15bd95c158362ee384daae492899dc823260005024", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking line_cardinality v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `EmitLines` [INFO] [stdout] --> src/count_unique_impl/hyperloglog.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::{CountUnique, EmitLines, Error}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 132 | fn count_unique_in_read(&mut self, mut reader: T) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | / reader.for_byte_line(|line| { [INFO] [stdout] 134 | | self.count_line(line); [INFO] [stdout] 135 | | Ok(true) [INFO] [stdout] 136 | | }).map_err(|e| Error::io_static("failed to read from buffer", e)) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/hashing.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn with_line_mapper_and_capacity(line_mapper: M, capacity: usize) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | HashingLineCounter { [INFO] [stdout] 73 | map: HashMap::with_capacity_and_hasher(capacity, init_hasher_state()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/hashing.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 201 | fn into_vec(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | self.map.into_keys().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/hashing.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 216 | fn to_report_vec(self) -> Vec<(Vec, C)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | self.map.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/hyperloglog.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn with_line_mapper(line_mapper: M) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Self::with_line_mapper_and_capacity(line_mapper, DEFAULT_SIZE).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/hyperloglog.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn with_line_mapper_and_capacity(line_mapper: M, size: usize) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let SizeInfo { bits, shift_bits, mask } = check_size(size)?; [INFO] [stdout] 105 | Ok(HyperLogLog { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | random_state: init_hasher_state(), [INFO] [stdout] 107 | | size, [INFO] [stdout] 108 | | bits, [INFO] [stdout] ... | [INFO] [stdout] 113 | | line_mapper, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/result.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn io_static(message: &'static str, cause: io::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | cause: Cause::Io(cause), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/count_unique_impl/result.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn io(message: String, cause: io::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | cause: Cause::Io(cause), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `line_cardinality` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9674da62af666aae507bdf15bd95c158362ee384daae492899dc823260005024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9674da62af666aae507bdf15bd95c158362ee384daae492899dc823260005024", kill_on_drop: false }` [INFO] [stdout] 9674da62af666aae507bdf15bd95c158362ee384daae492899dc823260005024