[INFO] fetching crate limit_read 0.2.0... [INFO] checking limit_read-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate limit_read 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate limit_read 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate limit_read 0.2.0 [INFO] finished tweaking crates.io crate limit_read 0.2.0 [INFO] tweaked toml for crates.io crate limit_read 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c7066835b43b63323b47ff6fbedf54fec4e46000b0620892aab9c54b46d14da [INFO] running `Command { std: "docker" "start" "-a" "3c7066835b43b63323b47ff6fbedf54fec4e46000b0620892aab9c54b46d14da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c7066835b43b63323b47ff6fbedf54fec4e46000b0620892aab9c54b46d14da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c7066835b43b63323b47ff6fbedf54fec4e46000b0620892aab9c54b46d14da", kill_on_drop: false }` [INFO] [stdout] 3c7066835b43b63323b47ff6fbedf54fec4e46000b0620892aab9c54b46d14da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ca504cceaee9c8176a00ed353dadc4af8df4bb48f2645512c96076e45d3b50a [INFO] running `Command { std: "docker" "start" "-a" "7ca504cceaee9c8176a00ed353dadc4af8df4bb48f2645512c96076e45d3b50a", kill_on_drop: false }` [INFO] [stderr] Checking limit_read v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused return value of `Result::::is_err` that must be used [INFO] [stdout] --> src/lib.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | / buf_reader [INFO] [stdout] 195 | | .read_until_lim(';' as u8, &mut buf, &short_lim) [INFO] [stdout] 196 | | .is_err(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is err, consider `.unwrap_err()` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 194 | let _ = buf_reader [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Result::::is_err` that must be used [INFO] [stdout] --> src/lib.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | buf_reader.read_line_lim(&mut buf, &short_lim).is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is err, consider `.unwrap_err()` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 215 | let _ = buf_reader.read_line_lim(&mut buf, &short_lim).is_err(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:242:11 [INFO] [stdout] | [INFO] [stdout] 229 | let buf_reader = BufReader::new(sample.as_slice()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut split_iter = buf_reader.split_lim(';' as u8, short_lim); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | match split_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:272:11 [INFO] [stdout] | [INFO] [stdout] 259 | let buf_reader = BufReader::new(sample.as_slice()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let mut line_iter = buf_reader.lines_lim(short_lim); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match line_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `limit_read` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7ca504cceaee9c8176a00ed353dadc4af8df4bb48f2645512c96076e45d3b50a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ca504cceaee9c8176a00ed353dadc4af8df4bb48f2645512c96076e45d3b50a", kill_on_drop: false }` [INFO] [stdout] 7ca504cceaee9c8176a00ed353dadc4af8df4bb48f2645512c96076e45d3b50a