[INFO] fetching crate lightning-wire-msgs-derive-base 0.2.6... [INFO] checking lightning-wire-msgs-derive-base-0.2.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lightning-wire-msgs-derive-base 0.2.6 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lightning-wire-msgs-derive-base 0.2.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning-wire-msgs-derive-base 0.2.6 [INFO] finished tweaking crates.io crate lightning-wire-msgs-derive-base 0.2.6 [INFO] tweaked toml for crates.io crate lightning-wire-msgs-derive-base 0.2.6 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2365593a7dcfa1fa18e870904aaff5c9feacd61fc2fc4839c6224363baa1af8e [INFO] running `Command { std: "docker" "start" "-a" "2365593a7dcfa1fa18e870904aaff5c9feacd61fc2fc4839c6224363baa1af8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2365593a7dcfa1fa18e870904aaff5c9feacd61fc2fc4839c6224363baa1af8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2365593a7dcfa1fa18e870904aaff5c9feacd61fc2fc4839c6224363baa1af8e", kill_on_drop: false }` [INFO] [stdout] 2365593a7dcfa1fa18e870904aaff5c9feacd61fc2fc4839c6224363baa1af8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 337c4f87b5d27bf66a99541549d104bcbc006dec205ad9e69d3a27d5dff2a1a7 [INFO] running `Command { std: "docker" "start" "-a" "337c4f87b5d27bf66a99541549d104bcbc006dec205ad9e69d3a27d5dff2a1a7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking lightning-wire-msgs-derive-base v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wire_msg.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | ... (match a.args.first().expect("tlv value must be Option") { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 179 | ... }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 ~ match a.args.first().expect("tlv value must be Option") { [INFO] [stdout] 177 | syn::GenericArgument::Type(t) => t.clone(), [INFO] [stdout] 178 | _ => panic!("tlv value must be Option"), [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wire_msg.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | ... (match a.args.first().expect("tlv value must be Option") { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 179 | ... }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 ~ match a.args.first().expect("tlv value must be Option") { [INFO] [stdout] 177 | syn::GenericArgument::Type(t) => t.clone(), [INFO] [stdout] 178 | _ => panic!("tlv value must be Option"), [INFO] [stdout] 179 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | .filter_map(|a| match a.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | .map(|id| syn::Member::Named(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:143:39 [INFO] [stdout] | [INFO] [stdout] 143 | .filter_map(|a| match a.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-wire-msgs-derive-base` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | .filter_map(|a| match a.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | .map(|id| syn::Member::Named(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire_msg.rs:143:39 [INFO] [stdout] | [INFO] [stdout] 143 | .filter_map(|a| match a.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-wire-msgs-derive-base` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "337c4f87b5d27bf66a99541549d104bcbc006dec205ad9e69d3a27d5dff2a1a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "337c4f87b5d27bf66a99541549d104bcbc006dec205ad9e69d3a27d5dff2a1a7", kill_on_drop: false }` [INFO] [stdout] 337c4f87b5d27bf66a99541549d104bcbc006dec205ad9e69d3a27d5dff2a1a7