[INFO] fetching crate lightning-net-tokio 0.0.124-rc1... [INFO] checking lightning-net-tokio-0.0.124-rc1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lightning-net-tokio 0.0.124-rc1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate lightning-net-tokio 0.0.124-rc1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning-net-tokio 0.0.124-rc1 [INFO] finished tweaking crates.io crate lightning-net-tokio 0.0.124-rc1 [INFO] tweaked toml for crates.io crate lightning-net-tokio 0.0.124-rc1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoinconsensus v0.105.0+25.1 (latest: v0.106.0+26.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f534a60c86ee5b19493113ae45d598451c8539e1b50382eeb46937a59f3ab993 [INFO] running `Command { std: "docker" "start" "-a" "f534a60c86ee5b19493113ae45d598451c8539e1b50382eeb46937a59f3ab993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f534a60c86ee5b19493113ae45d598451c8539e1b50382eeb46937a59f3ab993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f534a60c86ee5b19493113ae45d598451c8539e1b50382eeb46937a59f3ab993", kill_on_drop: false }` [INFO] [stdout] f534a60c86ee5b19493113ae45d598451c8539e1b50382eeb46937a59f3ab993 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ee0c75c878a4d35ff913c6468ef3b28d7eb66a2af3e57f8d0e3fb7081102b0b [INFO] running `Command { std: "docker" "start" "-a" "1ee0c75c878a4d35ff913c6468ef3b28d7eb66a2af3e57f8d0e3fb7081102b0b", kill_on_drop: false }` [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling bitcoin-internals v0.3.0 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Compiling bitcoinconsensus v0.105.0+25.1 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling bitcoin v0.32.2 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Checking bitcoin-units v0.1.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking base58ck v0.1.0 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking lightning-types v0.1.0-rc1 [INFO] [stderr] Checking lightning-invoice v0.32.0-rc1 [INFO] [stderr] Checking lightning v0.0.124-rc1 [INFO] [stderr] Checking lightning-net-tokio v0.0.124-rc1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `splicing` [INFO] [stdout] --> src/lib.rs:747:9 [INFO] [stdout] | [INFO] [stdout] 747 | #[cfg(splicing)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(splicing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(splicing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `splicing` [INFO] [stdout] --> src/lib.rs:749:9 [INFO] [stdout] | [INFO] [stdout] 749 | #[cfg(splicing)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(splicing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(splicing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `splicing` [INFO] [stdout] --> src/lib.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 751 | #[cfg(splicing)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(splicing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(splicing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:470:68 [INFO] [stdout] | [INFO] [stdout] 470 | let connect_fut = async { TcpStream::connect(&addr).await.map(|s| s.into_std().unwrap()) }; [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-net-tokio` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:470:68 [INFO] [stdout] | [INFO] [stdout] 470 | let connect_fut = async { TcpStream::connect(&addr).await.map(|s| s.into_std().unwrap()) }; [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:944:77 [INFO] [stdout] | [INFO] [stdout] 933 | let conn_a = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | let manager_reference = Arc::clone(&a_manager); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 944 | tokio::spawn(async move { super::setup_inbound(manager_reference, conn_a).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:945:77 [INFO] [stdout] | [INFO] [stdout] 924 | let a_manager = Arc::new(PeerManager::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 937 | let conn_b = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 945 | tokio::spawn(async move { super::setup_outbound(a_manager, b_pub, conn_b).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-net-tokio` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1ee0c75c878a4d35ff913c6468ef3b28d7eb66a2af3e57f8d0e3fb7081102b0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ee0c75c878a4d35ff913c6468ef3b28d7eb66a2af3e57f8d0e3fb7081102b0b", kill_on_drop: false }` [INFO] [stdout] 1ee0c75c878a4d35ff913c6468ef3b28d7eb66a2af3e57f8d0e3fb7081102b0b