[INFO] fetching crate lightning-background-processor 0.0.124-rc1... [INFO] checking lightning-background-processor-0.0.124-rc1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lightning-background-processor 0.0.124-rc1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lightning-background-processor 0.0.124-rc1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning-background-processor 0.0.124-rc1 [INFO] finished tweaking crates.io crate lightning-background-processor 0.0.124-rc1 [INFO] tweaked toml for crates.io crate lightning-background-processor 0.0.124-rc1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoinconsensus v0.105.0+25.1 (latest: v0.106.0+26.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9953f443344b168e97f727670644186bcfbffe0169d82cd8ea103c010984490 [INFO] running `Command { std: "docker" "start" "-a" "e9953f443344b168e97f727670644186bcfbffe0169d82cd8ea103c010984490", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9953f443344b168e97f727670644186bcfbffe0169d82cd8ea103c010984490", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9953f443344b168e97f727670644186bcfbffe0169d82cd8ea103c010984490", kill_on_drop: false }` [INFO] [stdout] e9953f443344b168e97f727670644186bcfbffe0169d82cd8ea103c010984490 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d9ecdcc1811d4498216a2092be41a698f09e0d25c03560354fd86062a78a0b0 [INFO] running `Command { std: "docker" "start" "-a" "2d9ecdcc1811d4498216a2092be41a698f09e0d25c03560354fd86062a78a0b0", kill_on_drop: false }` [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling bitcoin-internals v0.3.0 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Compiling bitcoinconsensus v0.105.0+25.1 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling bitcoin v0.32.2 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking bitcoin-units v0.1.2 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Checking base58ck v0.1.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking lightning-types v0.1.0-rc1 [INFO] [stderr] Checking lightning-invoice v0.32.0-rc1 [INFO] [stderr] Checking lightning v0.0.124-rc1 [INFO] [stderr] Checking lightning-rapid-gossip-sync v0.0.124-rc1 [INFO] [stderr] Checking lightning-persister v0.0.124-rc1 [INFO] [stderr] Checking lightning-background-processor v0.0.124-rc1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `c_bindings` [INFO] [stdout] --> src/lib.rs:1126:8 [INFO] [stdout] | [INFO] [stdout] 1126 | #[cfg(c_bindings)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(c_bindings)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(c_bindings)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `c_bindings` [INFO] [stdout] --> src/lib.rs:1128:12 [INFO] [stdout] | [INFO] [stdout] 1128 | #[cfg(not(c_bindings))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(c_bindings)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(c_bindings)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `c_bindings` [INFO] [stdout] --> src/lib.rs:1497:8 [INFO] [stdout] | [INFO] [stdout] 1497 | #[cfg(c_bindings)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(c_bindings)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(c_bindings)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1008:57 [INFO] [stdout] | [INFO] [stdout] 927 | persister: PS, event_handler: EH, chain_monitor: M, channel_manager: CM, [INFO] [stdout] | ------------- ----------------- ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 928 | onion_messenger: Option, gossip_sync: GossipSync, peer_manager: PM, [INFO] [stdout] | --------------------------- ------------------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 929 | logger: L, scorer: Option, [INFO] [stdout] | --------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | let stop_thread = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 944 | let stop_thread_clone = stop_thread.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | let handle = thread::spawn(move || -> Result<(), std::io::Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1008 | Self { stop_thread: stop_thread_clone, thread_handle: Some(handle) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-background-processor` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1008:57 [INFO] [stdout] | [INFO] [stdout] 927 | persister: PS, event_handler: EH, chain_monitor: M, channel_manager: CM, [INFO] [stdout] | ------------- ----------------- ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 928 | onion_messenger: Option, gossip_sync: GossipSync, peer_manager: PM, [INFO] [stdout] | --------------------------- ------------------------------------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 929 | logger: L, scorer: Option, [INFO] [stdout] | --------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | let stop_thread = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 944 | let stop_thread_clone = stop_thread.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | let handle = thread::spawn(move || -> Result<(), std::io::Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1008 | Self { stop_thread: stop_thread_clone, thread_handle: Some(handle) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1290:33 [INFO] [stdout] | [INFO] [stdout] 1287 | let kv_store = FilesystemStore::new(data_dir); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1290 | graph_persistence_notifier: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1302:39 [INFO] [stdout] | [INFO] [stdout] 1301 | fn with_graph_persistence_notifier(self, sender: SyncSender<()>) -> Self { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1302 | Self { graph_persistence_notifier: Some(sender), ..self } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1964:9 [INFO] [stdout] | [INFO] [stdout] 1945 | let (_, nodes) = create_nodes(2, "test_persist_error"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1949 | let persister = Arc::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1953 | let bg_processor = BackgroundProcessor::start( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1964 | match bg_processor.join() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2033:9 [INFO] [stdout] | [INFO] [stdout] 2016 | let (_, nodes) = create_nodes(2, "test_persist_network_graph_error"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2017 | let data_dir = nodes[0].kv_store.get_data_dir(); [INFO] [stdout] 2018 | let persister = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2021 | let bg_processor = BackgroundProcessor::start( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2033 | match bg_processor.stop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2062:9 [INFO] [stdout] | [INFO] [stdout] 2045 | let (_, nodes) = create_nodes(2, "test_persist_scorer_error"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2046 | let data_dir = nodes[0].kv_store.get_data_dir(); [INFO] [stdout] 2047 | let persister = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2050 | let bg_processor = BackgroundProcessor::start( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2062 | match bg_processor.stop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning-background-processor` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2d9ecdcc1811d4498216a2092be41a698f09e0d25c03560354fd86062a78a0b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d9ecdcc1811d4498216a2092be41a698f09e0d25c03560354fd86062a78a0b0", kill_on_drop: false }` [INFO] [stdout] 2d9ecdcc1811d4498216a2092be41a698f09e0d25c03560354fd86062a78a0b0