[INFO] fetching crate light-cache 0.2.6... [INFO] checking light-cache-0.2.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate light-cache 0.2.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate light-cache 0.2.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate light-cache 0.2.6 [INFO] finished tweaking crates.io crate light-cache 0.2.6 [INFO] tweaked toml for crates.io crate light-cache 0.2.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 138 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding triomphe v0.1.11 (latest: v0.1.13) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e1cfcbd4bfed6323ac15305f6283ac3bae38ded5bd061b907737c6585ca626c [INFO] running `Command { std: "docker" "start" "-a" "2e1cfcbd4bfed6323ac15305f6283ac3bae38ded5bd061b907737c6585ca626c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e1cfcbd4bfed6323ac15305f6283ac3bae38ded5bd061b907737c6585ca626c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e1cfcbd4bfed6323ac15305f6283ac3bae38ded5bd061b907737c6585ca626c", kill_on_drop: false }` [INFO] [stdout] 2e1cfcbd4bfed6323ac15305f6283ac3bae38ded5bd061b907737c6585ca626c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85c3b129d6f894031627b9ad3136c1d02867bf88bc757776338bb8daed5ff937 [INFO] running `Command { std: "docker" "start" "-a" "85c3b129d6f894031627b9ad3136c1d02867bf88bc757776338bb8daed5ff937", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling moka v0.12.8 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking quick_cache v0.6.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking priority-queue v2.1.0 [INFO] [stderr] Checking light-cache v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn from_parts(policy: P, hasher: S) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | LightCache { [INFO] [stdout] 70 | inner: Arc::new(LightCacheInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 71 | | map: LightMap::with_hasher(hasher), [INFO] [stdout] 72 | | policy, [INFO] [stdout] 73 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn from_parts_with_capacity(policy: P, hasher: S, capacity: usize) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | LightCache { [INFO] [stdout] 79 | inner: Arc::new(LightCacheInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 80 | | map: LightMap::with_capacity_and_hasher(capacity, hasher), [INFO] [stdout] 81 | | policy, [INFO] [stdout] 82 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:246:54 [INFO] [stdout] | [INFO] [stdout] 239 | fn get_or_insert_race_inner(&self, key: K, init: F) -> GetOrInsertRace [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | GetOrInsertRace::new(self, shard, hash, key, init()) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:261:57 [INFO] [stdout] | [INFO] [stdout] 253 | init: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | GetOrTryInsertRace::new(self, shard, hash, key, init()) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/get_or_insert.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | init: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | inner: GetOrInsertFutureInner::Waiting { [INFO] [stdout] | ____________________^ [INFO] [stdout] 43 | | shard, [INFO] [stdout] 44 | | hash, [INFO] [stdout] 45 | | key, [INFO] [stdout] 46 | | init: Some(init), [INFO] [stdout] 47 | | joined: false, [INFO] [stdout] 48 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/get_or_insert.rs:107:20 [INFO] [stdout] | [INFO] [stdout] 103 | init: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | inner: GetOrInsertFutureInner::Waiting { [INFO] [stdout] | ____________________^ [INFO] [stdout] 108 | | shard, [INFO] [stdout] 109 | | hash, [INFO] [stdout] 110 | | key, [INFO] [stdout] 111 | | init: Some(init), [INFO] [stdout] 112 | | joined: false, [INFO] [stdout] 113 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/get_or_insert_race.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | fut: Fut, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | inner: RaceInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 43 | | cache, [INFO] [stdout] 44 | | shard, [INFO] [stdout] 45 | | joined: false, [INFO] [stdout] ... | [INFO] [stdout] 48 | | fut, [INFO] [stdout] 49 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/get_or_insert_race.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 104 | fut: Fut, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | inner: RaceInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | cache, [INFO] [stdout] 110 | | shard, [INFO] [stdout] 111 | | joined: false, [INFO] [stdout] ... | [INFO] [stdout] 114 | | fut, [INFO] [stdout] 115 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | self.shards.iter().map(|s| s.table.read().len()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 170 | let mut table = self.table.write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | [INFO] [stdout] 172 | / table [INFO] [stdout] 173 | | .remove_entry(hash, |e| eq_key(key, &e.key)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/builder.rs:52:34 [INFO] [stdout] | [INFO] [stdout] 52 | waiters: Mutex::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/builder.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | table: RwLock::new(RawTable::with_capacity(per_shard)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/builder.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | waiters: Mutex::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map/builder.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | table: RwLock::new(RawTable::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/policy/lru.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | expiring: ttl.map(|ttl| (ttl, PriorityQueue::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refresh.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(refresh: R, ttl: Duration) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | cache: LightCache::from_parts(TtlPolicy::new(ttl), Default::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `light-cache` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "85c3b129d6f894031627b9ad3136c1d02867bf88bc757776338bb8daed5ff937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85c3b129d6f894031627b9ad3136c1d02867bf88bc757776338bb8daed5ff937", kill_on_drop: false }` [INFO] [stdout] 85c3b129d6f894031627b9ad3136c1d02867bf88bc757776338bb8daed5ff937