[INFO] fetching crate libzfs 0.6.16... [INFO] checking libzfs-0.6.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libzfs 0.6.16 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate libzfs 0.6.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libzfs 0.6.16 [INFO] finished tweaking crates.io crate libzfs 0.6.16 [INFO] tweaked toml for crates.io crate libzfs 0.6.16 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.51.1 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cexpr v0.3.6 (latest: v0.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clang-sys v0.28.1 (latest: v1.8.1) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding libloading v0.5.2 (latest: v0.8.5) [INFO] [stderr] Adding nom v4.2.3 (latest: v7.1.3) [INFO] [stderr] Adding nvpair-sys v0.1.0 (latest: v0.4.0) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding version_check v0.1.5 (latest: v0.9.5) [INFO] [stderr] Adding which v3.1.1 (latest: v6.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7a0a095d20b0a79831406eba2a55167d2136c9c3042884efd44994d560a7df0 [INFO] running `Command { std: "docker" "start" "-a" "b7a0a095d20b0a79831406eba2a55167d2136c9c3042884efd44994d560a7df0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7a0a095d20b0a79831406eba2a55167d2136c9c3042884efd44994d560a7df0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7a0a095d20b0a79831406eba2a55167d2136c9c3042884efd44994d560a7df0", kill_on_drop: false }` [INFO] [stdout] b7a0a095d20b0a79831406eba2a55167d2136c9c3042884efd44994d560a7df0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e97665b2eb3ff93c9ddbb645a81f38d2bebd913a39021f7c2a57eab3f59f249 [INFO] running `Command { std: "docker" "start" "-a" "5e97665b2eb3ff93c9ddbb645a81f38d2bebd913a39021f7c2a57eab3f59f249", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling bindgen v0.51.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling nvpair-sys v0.1.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Checking cstr-argument v0.1.2 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling clang-sys v0.28.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling cexpr v0.3.6 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling env_logger v0.6.2 [INFO] [stderr] Checking libzfs-types v0.1.2 [INFO] [stderr] Compiling libzfs-sys v0.5.11 [INFO] [stderr] Checking libzfs v0.6.16 (/opt/rustwide/workdir) [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/nvpair.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: S` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/nvpair.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut NvListRef` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/zfs.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn props(&self) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - pub fn props(&self) -> Result<(Vec)> { [INFO] [stdout] 60 + pub fn props(&self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/nvpair.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: S` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/nvpair.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut NvListRef` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/zfs.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn props(&self) -> Result<(Vec)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - pub fn props(&self) -> Result<(Vec)> { [INFO] [stdout] 60 + pub fn props(&self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 265 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:302:24 [INFO] [stdout] | [INFO] [stdout] 302 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:332:24 [INFO] [stdout] | [INFO] [stdout] 332 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 265 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:302:24 [INFO] [stdout] | [INFO] [stdout] 302 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/nvpair.rs:332:24 [INFO] [stdout] | [INFO] [stdout] 332 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `insert` is never used [INFO] [stdout] --> src/nvpair.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait NvEncode { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `*mut i8` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: raw pointers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u64` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u32` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:302:19 [INFO] [stdout] | [INFO] [stdout] 302 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u32` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:332:19 [INFO] [stdout] | [INFO] [stdout] 332 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdev.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | state.to_owned().into_string().map_err(LibZfsError::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zfs.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|v| ZProp { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | name: x.user_prop().to_owned().into_string().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zfs.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|v| ZProp { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | name: x.user_prop().to_owned().into_string().unwrap(), [INFO] [stdout] 72 | value: v.into_string().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libzfs.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|x| x.disable_datasets().and_then(|_| x.export())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 71 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | / libzfs [INFO] [stdout] 74 | | .pool_by_name(&pool_name) [INFO] [stdout] 75 | | .ok_or_else(|| LibZfsError::PoolNotFound(Some(pool_name.to_string()), None)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 82 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | / libzfs [INFO] [stdout] 85 | | .pool_by_name(&pool_name) [INFO] [stdout] 86 | | .filter(|x| x.guid() == guid) [INFO] [stdout] 87 | | .ok_or_else(|| LibZfsError::PoolNotFound(Some(pool_name.to_string()), Some(guid))) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 94 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | / libzfs [INFO] [stdout] 97 | | .dataset_by_name(&ds_name) [INFO] [stdout] 98 | | .ok_or_else(|| LibZfsError::ZfsNotFound(ds_name.to_string())) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 105 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | / libzfs [INFO] [stdout] 107 | | .get_imported_pools()? [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libzfs` (lib) due to 9 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `insert` is never used [INFO] [stdout] --> src/nvpair.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait NvEncode { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 13 | fn insert(&self, S, &mut NvListRef) -> io::Result<()>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `*mut i8` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: raw pointers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u64` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | n = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u32` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:302:19 [INFO] [stdout] | [INFO] [stdout] 302 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `u32` does not permit being left uninitialized [INFO] [stdout] --> src/nvpair.rs:332:19 [INFO] [stdout] | [INFO] [stdout] 332 | len = mem::uninitialized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdev.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | state.to_owned().into_string().map_err(LibZfsError::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zfs.rs:71:31 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|v| ZProp { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | name: x.user_prop().to_owned().into_string().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zfs.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|v| ZProp { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | name: x.user_prop().to_owned().into_string().unwrap(), [INFO] [stdout] 72 | value: v.into_string().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zpool.rs:205:27 [INFO] [stdout] | [INFO] [stdout] 205 | .find(|x| x.name() == CString::new(name).unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zpool.rs:205:39 [INFO] [stdout] | [INFO] [stdout] 205 | .find(|x| x.name() == CString::new(name).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libzfs.rs:102:22 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|x| x.disable_datasets().and_then(|_| x.export())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 71 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | / libzfs [INFO] [stdout] 74 | | .pool_by_name(&pool_name) [INFO] [stdout] 75 | | .ok_or_else(|| LibZfsError::PoolNotFound(Some(pool_name.to_string()), None)) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 82 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | / libzfs [INFO] [stdout] 85 | | .pool_by_name(&pool_name) [INFO] [stdout] 86 | | .filter(|x| x.guid() == guid) [INFO] [stdout] 87 | | .ok_or_else(|| LibZfsError::PoolNotFound(Some(pool_name.to_string()), Some(guid))) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 94 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | / libzfs [INFO] [stdout] 97 | | .dataset_by_name(&ds_name) [INFO] [stdout] 98 | | .ok_or_else(|| LibZfsError::ZfsNotFound(ds_name.to_string())) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 105 | let mut libzfs = Libzfs::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | / libzfs [INFO] [stdout] 107 | | .get_imported_pools()? [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libzfs` (lib test) due to 11 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5e97665b2eb3ff93c9ddbb645a81f38d2bebd913a39021f7c2a57eab3f59f249", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e97665b2eb3ff93c9ddbb645a81f38d2bebd913a39021f7c2a57eab3f59f249", kill_on_drop: false }` [INFO] [stdout] 5e97665b2eb3ff93c9ddbb645a81f38d2bebd913a39021f7c2a57eab3f59f249