[INFO] fetching crate libwaysip 0.2.3... [INFO] checking libwaysip-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libwaysip 0.2.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate libwaysip 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libwaysip 0.2.3 [INFO] finished tweaking crates.io crate libwaysip 0.2.3 [INFO] tweaked toml for crates.io crate libwaysip 0.2.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate libwaysip 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69e5b39a477efd5cbba8960b6bedcaa1395ad8548bb69237a02fe8be9455661b [INFO] running `Command { std: "docker" "start" "-a" "69e5b39a477efd5cbba8960b6bedcaa1395ad8548bb69237a02fe8be9455661b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69e5b39a477efd5cbba8960b6bedcaa1395ad8548bb69237a02fe8be9455661b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69e5b39a477efd5cbba8960b6bedcaa1395ad8548bb69237a02fe8be9455661b", kill_on_drop: false }` [INFO] [stdout] 69e5b39a477efd5cbba8960b6bedcaa1395ad8548bb69237a02fe8be9455661b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 186016f2aa9a84d03095c7664146adb7252afe6396f238e0b6686d476ce35b48 [INFO] running `Command { std: "docker" "start" "-a" "186016f2aa9a84d03095c7664146adb7252afe6396f238e0b6686d476ce35b48", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling target-lexicon v0.12.14 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling gio v0.19.5 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling cfg-expr v0.15.7 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Compiling serde_spanned v0.6.5 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling toml v0.8.2 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling glib-macros v0.19.7 [INFO] [stderr] Compiling glib-sys v0.19.5 [INFO] [stderr] Compiling gobject-sys v0.19.5 [INFO] [stderr] Compiling gio-sys v0.19.5 [INFO] [stderr] Compiling pango-sys v0.19.5 [INFO] [stderr] Compiling cairo-sys-rs v0.19.2 [INFO] [stderr] Compiling pangocairo-sys v0.19.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking glib v0.19.7 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking cairo-rs v0.19.4 [INFO] [stderr] Checking pango v0.19.5 [INFO] [stderr] Checking pangocairo v0.19.2 [INFO] [stderr] Checking libwaysip v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:10 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cursor_theme = CursorTheme::load(connection, shm.clone(), 23).ok()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Some(cursor?[0].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:8 [INFO] [stdout] | [INFO] [stdout] 45 | waysip_connection: Option, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let (connection, globals) = match waysip_connection { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | globals, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let connection = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Connection::connect_to_env().map_err(|e| WaySipError::InitFailed(e.to_string()))?; [INFO] [stdout] 56 | let (globals, _) = registry_queue_init::(&connection) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut state = state::WaysipState::new(selection_type); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let mut event_queue = connection.new_event_queue::(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let qh = event_queue.handle(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let wmcompositer = globals [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let cursor_manager = globals [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let shm = globals [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let cursor_buffer = get_cursor_buffer(&connection, &shm); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let xdg_output_manager = globals [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let layer_shell = globals [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(state.area_info()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 226 | let output = self.outputs[self.current_screen].clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let info = &self.zxdg_outputs[self.current_screen]; [INFO] [stdout] 228 | Some(AreaInfo { [INFO] [stdout] | ______________^ [INFO] [stdout] 229 | | start_x, [INFO] [stdout] 230 | | start_y, [INFO] [stdout] 231 | | end_x, [INFO] [stdout] 232 | | end_y, [INFO] [stdout] 233 | | screen_info: info.get_screen_info(output), [INFO] [stdout] 234 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:10 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cursor_theme = CursorTheme::load(connection, shm.clone(), 23).ok()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Some(cursor?[0].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:8 [INFO] [stdout] | [INFO] [stdout] 45 | waysip_connection: Option, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let (connection, globals) = match waysip_connection { [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | globals, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let connection = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Connection::connect_to_env().map_err(|e| WaySipError::InitFailed(e.to_string()))?; [INFO] [stdout] 56 | let (globals, _) = registry_queue_init::(&connection) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut state = state::WaysipState::new(selection_type); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let mut event_queue = connection.new_event_queue::(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let qh = event_queue.handle(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let wmcompositer = globals [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let cursor_manager = globals [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let shm = globals [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let cursor_buffer = get_cursor_buffer(&connection, &shm); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let xdg_output_manager = globals [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let layer_shell = globals [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(state.area_info()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 226 | let output = self.outputs[self.current_screen].clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let info = &self.zxdg_outputs[self.current_screen]; [INFO] [stdout] 228 | Some(AreaInfo { [INFO] [stdout] | ______________^ [INFO] [stdout] 229 | | start_x, [INFO] [stdout] 230 | | start_y, [INFO] [stdout] 231 | | end_x, [INFO] [stdout] 232 | | end_y, [INFO] [stdout] 233 | | screen_info: info.get_screen_info(output), [INFO] [stdout] 234 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libwaysip` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `libwaysip` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "186016f2aa9a84d03095c7664146adb7252afe6396f238e0b6686d476ce35b48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186016f2aa9a84d03095c7664146adb7252afe6396f238e0b6686d476ce35b48", kill_on_drop: false }` [INFO] [stdout] 186016f2aa9a84d03095c7664146adb7252afe6396f238e0b6686d476ce35b48