[INFO] fetching crate libutp-rs 1.0.0... [INFO] checking libutp-rs-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libutp-rs 1.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate libutp-rs 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libutp-rs 1.0.0 [INFO] finished tweaking crates.io crate libutp-rs 1.0.0 [INFO] tweaked toml for crates.io crate libutp-rs 1.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate libutp-rs 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b978a9f017c2b4fa61f74c3ca24e8e94aade0e6178110e92ada0207283b8ae35 [INFO] running `Command { std: "docker" "start" "-a" "b978a9f017c2b4fa61f74c3ca24e8e94aade0e6178110e92ada0207283b8ae35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b978a9f017c2b4fa61f74c3ca24e8e94aade0e6178110e92ada0207283b8ae35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b978a9f017c2b4fa61f74c3ca24e8e94aade0e6178110e92ada0207283b8ae35", kill_on_drop: false }` [INFO] [stdout] b978a9f017c2b4fa61f74c3ca24e8e94aade0e6178110e92ada0207283b8ae35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f013e4f3fc50a67c1db1928ca31f1cbf3740c9874439d09cd7095be06325266 [INFO] running `Command { std: "docker" "start" "-a" "8f013e4f3fc50a67c1db1928ca31f1cbf3740c9874439d09cd7095be06325266", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling regex-syntax v0.6.22 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling libloading v0.7.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling thread_local v1.1.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling aho-corasick v0.7.15 [INFO] [stderr] Compiling bindgen v0.55.1 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling termcolor v1.1.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling clang-sys v1.1.1 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling tokio v1.3.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking bytesize v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling jobserver v0.1.21 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling socket2 v0.3.19 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking mio v0.7.8 [INFO] [stderr] Compiling regex v1.4.3 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Checking portpicker v0.1.0 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Compiling libutp-sys v0.1.4 [INFO] [stderr] Checking libutp-rs v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `libutp` is never read [INFO] [stdout] --> src/utp.rs:647:5 [INFO] [stdout] | [INFO] [stdout] 646 | pub struct UtpListener { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 647 | libutp: Arc>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UtpListener` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn run(mut f: F) -> ThreadRunner [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let stop_flag = StopFlag(Arc::new(AtomicBool::new(false))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread_stop_flag = stop_flag.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let handle = thread::spawn(move || f(thread_stop_flag)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ThreadRunner { [INFO] [stdout] 20 | handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 93 | on_read_ready: R, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | on_write_ready: W, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | on_err: E, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut io = Arc::new(mio::net::UdpSocket::bind(addr)?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut _event_loop = EventLoop::new(&mut io, on_read_ready, on_write_ready, on_err)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(UdpSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | io, [INFO] [stdout] 106 | | _event_loop: ThreadRunner::run(move |stop_flag| _event_loop.run(stop_flag)), [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 296 | let libutp = Arc::new(Mutex::new(LibUtp::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let writer = UtpWriter::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let on_read_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let on_err_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let on_write_writer = writer.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let io = UdpSocket::bind( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let check_timeouts = Self::start_check_timeouts(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Ok(UtpContext { libutp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 300 | let on_read_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | on_read_libutp.upgrade().map_or(false, |libutp| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:422:28 [INFO] [stdout] | [INFO] [stdout] 407 | let connector: UtpConnector = Default::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let socket = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | match ctx.connect(addr) { [INFO] [stdout] 410 | Ok(s) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | error_channel: unsafe { ctx.get_context_data().error_channel.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:442:27 [INFO] [stdout] | [INFO] [stdout] 441 | let libutp_weak = Arc::downgrade(libutp); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ThreadRunner::run(move |stop_flag| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 443 | | while !stop_flag.is_set() { [INFO] [stdout] 444 | | std::thread::sleep(std::time::Duration::from_millis(500)); [INFO] [stdout] 445 | | unsafe { [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:565:21 [INFO] [stdout] | [INFO] [stdout] 562 | fn accept(self) -> UtpSocket { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 565 | libutp: self.libutp.upgrade().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | Box::from_raw(*data as *mut C); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 68 | let _ = Box::from_raw(*data as *mut C); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | Box::from_raw(*old_data as *mut C); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 137 | let _ = Box::from_raw(*old_data as *mut C); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | Box::from_raw(socket_data as *mut S); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 284 | let _ = Box::from_raw(socket_data as *mut S); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | Box::from_raw(old_data as *mut S); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 327 | let _ = Box::from_raw(old_data as *mut S); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libutp-rs` (lib) due to 8 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `libutp` is never read [INFO] [stdout] --> src/utp.rs:647:5 [INFO] [stdout] | [INFO] [stdout] 646 | pub struct UtpListener { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 647 | libutp: Arc>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UtpListener` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn run(mut f: F) -> ThreadRunner [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let stop_flag = StopFlag(Arc::new(AtomicBool::new(false))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread_stop_flag = stop_flag.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let handle = thread::spawn(move || f(thread_stop_flag)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ThreadRunner { [INFO] [stdout] 20 | handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 93 | on_read_ready: R, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | on_write_ready: W, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | on_err: E, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut io = Arc::new(mio::net::UdpSocket::bind(addr)?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut _event_loop = EventLoop::new(&mut io, on_read_ready, on_write_ready, on_err)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(UdpSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | io, [INFO] [stdout] 106 | | _event_loop: ThreadRunner::run(move |stop_flag| _event_loop.run(stop_flag)), [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 296 | let libutp = Arc::new(Mutex::new(LibUtp::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let writer = UtpWriter::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let on_read_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let on_err_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let on_write_writer = writer.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let io = UdpSocket::bind( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let check_timeouts = Self::start_check_timeouts(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Ok(UtpContext { libutp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 300 | let on_read_libutp = Arc::downgrade(&libutp); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | on_read_libutp.upgrade().map_or(false, |libutp| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:422:28 [INFO] [stdout] | [INFO] [stdout] 407 | let connector: UtpConnector = Default::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | let socket = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 409 | match ctx.connect(addr) { [INFO] [stdout] 410 | Ok(s) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | error_channel: unsafe { ctx.get_context_data().error_channel.clone() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:442:27 [INFO] [stdout] | [INFO] [stdout] 441 | let libutp_weak = Arc::downgrade(libutp); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ThreadRunner::run(move |stop_flag| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 443 | | while !stop_flag.is_set() { [INFO] [stdout] 444 | | std::thread::sleep(std::time::Duration::from_millis(500)); [INFO] [stdout] 445 | | unsafe { [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utp.rs:565:21 [INFO] [stdout] | [INFO] [stdout] 562 | fn accept(self) -> UtpSocket { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 565 | libutp: self.libutp.upgrade().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | Box::from_raw(*data as *mut C); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 68 | let _ = Box::from_raw(*data as *mut C); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | Box::from_raw(*old_data as *mut C); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 137 | let _ = Box::from_raw(*old_data as *mut C); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | Box::from_raw(socket_data as *mut S); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 284 | let _ = Box::from_raw(socket_data as *mut S); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/wrappers.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | Box::from_raw(old_data as *mut S); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 327 | let _ = Box::from_raw(old_data as *mut S); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libutp-rs` (lib test) due to 8 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f013e4f3fc50a67c1db1928ca31f1cbf3740c9874439d09cd7095be06325266", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f013e4f3fc50a67c1db1928ca31f1cbf3740c9874439d09cd7095be06325266", kill_on_drop: false }` [INFO] [stdout] 8f013e4f3fc50a67c1db1928ca31f1cbf3740c9874439d09cd7095be06325266