[INFO] fetching crate liburing-rs 0.1.2... [INFO] checking liburing-rs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate liburing-rs 0.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate liburing-rs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate liburing-rs 0.1.2 [INFO] finished tweaking crates.io crate liburing-rs 0.1.2 [INFO] tweaked toml for crates.io crate liburing-rs 0.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate liburing-rs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49fe2956daf94f547ff09a68ef80d063e98192adea160f4f4542a39b7f20bc06 [INFO] running `Command { std: "docker" "start" "-a" "49fe2956daf94f547ff09a68ef80d063e98192adea160f4f4542a39b7f20bc06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49fe2956daf94f547ff09a68ef80d063e98192adea160f4f4542a39b7f20bc06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49fe2956daf94f547ff09a68ef80d063e98192adea160f4f4542a39b7f20bc06", kill_on_drop: false }` [INFO] [stdout] 49fe2956daf94f547ff09a68ef80d063e98192adea160f4f4542a39b7f20bc06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c8cc7ba5bc558cd87ede58ad7d6854552922dfbc82adf7f7a91421b27002619a [INFO] running `Command { std: "docker" "start" "-a" "c8cc7ba5bc558cd87ede58ad7d6854552922dfbc82adf7f7a91421b27002619a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking bytemuck v1.14.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking atomic v0.6.0 [INFO] [stderr] Checking liburing-rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `kdropped` and `array` are never read [INFO] [stdout] --> src/sq.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct SubmitQueue { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub kdropped: &'static mut AtomicU32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | pub array: &'static mut [AtomicU32], [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cq.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 33 | let ring = if p.features.contains(FeatureFlags::SINGLE_MMAP) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | khead: ring.offset_as_mut(p.cq_off.head as usize), [INFO] [stdout] 47 | | ktail: ring.offset_as_mut(p.cq_off.tail as usize), [INFO] [stdout] 48 | | _kflags: ring.offset_as_mut(p.cq_off.flags as usize), [INFO] [stdout] ... | [INFO] [stdout] 53 | | _ring: ring, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io_uring.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 37 | let fd = syscall::io_uring_setup(entries, p)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let sq = SubmitQueue::new(&fd, p)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let cq = CompleteQueue::new(&fd, p, &sq.ring)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(IoUring { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | ring_fd: Arc::new(fd), [INFO] [stdout] 43 | | sq, [INFO] [stdout] 44 | | cq, [INFO] [stdout] 45 | | flags: p.flags, [INFO] [stdout] 46 | | features: p.features, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io_uring.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut buffer = mmap::Buffer::::anonymous(entries as usize)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(BufferGroup::new(self.ring_fd.clone(), buffer, bgid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sq.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 43 | let sq_ring = mmap::Buffer::new(fd, kernel::IORING_OFF_SQ_RING, sq_ring_sz)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | sqes: mmap::Buffer::new(fd, kernel::IORING_OFF_SQES, p.sq_entries as usize)?, [INFO] [stdout] 54 | | khead: sq_ring.offset_as_mut(p.sq_off.head as usize), [INFO] [stdout] 55 | | ktail: sq_ring.offset_as_mut(p.sq_off.tail as usize), [INFO] [stdout] ... | [INFO] [stdout] 64 | | ring: std::sync::Arc::new(sq_ring), [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `liburing-rs` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `kdropped` and `array` are never read [INFO] [stdout] --> src/sq.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct SubmitQueue { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub kdropped: &'static mut AtomicU32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | pub array: &'static mut [AtomicU32], [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cq.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 33 | let ring = if p.features.contains(FeatureFlags::SINGLE_MMAP) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | khead: ring.offset_as_mut(p.cq_off.head as usize), [INFO] [stdout] 47 | | ktail: ring.offset_as_mut(p.cq_off.tail as usize), [INFO] [stdout] 48 | | _kflags: ring.offset_as_mut(p.cq_off.flags as usize), [INFO] [stdout] ... | [INFO] [stdout] 53 | | _ring: ring, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io_uring.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 37 | let fd = syscall::io_uring_setup(entries, p)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let sq = SubmitQueue::new(&fd, p)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let cq = CompleteQueue::new(&fd, p, &sq.ring)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(IoUring { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | ring_fd: Arc::new(fd), [INFO] [stdout] 43 | | sq, [INFO] [stdout] 44 | | cq, [INFO] [stdout] 45 | | flags: p.flags, [INFO] [stdout] 46 | | features: p.features, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io_uring.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut buffer = mmap::Buffer::::anonymous(entries as usize)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(BufferGroup::new(self.ring_fd.clone(), buffer, bgid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sq.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 43 | let sq_ring = mmap::Buffer::new(fd, kernel::IORING_OFF_SQ_RING, sq_ring_sz)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | sqes: mmap::Buffer::new(fd, kernel::IORING_OFF_SQES, p.sq_entries as usize)?, [INFO] [stdout] 54 | | khead: sq_ring.offset_as_mut(p.sq_off.head as usize), [INFO] [stdout] 55 | | ktail: sq_ring.offset_as_mut(p.sq_off.tail as usize), [INFO] [stdout] ... | [INFO] [stdout] 64 | | ring: std::sync::Arc::new(sq_ring), [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `liburing-rs` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c8cc7ba5bc558cd87ede58ad7d6854552922dfbc82adf7f7a91421b27002619a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8cc7ba5bc558cd87ede58ad7d6854552922dfbc82adf7f7a91421b27002619a", kill_on_drop: false }` [INFO] [stdout] c8cc7ba5bc558cd87ede58ad7d6854552922dfbc82adf7f7a91421b27002619a