[INFO] fetching crate libui 0.3.0... [INFO] checking libui-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libui 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libui 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libui 0.3.0 [INFO] finished tweaking crates.io crate libui 0.3.0 [INFO] tweaked toml for crates.io crate libui 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate libui 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 320b75f24bfa99b7e6485e57ca69aa3d4b6774a67b3d73d6d7eeb1703787ce26 [INFO] running `Command { std: "docker" "start" "-a" "320b75f24bfa99b7e6485e57ca69aa3d4b6774a67b3d73d6d7eeb1703787ce26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "320b75f24bfa99b7e6485e57ca69aa3d4b6774a67b3d73d6d7eeb1703787ce26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "320b75f24bfa99b7e6485e57ca69aa3d4b6774a67b3d73d6d7eeb1703787ce26", kill_on_drop: false }` [INFO] [stdout] 320b75f24bfa99b7e6485e57ca69aa3d4b6774a67b3d73d6d7eeb1703787ce26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79c3d5a4446aaf300e0dc9719261c0fd5415638c36dd6c699b086bc050d9ae80 [INFO] running `Command { std: "docker" "start" "-a" "79c3d5a4446aaf300e0dc9719261c0fd5415638c36dd6c699b086bc050d9ae80", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde v1.0.158 [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling prettyplease v0.2.12 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling semver v1.0.17 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling winnow v0.5.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling clang-sys v1.6.0 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling which v4.4.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling bitflags v2.3.3 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling shlex v1.1.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.7.2 [INFO] [stderr] Compiling serde_spanned v0.6.3 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling toml_edit v0.19.14 [INFO] [stderr] Compiling toml v0.7.6 [INFO] [stderr] Compiling embed-resource v2.2.0 [INFO] [stderr] Compiling libui-ffi v0.3.0 [INFO] [stderr] Checking libui v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/callback_helpers.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn to_heap_ptr(item: F) -> *mut c_void { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Box::into_raw(Box::new(item)) as *mut c_void [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 103 | pub unsafe fn set_parent_of>(&mut self, control: T, parent: Option) { [INFO] [stdout] | ---------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | libui_ffi::uiControlSetParent( [INFO] [stdout] 105 | control.into().ui_control, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/area.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | mem::forget(area_mouse_event); [INFO] [stdout] | ^^^^^^^^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `AreaMouseEvent` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(forgetting_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 70 - mem::forget(area_mouse_event); [INFO] [stdout] 70 + let _ = area_mouse_event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/area.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | mem::forget(area_key_event); [INFO] [stdout] | ^^^^^^^^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `AreaKeyEvent` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 110 - mem::forget(area_key_event); [INFO] [stdout] 110 + let _ = area_key_event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/textentry.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | mem::forget(entry); [INFO] [stdout] | ^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut uiEntry` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 146 - mem::forget(entry); [INFO] [stdout] 146 + let _ = entry; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/window.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | WINDOWS.with(|windows| windows.borrow_mut().push(window.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/window.rs:48:62 [INFO] [stdout] | [INFO] [stdout] 48 | WINDOWS.with(|windows| windows.borrow_mut().push(window.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libui` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/callback_helpers.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn to_heap_ptr(item: F) -> *mut c_void { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Box::into_raw(Box::new(item)) as *mut c_void [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/callback_helpers.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | mem::forget(actual); [INFO] [stdout] | ^^^^^^^^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut i32` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(forgetting_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 31 - mem::forget(actual); [INFO] [stdout] 31 + let _ = actual; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/mod.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 103 | pub unsafe fn set_parent_of>(&mut self, control: T, parent: Option) { [INFO] [stdout] | ---------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | libui_ffi::uiControlSetParent( [INFO] [stdout] 105 | control.into().ui_control, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/area.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | mem::forget(area_mouse_event); [INFO] [stdout] | ^^^^^^^^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `AreaMouseEvent` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(forgetting_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 70 - mem::forget(area_mouse_event); [INFO] [stdout] 70 + let _ = area_mouse_event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/area.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | mem::forget(area_key_event); [INFO] [stdout] | ^^^^^^^^^^^^--------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `AreaKeyEvent` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 110 - mem::forget(area_key_event); [INFO] [stdout] 110 + let _ = area_key_event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::forget` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/controls/textentry.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | mem::forget(entry); [INFO] [stdout] | ^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*mut uiEntry` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 146 - mem::forget(entry); [INFO] [stdout] 146 + let _ = entry; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/window.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | WINDOWS.with(|windows| windows.borrow_mut().push(window.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls/window.rs:48:62 [INFO] [stdout] | [INFO] [stdout] 48 | WINDOWS.with(|windows| windows.borrow_mut().push(window.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libui` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "79c3d5a4446aaf300e0dc9719261c0fd5415638c36dd6c699b086bc050d9ae80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79c3d5a4446aaf300e0dc9719261c0fd5415638c36dd6c699b086bc050d9ae80", kill_on_drop: false }` [INFO] [stdout] 79c3d5a4446aaf300e0dc9719261c0fd5415638c36dd6c699b086bc050d9ae80