[INFO] fetching crate libublk 0.3.0... [INFO] checking libublk-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libublk 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate libublk 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libublk 0.3.0 [INFO] finished tweaking crates.io crate libublk 0.3.0 [INFO] tweaked toml for crates.io crate libublk 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate libublk 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b1b3876b556cf9a0165bb943afef939819d661eb890189f590e0a1fd037cf23 [INFO] running `Command { std: "docker" "start" "-a" "8b1b3876b556cf9a0165bb943afef939819d661eb890189f590e0a1fd037cf23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b1b3876b556cf9a0165bb943afef939819d661eb890189f590e0a1fd037cf23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b1b3876b556cf9a0165bb943afef939819d661eb890189f590e0a1fd037cf23", kill_on_drop: false }` [INFO] [stdout] 8b1b3876b556cf9a0165bb943afef939819d661eb890189f590e0a1fd037cf23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a5addabe5636adc0e0ffef1fdb36d78ee720f9a03cb2b18a40c5e04f19d13ea [INFO] running `Command { std: "docker" "start" "-a" "8a5addabe5636adc0e0ffef1fdb36d78ee720f9a03cb2b18a40c5e04f19d13ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking value-bag v1.4.2 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Compiling bindgen v0.64.0 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking blocking v1.4.1 [INFO] [stderr] Checking async-executor v1.6.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling io-uring v0.6.2 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking bitmaps v3.2.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking udev v0.5.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking fstab v0.4.0 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking shellscript v0.3.1 [INFO] [stderr] Checking uuid v1.5.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking ilog v1.0.1 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking polling v3.4.0 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Checking async-io v2.3.1 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling derive_setters v0.1.6 [INFO] [stderr] Checking async-signal v0.2.5 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Compiling libublk v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `overwrite` [INFO] [stdout] --> build.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | #[cfg(not(feature = "overwrite"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `fat_complete` [INFO] [stdout] = help: consider adding `overwrite` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `overwrite` [INFO] [stdout] --> build.rs:63:11 [INFO] [stdout] | [INFO] [stdout] 63 | #[cfg(feature = "overwrite")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `fat_complete` [INFO] [stdout] = help: consider adding `overwrite` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking block-utils v0.11.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:1030:12 [INFO] [stdout] | [INFO] [stdout] 1019 | let inner = RwLock::new(UblkCtrlInner::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1030 | Ok(UblkCtrl { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:1152:15 [INFO] [stdout] | [INFO] [stdout] 1148 | pub(crate) fn process_ios(&self, mut ops: F, to_wait: usize) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1152 | match self.wait_ios(to_wait) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:1207:15 [INFO] [stdout] | [INFO] [stdout] 1201 | wake_handler: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1207 | match self.wait_ios(to_wait) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uring_async.rs:177:58 [INFO] [stdout] | [INFO] [stdout] 177 | let ctrl_fd = crate::ctrl::CTRL_URING.with(|refcell| refcell.borrow().as_raw_fd()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uring_async.rs:215:75 [INFO] [stdout] | [INFO] [stdout] 215 | crate::ctrl::CTRL_URING.with(|refcell| ublk_try_reap_cqe(&mut refcell.borrow_mut(), 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libublk` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:1030:12 [INFO] [stdout] | [INFO] [stdout] 1019 | let inner = RwLock::new(UblkCtrlInner::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1030 | Ok(UblkCtrl { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:1152:15 [INFO] [stdout] | [INFO] [stdout] 1148 | pub(crate) fn process_ios(&self, mut ops: F, to_wait: usize) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1152 | match self.wait_ios(to_wait) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:1207:15 [INFO] [stdout] | [INFO] [stdout] 1201 | wake_handler: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1207 | match self.wait_ios(to_wait) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uring_async.rs:177:58 [INFO] [stdout] | [INFO] [stdout] 177 | let ctrl_fd = crate::ctrl::CTRL_URING.with(|refcell| refcell.borrow().as_raw_fd()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uring_async.rs:215:75 [INFO] [stdout] | [INFO] [stdout] 215 | crate::ctrl::CTRL_URING.with(|refcell| ublk_try_reap_cqe(&mut refcell.borrow_mut(), 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libublk` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8a5addabe5636adc0e0ffef1fdb36d78ee720f9a03cb2b18a40c5e04f19d13ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a5addabe5636adc0e0ffef1fdb36d78ee720f9a03cb2b18a40c5e04f19d13ea", kill_on_drop: false }` [INFO] [stdout] 8a5addabe5636adc0e0ffef1fdb36d78ee720f9a03cb2b18a40c5e04f19d13ea