[INFO] fetching crate librqbit-upnp 0.1.1... [INFO] checking librqbit-upnp-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate librqbit-upnp 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate librqbit-upnp 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate librqbit-upnp 0.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate librqbit-upnp 0.1.1 [INFO] tweaked toml for crates.io crate librqbit-upnp 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate librqbit-upnp 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3afc9b29d9188d0ee11edd6946021b851af8ee0d38c0c05edaf621f278c0b22 [INFO] running `Command { std: "docker" "start" "-a" "b3afc9b29d9188d0ee11edd6946021b851af8ee0d38c0c05edaf621f278c0b22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3afc9b29d9188d0ee11edd6946021b851af8ee0d38c0c05edaf621f278c0b22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3afc9b29d9188d0ee11edd6946021b851af8ee0d38c0c05edaf621f278c0b22", kill_on_drop: false }` [INFO] [stdout] b3afc9b29d9188d0ee11edd6946021b851af8ee0d38c0c05edaf621f278c0b22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3408cc23630afb2d91d8047a550c6ef9e818e2a8bc3f5f5d09b866bfb2aed70 [INFO] running `Command { std: "docker" "start" "-a" "a3408cc23630afb2d91d8047a550c6ef9e818e2a8bc3f5f5d09b866bfb2aed70", kill_on_drop: false }` [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling network-interface v2.0.0 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking librqbit-upnp v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 145 | parent: Span, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> Box + '_> { [INFO] [stdout] 147 | let self_span = self.span(parent); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let services = self.service_list.services.iter().map({ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Box::new(services.chain(self.device_list.devices.iter().flat_map({ [INFO] [stdout] | __________________^ [INFO] [stdout] 153 | | let self_span = self_span.clone(); [INFO] [stdout] 154 | | move |d| d.iter_services(self_span.clone()) [INFO] [stdout] 155 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:23 [INFO] [stdout] | [INFO] [stdout] 149 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | move |s| (s.span(self_span.clone()), s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:38 [INFO] [stdout] | [INFO] [stdout] 153 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | move |d| d.iter_services(self_span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:23 [INFO] [stdout] | [INFO] [stdout] 210 | let self_span = self.span(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | .flat_map(move |d| d.iter_services(self_span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:48 [INFO] [stdout] | [INFO] [stdout] 210 | let self_span = self.span(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | .flat_map(move |d| d.iter_services(self_span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librqbit-upnp` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 145 | parent: Span, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> Box + '_> { [INFO] [stdout] 147 | let self_span = self.span(parent); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let services = self.service_list.services.iter().map({ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Box::new(services.chain(self.device_list.devices.iter().flat_map({ [INFO] [stdout] | __________________^ [INFO] [stdout] 153 | | let self_span = self_span.clone(); [INFO] [stdout] 154 | | move |d| d.iter_services(self_span.clone()) [INFO] [stdout] 155 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:23 [INFO] [stdout] | [INFO] [stdout] 149 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | move |s| (s.span(self_span.clone()), s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:38 [INFO] [stdout] | [INFO] [stdout] 153 | let self_span = self_span.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | move |d| d.iter_services(self_span.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:23 [INFO] [stdout] | [INFO] [stdout] 210 | let self_span = self.span(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | .flat_map(move |d| d.iter_services(self_span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:48 [INFO] [stdout] | [INFO] [stdout] 210 | let self_span = self.span(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | .flat_map(move |d| d.iter_services(self_span.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librqbit-upnp` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "a3408cc23630afb2d91d8047a550c6ef9e818e2a8bc3f5f5d09b866bfb2aed70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3408cc23630afb2d91d8047a550c6ef9e818e2a8bc3f5f5d09b866bfb2aed70", kill_on_drop: false }` [INFO] [stdout] a3408cc23630afb2d91d8047a550c6ef9e818e2a8bc3f5f5d09b866bfb2aed70