[INFO] fetching crate librice-proto 0.0.5... [INFO] checking librice-proto-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate librice-proto 0.0.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate librice-proto 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate librice-proto 0.0.5 [INFO] finished tweaking crates.io crate librice-proto 0.0.5 [INFO] tweaked toml for crates.io crate librice-proto 0.0.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding stun-proto v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding stun-types v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7dab3c942b14076a0dc85e1606bbd3231c97bda75e5d0e2f68c4b8b42a3907a [INFO] running `Command { std: "docker" "start" "-a" "a7dab3c942b14076a0dc85e1606bbd3231c97bda75e5d0e2f68c4b8b42a3907a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7dab3c942b14076a0dc85e1606bbd3231c97bda75e5d0e2f68c4b8b42a3907a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7dab3c942b14076a0dc85e1606bbd3231c97bda75e5d0e2f68c4b8b42a3907a", kill_on_drop: false }` [INFO] [stdout] a7dab3c942b14076a0dc85e1606bbd3231c97bda75e5d0e2f68c4b8b42a3907a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eed02919195d3da79915eabf845dcb10ceb85dbc851f6b83429f1eebbf0dd7d6 [INFO] running `Command { std: "docker" "start" "-a" "eed02919195d3da79915eabf845dcb10ceb85dbc851f6b83429f1eebbf0dd7d6", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking stun-types v0.1.0 [INFO] [stderr] Checking stun-proto v0.1.0 [INFO] [stderr] Checking librice-proto v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `TcpListenCandidate` is never constructed [INFO] [stdout] --> src/conncheck.rs:434:8 [INFO] [stdout] | [INFO] [stdout] 434 | struct TcpListenCandidate {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:396:23 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn into_owned<'b>(self) -> AgentTransmit<'b> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | transmit: self.transmit.into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 701 | others: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | ) -> Option<&'pair CandidatePair> { [INFO] [stdout] 703 | others.into_iter().find(|&pair| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:227:22 [INFO] [stdout] | [INFO] [stdout] 212 | agent: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let inner = Arc::new(Mutex::new(ConnCheckState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | variant: ConnCheckVariant::Agent(agent), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:358:12 [INFO] [stdout] | [INFO] [stdout] 341 | let mut msg = Message::builder_request(BINDING); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | Ok(msg.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1389:30 [INFO] [stdout] | [INFO] [stdout] 1388 | let nominated = self.pairs.iter().find(|check| check.nominate()).cloned(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1389 | nominated.or({ [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1390 | | let mut valid: Vec<_> = self [INFO] [stdout] 1391 | | .valid [INFO] [stdout] 1392 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 1412 | | } [INFO] [stdout] 1413 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1687:27 [INFO] [stdout] | [INFO] [stdout] 1687 | .map(|agent| (agent.clone(), checklist_i)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1695:43 [INFO] [stdout] | [INFO] [stdout] 1695 | ... .map(|agent| (agent.clone(), checklist.checklist_id)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:2049:12 [INFO] [stdout] | [INFO] [stdout] 1785 | agent: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1819 | let peer_nominating = if let Some(use_candidate_raw) = msg.raw_attribute(UseCandidate::TYPE) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1824 | let response = Message::bad_request(msg); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1834 | let response = Message::bad_request(msg); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2049 | Ok(Some(binding_success_response( [INFO] [stdout] | ____________^ [INFO] [stdout] 2050 | | msg, [INFO] [stdout] 2051 | | from, [INFO] [stdout] 2052 | | local_credentials, [INFO] [stdout] 2053 | | )?)) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:2286:12 [INFO] [stdout] | [INFO] [stdout] 2242 | conncheck: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2247 | let mut inner = conncheck.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2267 | let agent = agent.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2268 | [INFO] [stdout] 2269 | let stun_request = ConnCheck::generate_stun_request( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2281 | let mut agent = agent.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2282 | [INFO] [stdout] 2283 | let transmit = agent [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2286 | Ok(CheckListSetPollRet::Transmit( [INFO] [stdout] | ____________^ [INFO] [stdout] 2287 | | conncheck.checklist_id, [INFO] [stdout] 2288 | | conncheck.pair.local.component_id, [INFO] [stdout] 2289 | | transmit.into_owned(), [INFO] [stdout] 2290 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librice-proto` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TcpListenCandidate` is never constructed [INFO] [stdout] --> src/conncheck.rs:434:8 [INFO] [stdout] | [INFO] [stdout] 434 | struct TcpListenCandidate {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:396:23 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn into_owned<'b>(self) -> AgentTransmit<'b> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | transmit: self.transmit.into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 701 | others: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | ) -> Option<&'pair CandidatePair> { [INFO] [stdout] 703 | others.into_iter().find(|&pair| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:227:22 [INFO] [stdout] | [INFO] [stdout] 212 | agent: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let inner = Arc::new(Mutex::new(ConnCheckState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | variant: ConnCheckVariant::Agent(agent), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:358:12 [INFO] [stdout] | [INFO] [stdout] 341 | let mut msg = Message::builder_request(BINDING); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | Ok(msg.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1389:30 [INFO] [stdout] | [INFO] [stdout] 1388 | let nominated = self.pairs.iter().find(|check| check.nominate()).cloned(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1389 | nominated.or({ [INFO] [stdout] | ______________________________^ [INFO] [stdout] 1390 | | let mut valid: Vec<_> = self [INFO] [stdout] 1391 | | .valid [INFO] [stdout] 1392 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 1412 | | } [INFO] [stdout] 1413 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1687:27 [INFO] [stdout] | [INFO] [stdout] 1687 | .map(|agent| (agent.clone(), checklist_i)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:1695:43 [INFO] [stdout] | [INFO] [stdout] 1695 | ... .map(|agent| (agent.clone(), checklist.checklist_id)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:2049:12 [INFO] [stdout] | [INFO] [stdout] 1785 | agent: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1819 | let peer_nominating = if let Some(use_candidate_raw) = msg.raw_attribute(UseCandidate::TYPE) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1824 | let response = Message::bad_request(msg); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1834 | let response = Message::bad_request(msg); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2049 | Ok(Some(binding_success_response( [INFO] [stdout] | ____________^ [INFO] [stdout] 2050 | | msg, [INFO] [stdout] 2051 | | from, [INFO] [stdout] 2052 | | local_credentials, [INFO] [stdout] 2053 | | )?)) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:2286:12 [INFO] [stdout] | [INFO] [stdout] 2242 | conncheck: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2247 | let mut inner = conncheck.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2267 | let agent = agent.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2268 | [INFO] [stdout] 2269 | let stun_request = ConnCheck::generate_stun_request( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2281 | let mut agent = agent.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2282 | [INFO] [stdout] 2283 | let transmit = agent [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2286 | Ok(CheckListSetPollRet::Transmit( [INFO] [stdout] | ____________^ [INFO] [stdout] 2287 | | conncheck.checklist_id, [INFO] [stdout] 2288 | | conncheck.pair.local.component_id, [INFO] [stdout] 2289 | | transmit.into_owned(), [INFO] [stdout] 2290 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conncheck.rs:3253:24 [INFO] [stdout] | [INFO] [stdout] 3234 | let mut local_set = ConnCheckListSet::builder(0, self.controlling) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3253 | local: FineControlPeer { [INFO] [stdout] | ________________________^ [INFO] [stdout] 3254 | | component_id: 1, [INFO] [stdout] 3255 | | peer: local_peer, [INFO] [stdout] 3256 | | checklist_set: local_set, [INFO] [stdout] 3257 | | checklist_id, [INFO] [stdout] 3258 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librice-proto` (lib test) due to 11 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "eed02919195d3da79915eabf845dcb10ceb85dbc851f6b83429f1eebbf0dd7d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eed02919195d3da79915eabf845dcb10ceb85dbc851f6b83429f1eebbf0dd7d6", kill_on_drop: false }` [INFO] [stdout] eed02919195d3da79915eabf845dcb10ceb85dbc851f6b83429f1eebbf0dd7d6