[INFO] fetching crate librice 0.0.5... [INFO] checking librice-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate librice 0.0.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate librice 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate librice 0.0.5 [INFO] finished tweaking crates.io crate librice 0.0.5 [INFO] tweaked toml for crates.io crate librice 0.0.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate librice 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fccff42a6afc3d4928061addfedecbcc092eb820eb897e33aab49e76af43f8b8 [INFO] running `Command { std: "docker" "start" "-a" "fccff42a6afc3d4928061addfedecbcc092eb820eb897e33aab49e76af43f8b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fccff42a6afc3d4928061addfedecbcc092eb820eb897e33aab49e76af43f8b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fccff42a6afc3d4928061addfedecbcc092eb820eb897e33aab49e76af43f8b8", kill_on_drop: false }` [INFO] [stdout] fccff42a6afc3d4928061addfedecbcc092eb820eb897e33aab49e76af43f8b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84eb847085e306a7dc87794e7fc6eff47f8ca00d8afdc68f2be52d627d60dea4 [INFO] running `Command { std: "docker" "start" "-a" "84eb847085e306a7dc87794e7fc6eff47f8ca00d8afdc68f2be52d627d60dea4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking value-bag v1.7.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-channel v2.1.1 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking polling v3.3.2 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking stun-types v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking async-io v2.3.1 [INFO] [stderr] Checking stun-proto v0.1.0 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking librice-proto v0.0.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking librice v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 80 | let agent = Arc::new(Mutex::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | inner: Arc::new(Mutex::new(AgentInner::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 39 | weak_agent: Weak>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: Arc::new(Mutex::new(ComponentInner::new(id))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub(crate) fn set_selected_pair(&self, selected: SelectedPair) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | self.inner.lock().unwrap().set_selected_pair(selected) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gathering.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(futures::stream::iter(ifaces.clone()) [INFO] [stdout] | ________^ [INFO] [stdout] 77 | | .then(|iface| async move { [INFO] [stdout] 78 | | Ok(GatherSocket::Udp(UdpSocketChannel::new( [INFO] [stdout] 79 | | UdpSocket::bind(SocketAddr::new(iface.clone().ip(), 0)).await?, [INFO] [stdout] ... | [INFO] [stdout] 85 | | ))) [INFO] [stdout] 86 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | socket: DebugWrapper::wrap(Arc::new(socket), "..."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | inner: DebugWrapper::wrap( [INFO] [stdout] | ____________________^ [INFO] [stdout] 121 | | Arc::new(Mutex::new(UdpSocketChannelInner { closed: false })), [INFO] [stdout] 122 | | "...", [INFO] [stdout] 123 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 162 | stream::unfold(self.clone(), |this| async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Some(((ret, from), this)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (tx, mut rx) = async_std::channel::bounded::>(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let sender_task = async_std::task::spawn({ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | stream: DebugWrapper::wrap(stream, "..."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (tx, mut rx) = async_std::channel::bounded::>(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let sender_task = async_std::task::spawn({ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | sender_task: Arc::new(async_std::sync::Mutex::new(Some(sender_task))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 274 | let stream = self.stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | // TODO: replace self.running_buffer when done? drop handler? [INFO] [stdout] 276 | let span = debug_span!("tcp_recv"); [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | / stream::unfold(stream, |mut stream| async move { [INFO] [stdout] 278 | | TcpChannel::inner_recv(&mut stream) [INFO] [stdout] 279 | | .await [INFO] [stdout] 280 | | .ok() [INFO] [stdout] 281 | | .map(|v| ((v.data, v.address), stream)) [INFO] [stdout] 282 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 274 | let stream = self.stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | // TODO: replace self.running_buffer when done? drop handler? [INFO] [stdout] 276 | let span = debug_span!("tcp_recv"); [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | .instrument(span.or_current()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 277 | stream::unfold(stream, |mut stream| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | / TcpChannel::inner_recv(&mut stream) [INFO] [stdout] 279 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:281:22 [INFO] [stdout] | [INFO] [stdout] 277 | stream::unfold(stream, |mut stream| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | .map(|v| ((v.data, v.address), stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 331 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | .unwrap_or(&None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stun.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(channel: StunChannel) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let internal = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | agent: internal, [INFO] [stdout] 36 | | channel, [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librice` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 80 | let agent = Arc::new(Mutex::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | inner: Arc::new(Mutex::new(AgentInner::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 39 | weak_agent: Weak>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: Arc::new(Mutex::new(ComponentInner::new(id))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub(crate) fn set_selected_pair(&self, selected: SelectedPair) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | self.inner.lock().unwrap().set_selected_pair(selected) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gathering.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(futures::stream::iter(ifaces.clone()) [INFO] [stdout] | ________^ [INFO] [stdout] 77 | | .then(|iface| async move { [INFO] [stdout] 78 | | Ok(GatherSocket::Udp(UdpSocketChannel::new( [INFO] [stdout] 79 | | UdpSocket::bind(SocketAddr::new(iface.clone().ip(), 0)).await?, [INFO] [stdout] ... | [INFO] [stdout] 85 | | ))) [INFO] [stdout] 86 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | socket: DebugWrapper::wrap(Arc::new(socket), "..."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | inner: DebugWrapper::wrap( [INFO] [stdout] | ____________________^ [INFO] [stdout] 121 | | Arc::new(Mutex::new(UdpSocketChannelInner { closed: false })), [INFO] [stdout] 122 | | "...", [INFO] [stdout] 123 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 162 | stream::unfold(self.clone(), |this| async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Some(((ret, from), this)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (tx, mut rx) = async_std::channel::bounded::>(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let sender_task = async_std::task::spawn({ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | stream: DebugWrapper::wrap(stream, "..."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (tx, mut rx) = async_std::channel::bounded::>(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let sender_task = async_std::task::spawn({ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut stream = stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | sender_task: Arc::new(async_std::sync::Mutex::new(Some(sender_task))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 274 | let stream = self.stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | // TODO: replace self.running_buffer when done? drop handler? [INFO] [stdout] 276 | let span = debug_span!("tcp_recv"); [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | / stream::unfold(stream, |mut stream| async move { [INFO] [stdout] 278 | | TcpChannel::inner_recv(&mut stream) [INFO] [stdout] 279 | | .await [INFO] [stdout] 280 | | .ok() [INFO] [stdout] 281 | | .map(|v| ((v.data, v.address), stream)) [INFO] [stdout] 282 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 274 | let stream = self.stream.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | // TODO: replace self.running_buffer when done? drop handler? [INFO] [stdout] 276 | let span = debug_span!("tcp_recv"); [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | .instrument(span.or_current()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 277 | stream::unfold(stream, |mut stream| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | / TcpChannel::inner_recv(&mut stream) [INFO] [stdout] 279 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:281:22 [INFO] [stdout] | [INFO] [stdout] 277 | stream::unfold(stream, |mut stream| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | .map(|v| ((v.data, v.address), stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:335:25 [INFO] [stdout] | [INFO] [stdout] 331 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | .unwrap_or(&None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stun.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(channel: StunChannel) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let internal = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | agent: internal, [INFO] [stdout] 36 | | channel, [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `librice` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "84eb847085e306a7dc87794e7fc6eff47f8ca00d8afdc68f2be52d627d60dea4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84eb847085e306a7dc87794e7fc6eff47f8ca00d8afdc68f2be52d627d60dea4", kill_on_drop: false }` [INFO] [stdout] 84eb847085e306a7dc87794e7fc6eff47f8ca00d8afdc68f2be52d627d60dea4